Uh oh!
There was an error while loading. Please reload this page.
boards: add WCL platform - #10007
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for the Wildcat Lake (WCL) platform by updating configuration files and adding new platform definitions. Key changes include:
- Updating the Zephyr west manifest to point to a PR revision.
- Adding a new configuration file (wcl.toml.h) and updating various TOML configuration files to use the SOC_INTEL_ACE30 condition.
- Introducing new platform entries in the platform configuration script and updating sample YAML tests.
Reviewed Changes
Copilot reviewed 15 out of 19 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| west.yml | Updated Zephyr revision to track the PR branch revision. |
| tools/rimage/config/wcl.toml.h | New configuration file for the WCL platform. |
| tools/rimage/config/platform.toml | Updated conditional macro from CONFIG_PANTHERLAKE to CONFIG_SOC_INTEL_ACE30. |
| src/samples/audio/smart_amp_test.toml | Updated condition macros for platform support. |
| src/debug/tester/tester.toml | Updated condition macros for platform support. |
| src/audio/volume/volume.toml | Updated conditional macros for platform support. |
| src/audio/up_down_mixer/up_down_mixer.toml | Updated conditional macros for platform support. |
| src/audio/src/src.toml | Updated conditional macros for platform support. |
| src/audio/selector/selector.toml | Updated conditional macros for platform support. |
| src/audio/mixin_mixout/mixin_mixout.toml | Updated conditional macros for platform support. |
| src/audio/eq_iir/eq_iir.toml | Updated conditional macros for platform support. |
| src/audio/copier/copier.toml | Updated conditional macros for platform support. |
| src/audio/asrc/asrc.toml | Updated conditional macros for platform support. |
| scripts/xtensa-build-zephyr.py | Added new platform entries (wcl-sim and wcl) to the configuration. |
| app/sample.yaml | Added test entries for the new WCL platform. |
Files not reviewed (4)
- app/boards/intel_adsp_ace30_wcl.conf: Language not supported
- app/boards/intel_adsp_ace30_wcl_sim.conf: Language not supported
- app/overlays/wcl/fpga_overlay.conf: Language not supported
- src/platform/Kconfig: Language not supported
Uh oh!
There was an error while loading. Please reload this page.
lyakh
commented
May 14, 2025
let's mark it DNM until zephyrproject-rtos/zephyr#89899 is merged |
|
kv2019i
commented
May 16, 2025
@abonislawski you need to rebase once more, I just merged #10011 as I want to cherry-pick that for stable-v2.13 (while this is post-2.13). |
adds WCL support in zephyr 7918839 intel_adsp: ace30: Bring up ACE 3.0 (WCL) 9c29839 dts: intel_adsp_ace30: merge and cleanup ace30 dtsi files Signed-off-by: Adrian Bonislawski <adrian.bonislawski@intel.com>
Add support for the Wildcat Lake platform. Signed-off-by: Adrian Bonislawski <adrian.bonislawski@intel.com> Signed-off-by: Grzegorz Bernat <grzegorzx.bernat@intel.com>
@abonislawski@kv2019i in Internal Intel CI System building and testing are ok, if the rest is ok too, please merge quickly so we can build and test WCL permanently |
| config WILDCATLAKE | ||
| bool "Build for Wildcatlake" | ||
| select ACE | ||
| select ACE_VERSION_3_0 |
There was a problem hiding this comment.
select ACE_VERSION_3_0 but other files use CONFIG_SOC_INTEL_ACE30. Is it correct?
There was a problem hiding this comment.
Yes, this is only for ace version reporting in IPC, actually we could completely remove this select and just use zephyr kconfigs to determine version but its a story for another PR
There was a problem hiding this comment.
I checked, and it looks like the ACE_VERSION_x_0 definitions set the value of ACE_VERSION. This is mainly used by the dai driver. I agree that this needs to be changed in a separate pr.
Add support for the Wildcat Lake platform.
Zephyr PR: