Skip to content

Module api rest of the modules - #10195

Closed
jsarha wants to merge 41 commits into
thesofproject:mainfrom
jsarha:module_api_rest_of_the_modules
Closed

Module api rest of the modules#10195
jsarha wants to merge 41 commits into
thesofproject:mainfrom
jsarha:module_api_rest_of_the_modules

Conversation

@jsarha

@jsarhajsarha commented Aug 26, 2025•
edited
Loading

Copy link
Copy Markdown
Contributor

Modules ASRC, Aria, Copier, crossover, multiband_drc, and DRC were aready once reviewed as part of #10164 .

@jsarha
jsarhaforce-pushed the module_api_rest_of_the_modules branch 3 times, most recently from 5a81bd2 to 69b18c4CompareAugust 27, 2025 14:40
@jsarhajsarha mentioned this pull request Aug 27, 2025
Merged
@jsarha
jsarhaforce-pushed the module_api_rest_of_the_modules branch 3 times, most recently from 6067aa8 to 32e83e3CompareSeptember 3, 2025 16:08
lgirdwood
lgirdwood reviewed Sep 4, 2025
View reviewed changes
Comment threadsrc/audio/module_adapter/module/generic.c Outdated
Comment on lines +193 to +194
else
ptr = rballoc(SOF_MEM_FLAG_USER, size);
ptr = rmalloc(SOF_MEM_FLAG_USER, size);

@lgirdwoodlgirdwoodSep 4, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we also rmalloc_aligned() above for rballoc_aligned()

@jsarhajsarhaSep 4, 2025•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is a good question. Pretty much the same as should we use virtual heap in the modules at all? There were some rballoc_aligned() calls in the modules, but I do not recall any rmalloc_aligned() calls.

And there is a reason for that. There is no rmalloc_aligned() at the moment. I can of cource easily create one in zephyr/lib/alloc.c and follow the pattern that call is alway forwarded to zephyr system heap. Should I take that route?

@jsarhajsarhaSep 4, 2025

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I created rmalloc_align() and took that into use.

@jsarha
jsarhaforce-pushed the module_api_rest_of_the_modules branch 2 times, most recently from 6d16a80 to 8f5ea1cCompareSeptember 4, 2025 18:33
@jsarha
jsarha marked this pull request as ready for review September 5, 2025 08:37
CopilotAI review requested due to automatic review settings September 5, 2025 08:37
@jsarha

jsarha commented Sep 5, 2025

Copy link
Copy Markdown
ContributorAuthor

Please let me know if you want me to split this into multiple PRs.

This comment was marked as outdated.

Sign in to view

@jsarha
jsarhaforce-pushed the module_api_rest_of_the_modules branch from 8f5ea1c to 2337ac2CompareSeptember 5, 2025 08:46
Jyri Sarha added 25 commits October 21, 2025 12:13
Jyri Sarha
cmocka: math: Test using module memory API math function
2d06c9d
Convert auditory, dct, fft, and matrix math tests to use module heap
API functions instead of the old version using rmalloc() and friends
directly.
Signed-off-by: Jyri Sarha <jyri.sarha@linux.intel.com>
Jyri Sarha
Math: Remove directly heap using math functions
573e07a
Both unit tests and modules should now use the module API heap
allocation functions, so we can now remove the directly heap using
versions.
Signed-off-by: Jyri Sarha <jyri.sarha@linux.intel.com>
Jyri Sarha
audio: mixer: Memory, blob, and fast_get allocs to module API
51d59c6
Allocate all memory, blob handlers, and fast_get() buffers through
module API mod_alloc() and friends and remove all redundant rfree(),
comp_data_blob_handler_free(), and fast_put() calls from module unload
functions and init error branches.
Signed-off-by: Jyri Sarha <jyri.sarha@linux.intel.com>
Jyri Sarha
Audio: mixin_mixout: Memory, blob, and fast_get allocs to module API
9da3ac2
Allocate all memory, blob handlers, and fast_get() buffers through
module API mod_alloc() and friends and remove all redundant rfree(),
comp_data_blob_handler_free(), and fast_put() calls from module unload
functions and init error branches.
Signed-off-by: Jyri Sarha <jyri.sarha@linux.intel.com>
Jyri Sarha
Audio: Mux: Memory, blob, and fast_get allocs to module API
d3f4de0
Allocate all memory, blob handlers, and fast_get() buffers through
module API mod_alloc() and friends and remove all redundant rfree(),
comp_data_blob_handler_free(), and fast_put() calls from module unload
functions and init error branches.
Signed-off-by: Jyri Sarha <jyri.sarha@linux.intel.com>
Jyri Sarha
Audio: NXP: Memory, blob, and fast_get allocs to module API
0d8130c
Allocate all memory, blob handlers, and fast_get() buffers through
module API mod_alloc() and friends and remove all redundant rfree(),
comp_data_blob_handler_free(), and fast_put() calls from module unload
functions and init error branches. The rballoc() calls are converted
to mod_balloc(), except module pdata is allocated with mod_alloc() as
its obviously not an audio buffer.
Signed-off-by: Jyri Sarha <jyri.sarha@linux.intel.com>
Jyri Sarha
Audio: RTNR: Memory, blob, and fast_get allocs to module API
63527e7
Allocate all memory, blob handlers, and fast_get() buffers through
module API mod_alloc() and friends and remove all redundant rfree(),
comp_data_blob_handler_free(), and fast_put() calls from module unload
functions and init error branches.
However, the rtnr_stub's heap access, rtk_alloc() and rtk_free() still
use heap directly like before.
Signed-off-by: Jyri Sarha <jyri.sarha@linux.intel.com>
Jyri Sarha
Audio: Selector: Memory, blob, and fast_get allocs to module API
91f317e
Allocate all memory, blob handlers, and fast_get() buffers through
module API mod_alloc() and friends and remove all redundant rfree(),
comp_data_blob_handler_free(), and fast_put() calls from module unload
functions and init error branches.
The IPC3 implementation of selector uses the component interface
directly and can not use the new module API.
Signed-off-by: Jyri Sarha <jyri.sarha@linux.intel.com>
Jyri Sarha
Audio: TDFB: Memory, blob, and fast_get allocs to module API
f6e4caf
Allocate all memory, blob handlers, and fast_get() buffers through
module API mod_alloc() and friends and remove all redundant rfree(),
comp_data_blob_handler_free(), and fast_put() calls from module unload
functions and init error branches. The one rballoc() call is converted
to mod_balloc().
Signed-off-by: Jyri Sarha <jyri.sarha@linux.intel.com>
Jyri Sarha
Audio: Template_comp: Memory, blob, and fast_get allocs to module API
810fdec
Allocate all memory, blob handlers, and fast_get() buffers through
module API mod_alloc() and friends and remove all redundant rfree(),
comp_data_blob_handler_free(), and fast_put() calls from module unload
functions and init error branches.
Signed-off-by: Jyri Sarha <jyri.sarha@linux.intel.com>
Jyri Sarha
modules: tensorflow: Memory, blob, and fast_get allocs to module API
3f76270
Allocate all memory, blob handlers, and fast_get() buffers through
module API mod_alloc() and friends and remove all redundant rfree(),
comp_data_blob_handler_free(), and fast_put() calls from module unload
functions and init error branches.
Signed-off-by: Jyri Sarha <jyri.sarha@linux.intel.com>
Jyri Sarha
Audio: up_down_mixer: Memory, blob, and fast_get allocs to module API
0cf6f48
Allocate all memory, blob handlers, and fast_get() buffers through
module API mod_alloc() and friends and remove all redundant rfree(),
comp_data_blob_handler_free(), and fast_put() calls from module unload
functions and init error branches. The two rballoc() calls are
converted to mod_balloc().
Signed-off-by: Jyri Sarha <jyri.sarha@linux.intel.com>
Jyri Sarha
audio: volume: Memory, blob, and fast_get allocs to module API
269db0a
Allocate all memory, blob handlers, and fast_get() buffers through
module API mod_alloc() and friends and remove all redundant rfree(),
comp_data_blob_handler_free(), and fast_put() calls from module unload
functions and init error branches.
Signed-off-by: Jyri Sarha <jyri.sarha@linux.intel.com>
Jyri Sarha
Math: auditory: Add mod_psy_free_mel_filterbank()
47081fe
Add mod_psy_free_mel_filterbank() for freeing the allocated memory.
Signed-off-by: Jyri Sarha <jyri.sarha@linux.intel.com>
Jyri Sarha
cmocka: math: auditiory: Fix memory leaks
8f30198
Fix memory leaks from auditory cmocka test.
Signed-off-by: Jyri Sarha <jyri.sarha@linux.intel.com>
Jyri Sarha
cmocka: math: fft: Fix memory leaks
b334929
Fix all memory leaks found from fft test when tests were run under
Valgrind.
Signed-off-by: Jyri Sarha <jyri.sarha@linux.intel.com>
Jyri Sarha
cmocka: math: matrix: Fix memory leaks
bbb22ef
Fix all memory leaks found from matrix test when tests were run under
Valgrind.
Signed-off-by: Jyri Sarha <jyri.sarha@linux.intel.com>
Jyri Sarha
Math: DCT: Add mod_dct_free_16()
8d3cb4a
Add mod_dct_free_16() to free memory allocated by mod_dct_initialize_16().
Signed-off-by: Jyri Sarha <jyri.sarha@linux.intel.com>
Jyri Sarha
cmocka: math: dct: Fix memory leaks
1f229a5
Fix memory leaks found by running the tests with Valgrind.
Signed-off-by: Jyri Sarha <jyri.sarha@linux.intel.com>
Jyri Sarha
cmocka: module_adapter_test: Fix memory freeing error
ee1a910
Fix memory freeing error from module_adapter_test_free(). Use
free_test_source() for sources, not free_test_sink().
Signed-off-by: Jyri Sarha <jyri.sarha@linux.intel.com>
Jyri Sarha
cmocka: volume: Fix memory leaks
7a331e6
Fix all memory leaks found from volume test when tests were run under
Valgrind.
Signed-off-by: Jyri Sarha <jyri.sarha@linux.intel.com>
Jyri Sarha
cmocka: mux_copy: Fix memory leaks
8b87136
Fix all memory leaks found from mux_copy test when tests were run under
Valgrind.
Signed-off-by: Jyri Sarha <jyri.sarha@linux.intel.com>
Jyri Sarha
cmocka: demux_copy: Fix memory leaks
01baab9
Fix all memory leaks found from demux_copy test when tests were run under
Valgrind.
Signed-off-by: Jyri Sarha <jyri.sarha@linux.intel.com>
Jyri Sarha
cmocka: pipeline: Fix memory leaks
f31234f
Fix all memory leaks found from all pipeline tests when tests were run
under Valgrind.
Signed-off-by: Jyri Sarha <jyri.sarha@linux.intel.com>
Jyri Sarha
src/audio/module_adapter/module/generic.c: HACK: use rballoc() for mo…
fce2c50
…d_alloc()
@jsarha
jsarhaforce-pushed the module_api_rest_of_the_modules branch from c624018 to fce2c50CompareOctober 21, 2025 09:13
Jyri Sarha
modules: Apparently asking 0 alignment is dangerous, use ptr size
c449fe3
The current rballoc_align() implementation has this line:
assert(IS_ALIGNED(mem, align));
Which will cause division by zero due to IS_ALIGNED() Zephyr
implementation:
define IS_ALIGNED(ptr, align) (((uintptr_t)(ptr)) % (align) == 0)
So better use sizeof(void *) as the default value.
Signed-off-by: Jyri Sarha <jyri.sarha@linux.intel.com>
@jsarha
jsarhaforce-pushed the module_api_rest_of_the_modules branch from f042224 to c449fe3CompareOctober 24, 2025 12:17
@jsarha

jsarha commented Nov 12, 2025

Copy link
Copy Markdown
ContributorAuthor

All these commits, or their further developed versions have been merged.

@jsarhajsarha closed this Nov 12, 2025
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lyakhlyakhlyakh left review comments
@lgirdwoodlgirdwoodlgirdwood left review comments
Copilot code reviewCopilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@dabekjakubdabekjakubAwaiting requested review from dabekjakub
@kv2019ikv2019iAwaiting requested review from kv2019ikv2019i is a code owner
@iuliana-prodaniuliana-prodanAwaiting requested review from iuliana-prodan
@dbalutadbalutaAwaiting requested review from dbalutadbaluta is a code owner
@abonislawskiabonislawskiAwaiting requested review from abonislawskiabonislawski is a code owner
@singalsusingalsuAwaiting requested review from singalsusingalsu is a code owner
@tlissowstlissowsAwaiting requested review from tlissowstlissows is a code owner
@fkwasowifkwasowiAwaiting requested review from fkwasowifkwasowi is a code owner
@RanderWangRanderWangAwaiting requested review from RanderWang
@pblaszkopblaszkoAwaiting requested review from pblaszkopblaszko is a code owner
@plbossartplbossartAwaiting requested review from plbossartplbossart is a code owner
@mmaka1mmaka1Awaiting requested review from mmaka1mmaka1 is a code owner
@lbetlejlbetlejAwaiting requested review from lbetlejlbetlej is a code owner
@softwareckisoftwareckiAwaiting requested review from softwarecki

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@jsarha@kv2019i@lyakh@lgirdwood