dai: uaol: add support for Intel UAOL by serhiy-katsyuba-intel · Pull Request #10567 · thesofproject/sof

serhiy-katsyuba-intel · 2026-02-20T16:01:51Z

Adds support for Intel USB Audio Offload Link (UAOL) DAI.

This is a revival of the old closed UAOL PR #9227.

Zephyr PR zephyrproject-rtos/zephyr#104137 is now merged.

serhiy-katsyuba-intel · 2026-02-23T11:37:35Z

SOFCI TEST

lgirdwood

LGTM

Copilot

Pull request overview

Adds Intel USB Audio Offload Link (UAOL) DAI support across the SOF/Zephyr integration and IPC4 paths, including capability reporting and node-id mapping.

Changes:

Update West manifest to a Zephyr revision that includes UAOL-related support.
Introduce the SOF_DAI_INTEL_UAOL type and wire it through DAI selection/config paths.
Add UAOL capability advertisement and UAOL stream-id → HDA link stream-id mapping for IPC4 DMA control.

Reviewed changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
west.yml	Bumps Zephyr revision required for UAOL enablement.
src/lib/dai.c	Registers UAOL devices and maps UAOL to the Zephyr DAI type / DMA caps.
src/ipc/ipc4/dai.c	Adds UAOL handling for link config and DMA channel selection.
src/include/ipc/dai.h	Introduces `SOF_DAI_INTEL_UAOL` enum value.
src/audio/dai-zephyr.c	Adds UAOL case to Zephyr DAI configuration.
src/audio/copier/copier_dai.c	Adds UAOL stream link classes to DAI creation path.
src/audio/copier/copier.c	Routes UAOL stream link classes to `copier_dai_create()`.
src/audio/base_fw_intel.c	Advertises UAOL support/caps and maps UAOL node indices for DMA control.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.

Copilot · 2026-03-05T16:30:28Z

+	const size_t dev_count = ARRAY_SIZE(uaol_devs);
+	struct uaol_capabilities dev_cap;
+	struct ipc4_uaol_capabilities *caps = (struct ipc4_uaol_capabilities *)tuple->value;
+	size_t caps_size = offsetof(struct ipc4_uaol_capabilities, link_caps[dev_count]);


offsetof(struct ..., link_caps[dev_count]) uses a non-constant array index; this is not valid with standard offsetof/__builtin_offsetof and can fail to compile. Compute the size as sizeof(*caps) + dev_count * sizeof(caps->link_caps[0]) (or the equivalent using the element type) instead.
Suggested change
size_tcaps_size=offsetof(structipc4_uaol_capabilities, link_caps[dev_count]);
size_tcaps_size=sizeof(*caps) +dev_count*sizeof(caps->link_caps[0]);

Copilot · 2026-03-05T16:30:29Z

+	case SOF_DAI_INTEL_UAOL:
+ link_cfg.full = 0;
+ link_cfg.part.hchan = gtw_fmt->channels_count - 1;
+ link_cfg.part.dir = common_config->direction;
+ link_cfg.part.stream = common_config->host_dma_config[0]->stream_id;
+ break;


hchan is derived as channels_count - 1. If channels_count is 0, this underflows and encodes an invalid hchan value. Clamp or validate the channel count before subtracting (e.g., ensure the minimum encoded value is 0 and only subtract when channels_count > 0).

lgirdwood · 2026-03-05T20:02:14Z

@serhiy-katsyuba-intel I assuming CI will test this now ?

serhiy-katsyuba-intel · 2026-03-06T10:32:29Z

@serhiy-katsyuba-intel I assuming CI will test this now ?

Currently, CI does not have any UAOL tests enabled. Therefore, it can only test for potential regressions to existing functionality but cannot test the UAOL feature itself.

Unfortunately, the Zephyr folks want to revert the Zephyr UAOL PR because it introduced a new driver type apparently without proper architectural discussion: zephyrproject-rtos/zephyr#104976. As a result, I'll change this PR to draft status for now. :-(

serhiy-katsyuba-intel · 2026-03-13T12:16:12Z

Unfortunately, the Zephyr folks want to revert the Zephyr UAOL PR because it introduced a new driver type apparently without proper architectural discussion: zephyrproject-rtos/zephyr#104976. As a result, I'll change this PR to draft status for now. :-(

It seems that everything is now resolved with Zephyr's UAOL driver future. I am changing this PR from draft status to ready for review.

kv2019i

Looks good, only one change to the last patch.

kv2019i · 2026-03-13T13:45:47Z

+ caps->link_caps[i].max_rx_fifo_size = dev_cap.max_rx_fifo_size;
+	}
+
+	tlv_value_set(tuple, type, caps_size, caps);


Not related to this PR, but reminds me we'd to add better protections against overrunning the IPC mailbox size. The overall length of the TLV is not known in these functions now, and it will be difficult to debug if we excedeed the space. Most of these are by definition ok as the structure is fixed and defined in FW.

kv2019i

Thanks @serhiy-katsyuba-intel !

lgirdwood · 2026-03-19T12:21:04Z

Unfortunately, the Zephyr folks want to revert the Zephyr UAOL PR because it introduced a new driver type apparently without proper architectural discussion: zephyrproject-rtos/zephyr#104976. As a result, I'll change this PR to draft status for now. :-(
It seems that everything is now resolved with Zephyr's UAOL driver future. I am changing this PR from draft status to ready for review.

@serhiy-katsyuba-intel are we now good with all dependencies or do we need a west update as I see some CI failures ?

serhiy-katsyuba-intel · 2026-03-19T12:38:25Z

@serhiy-katsyuba-intel are we now good with all dependencies or do we need a west update as I see some CI failures ?

west.yml in this PR is already updated and points to proper last UAOL commit in Zephyr.

serhiy-katsyuba-intel · 2026-03-19T12:47:40Z

I see several CI checks are failing with Could NOT find Python3: Found unsuitable version "3.10.11", but required is at least "3.12" and another few fails are related to NXP HAL. Unlikely, this PR can cause such errors.

lgirdwood · 2026-03-19T13:07:31Z

SOFCI TEST

lgirdwood · 2026-03-19T13:07:54Z

I see several CI checks are failing with Could NOT find Python3: Found unsuitable version "3.10.11", but required is at least "3.12" and another few fails are related to NXP HAL. Unlikely, this PR can cause such errors.

Ok, it looks like the CI did not report teh build. Trying again.

tmleman · 2026-03-24T10:39:31Z

@lgirdwood What is blocking this PR?

lgirdwood · 2026-03-24T14:15:31Z

@lgirdwood What is blocking this PR?

Not sure, there are no logs except the build fail afaict, can you ask locally ?

kv2019i · 2026-03-25T08:27:43Z

Note: the sof-ci/jenkins/pr-build is failing due to Python reqs bumped up and the jenkins builds having too old python. Internal ticket filed.

Fixes minor typo error. Signed-off-by: Serhiy Katsyuba <serhiy.katsyuba@intel.com>

Adds support for Intel USB Audio Offload Link (UAOL) DAI. Signed-off-by: Tomasz Lissowski <tomasz.lissowski@intel.com> Signed-off-by: Serhiy Katsyuba <serhiy.katsyuba@intel.com>

Enables UAOL (USB Audio Offload Link) feature on ACE Intel ADSP platforms. Signed-off-by: Serhiy Katsyuba <serhiy.katsyuba@intel.com>

serhiy-katsyuba-intel · 2026-03-27T12:03:42Z

Removed Zephyr update as it has been already updated by another PR.

kv2019i · 2026-04-01T11:32:47Z

@serhiy-katsyuba-intel

I can ack @ujfalusi 's findings. This breaks DSP boot with Linux SOF kernel as UAOL is not enable. Backtrace points to:

--- Backtrace Decode ---
Frame 0: SP = 0xa012ad50
PC : 0xa008b4eb -> <uaol_intel_adsp_set_power>
sys_read32():
/home/kvehmane/work/zephyr/include/zephyr/arch/common/sys_io.h:45
a008b4eb: 0020c0 memw
Frame 1: SP = 0xa012ad80
PC : 0xa008b4d0 -> <uaol_intel_adsp_pm_action+0x23>
/home/kvehmane/work/zephyr/drivers/uaol/uaol_intel_adsp.c:869
ret = uaol_intel_adsp_set_power(dev, false);
a008b4d0: 0008e0 callx8 a8
Frame 2: SP = 0xa012ada0
PC : 0xa0040ff5 -> <pm_device_runtime_get+0x17e>
/home/kvehmane/work/zephyr/subsys/pm/device_runtime.c:288
ret = pm->base.action_cb(pm->dev, PM_DEVICE_ACTION_RESUME);
a0040ff5: 0002e0 callx8 a2
Frame 3: SP = 0xa012add0
PC : 0xa004828c -> <unknown, DT: virtualmemory@a0020000, Section: .text>
Frame 4: SP = 0xa012ae00
PC : 0xa104bc85 -> <unknown, DT: memory@a1000000, Section: .cold>
Frame 5: SP = 0xa012ae40
PC : 0xa105331b -> <basefw_get_large_config+0x814>
basefw_hw_config():
/home/kvehmane/work/sof/src/audio/base_fw.c:247
basefw_vendor_hw_config(&plat_data_offset, (char *)tuple);
a105331b: 0008e0 callx8 a8

serhiy-katsyuba-intel · 2026-04-01T11:49:33Z

Thank you, Kai, Peter.

I've pushed a PR to temporarily disable UAOL until a proper fix is found: #10670

serhiy-katsyuba-intel requested review from RanderWang, abonislawski, dbaluta, kv2019i, lbetlej, lgirdwood, marcinszkudlinski, mmaka1, pblaszko and plbossart as code owners February 20, 2026 16:01

serhiy-katsyuba-intel force-pushed the uaol branch from c736e45 to a2901a1Compare February 20, 2026 19:21

lgirdwood reviewed Feb 23, 2026
View reviewed changes

serhiy-katsyuba-intel force-pushed the uaol branch from a2901a1 to 31cfd45Compare March 5, 2026 16:24

CopilotAI review requested due to automatic review settings March 5, 2026 16:24

serhiy-katsyuba-intel requested a review from tmleman as a code owner March 5, 2026 16:24

CopilotAI reviewed Mar 5, 2026
View reviewed changes

serhiy-katsyuba-intel marked this pull request as draft March 6, 2026 10:32

serhiy-katsyuba-intel force-pushed the uaol branch from 31cfd45 to 1dad327Compare March 13, 2026 11:34

serhiy-katsyuba-intel marked this pull request as ready for review March 13, 2026 11:40

serhiy-katsyuba-intel force-pushed the uaol branch from 1dad327 to c27dd1cCompare March 13, 2026 12:12

kv2019i changed the title ~~dai: uaol: add support for Intel UAOL~~dai: uaol: add support for Intel UAOL (includes west.yml Zephyr update)Mar 13, 2026

kv2019i requested changes Mar 13, 2026
View reviewed changes

abonislawski mentioned this pull request Mar 16, 2026
boards: ace30: Enable CONFIG_UAOL for PTL #10616
Closed

serhiy-katsyuba-intel force-pushed the uaol branch from c27dd1c to 77afefeCompare March 16, 2026 12:15

kv2019i approved these changes Mar 16, 2026
View reviewed changes

tmleman approved these changes Mar 17, 2026
View reviewed changes

abonislawski approved these changes Mar 17, 2026
View reviewed changes

majunkier reviewed Mar 17, 2026
View reviewed changes

Comment threadwest.yml Outdated

kv2019i mentioned this pull request Mar 25, 2026
west.yml: update zephyr to 70969f88f53 #10652
Closed

serhiy-katsyuba-inteland others added 3 commits March 27, 2026 12:47

copier_dai: fix typo
21b9773
Fixes minor typo error. Signed-off-by: Serhiy Katsyuba <serhiy.katsyuba@intel.com>

dai: uaol: add support for Intel UAOL
68c4ded
Adds support for Intel USB Audio Offload Link (UAOL) DAI. Signed-off-by: Tomasz Lissowski <tomasz.lissowski@intel.com> Signed-off-by: Serhiy Katsyuba <serhiy.katsyuba@intel.com>

boards: intel: enable UAOL on ACE platforms
6c3cb12
Enables UAOL (USB Audio Offload Link) feature on ACE Intel ADSP platforms. Signed-off-by: Serhiy Katsyuba <serhiy.katsyuba@intel.com>

serhiy-katsyuba-intel force-pushed the uaol branch from 77afefe to 6c3cb12Compare March 27, 2026 11:59

lgirdwood approved these changes Mar 27, 2026
View reviewed changes

serhiy-katsyuba-intel changed the title ~~dai: uaol: add support for Intel UAOL (includes west.yml Zephyr update)~~dai: uaol: add support for Intel UAOLMar 27, 2026

lgirdwood merged commit b9f0800 into thesofproject:mainMar 27, 2026
45 of 48 checks passed

kv2019i mentioned this pull request Apr 1, 2026
Add CONFIG_SOF_OS_LINUX_COMPAT_PRIORITY and use it to fix UAOL regression #10672
Merged

	size_tcaps_size=offsetof(structipc4_uaol_capabilities, link_caps[dev_count]);
	size_tcaps_size=sizeof(caps) +dev_countsizeof(caps->link_caps[0]);

Uh oh!

Conversation

serhiy-katsyuba-intel commented Feb 20, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

serhiy-katsyuba-intel commented Feb 23, 2026

Uh oh!

lgirdwood left a comment

Choose a reason for hiding this comment

Uh oh!

CopilotAI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

CopilotAIMar 5, 2026

Choose a reason for hiding this comment

Uh oh!

CopilotAIMar 5, 2026

Choose a reason for hiding this comment

Uh oh!

lgirdwood commented Mar 5, 2026

Uh oh!

serhiy-katsyuba-intel commented Mar 6, 2026

Uh oh!

serhiy-katsyuba-intel commented Mar 13, 2026

Uh oh!

kv2019i left a comment

Choose a reason for hiding this comment

Uh oh!

kv2019iMar 13, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

kv2019i left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

lgirdwood commented Mar 19, 2026

Uh oh!

serhiy-katsyuba-intel commented Mar 19, 2026

Uh oh!

serhiy-katsyuba-intel commented Mar 19, 2026

Uh oh!

lgirdwood commented Mar 19, 2026

Uh oh!

lgirdwood commented Mar 19, 2026

Uh oh!

tmleman commented Mar 24, 2026

Uh oh!

lgirdwood commented Mar 24, 2026

Uh oh!

kv2019i commented Mar 25, 2026

Uh oh!

serhiy-katsyuba-intel commented Mar 27, 2026

Uh oh!

Uh oh!

kv2019i commented Apr 1, 2026

Uh oh!

serhiy-katsyuba-intel commented Apr 1, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

serhiy-katsyuba-intel commented Feb 20, 2026•
edited
Loading