Skip to content

zephyr: alloc: add 32K virtual heap bucket#10684

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lgirdwood merged 1 commit into from
Apr 16, 2026
Merged

zephyr: alloc: add 32K virtual heap bucket #10684

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion zephyr/Kconfig
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -93,7 +93,7 @@ config SOF_ZEPHYR_VIRTUAL_HEAP_SIZE
config SOF_ZEPHYR_VIRTUAL_HEAP_REGION_SIZE
hex "Size in bytes of virtual memory region for virtual heap shared for all cores"
depends on MM_DRV_INTEL_ADSP_MTL_TLB
default 0x100000
default 0x140000

@lyakhlyakhApr 7, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this adds 256k to VMH. In fact we are going to try and move some of VMH allocations to vregions, for which we might also end up shrinking VMH. If this is for optimisation to avoid using larger blocks, can we keep the total size the same and rebalance buffers? Also I don't understand how saving some of 64k buffers of which there are currently 3, requires adding 8 32k buffers?

@abonislawskiabonislawskiApr 7, 2026

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't want to rebalance globally here (requires testing all scenarios), we can shrink later if some allocations are moved. And even better, get rid of these blocks in the future. In the current configuration there are not enough 64k blocks which are used inefficiently, and in fact this is already a limited increase from PR 10499 which was too big. I could limit it more to 4x 32 probably.

@lgirdwoodlgirdwoodApr 13, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@abonislawski It seems like we need this for ptl-00/wcl-00 branches whilst we get vregion ready for next main ? Could we do some conditional logic in the kconfig that picks this bigger value if vregion = n ?

@abonislawskiabonislawskiApr 14, 2026

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

vregion count is 3 for all platforms, so it won't make any difference. The vregion allocator is already enabled but not used. I think the logical way is to just shrink VMH when something is actually moved to vregions. Right now I can't see a reason to limit the main branch pass rate.

@lyakhlyakhApr 15, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@abonislawski we want to start using vregions ASAP #10702

@lgirdwoodlgirdwoodApr 16, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@abonislawski ok, I'll merge this now and we can use the overlays to transition. i.e. we can shrink VMH usage as we pack pipelines/modules into vregions.

help
This config defines size of virtual heap region shared between all cores

Expand Down
1 change: 1 addition & 0 deletions zephyr/lib/alloc.c
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -344,6 +344,7 @@ static const struct vmh_heap_config static_hp_buffers = {
{ 2048, 8},
{ 4096, 11},
{ 8192, 10},
{ 32768, 8},
{ 65536, 3},
{ 131072, 1},
{ 524288, 1} /* buffer for kpb */
Expand Down
Loading