Uh oh!
There was an error while loading. Please reload this page.
[Userspace LL] schedule: dp: call directly instead of a notifier - #11063
Merged
Conversation
lyakh
requested review from
LaurentiuM1234, dbaluta, kv2019i, lbetlej, lgirdwood, marcinszkudlinski, mmaka1, pblaszko and plbossart
as code ownersAugust 5, 2026 12:58
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes the notifier-based indirection for the Zephyr LL “post-run” DP tick and replaces it with a direct scheduler_dp_ll_tick() call from the LL scheduler, aiming to improve clarity since the notifier was deterministically invoked immediately anyway.
Changes:
- Replaced
NOTIFIER_ID_LL_POST_RUNemission inzephyr_ll.cwith a directscheduler_dp_ll_tick()call. - Removed notifier registration/usage from the DP scheduler and updated
scheduler_dp_ll_tick()to a simplevoidAPI. - Simplified
scheduler_dp_recalculate()by dropping theis_ll_post_runparameter and updating its implementations.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| src/schedule/zephyr_ll.c | Calls DP tick directly after LL run instead of emitting a notifier event. |
| src/schedule/zephyr_dp_schedule.h | Updates the scheduler_dp_recalculate() prototype to remove the boolean parameter. |
| src/schedule/zephyr_dp_schedule.c | Removes notifier registration; updates scheduler_dp_ll_tick() signature and init flow. |
| src/schedule/zephyr_dp_schedule_thread.c | Updates scheduler_dp_recalculate() signature and removes the LL-post-run conditional from countdown logic. |
| src/schedule/zephyr_dp_schedule_application.c | Mirrors the scheduler_dp_recalculate() signature/logic change for userspace application builds. |
| src/include/sof/schedule/dp_schedule.h | Exposes scheduler_dp_ll_tick() in the public DP scheduler API. |
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
lyakhforce-pushed
the
dirdp
branch
2 times, most recently
from
August 5, 2026 13:58
5f305bf to
275a6c1Comparekv2019i
reviewed
Aug 5, 2026
kv2019i
left a comment
Collaborator
There was a problem hiding this comment.
Looks good. Can you update the README.md as well?
Uh oh!
There was an error while loading. Please reload this page.
lyakh
commented
Aug 5, 2026
CollaboratorAuthor
@kv2019i done |
kv2019i
commented
Aug 5, 2026
Collaborator
scheduler_dp_ll_tick() is currently registered as a notifier callback, but it's always triggered deterministically, always with the same-core-only flag, which leads to it being called immediately. So the notifier only adds a layer of indirection and reduces clarity. Replace it with a direct function call. Signed-off-by: Guennadi Liakhovetski <guennadi.liakhovetski@linux.intel.com>
lyakh
commented
Aug 6, 2026
CollaboratorAuthor
kv2019i
approved these changes
Aug 6, 2026
Uh oh!
There was an error while loading. Please reload this page.
This was referenced Aug 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
scheduler_dp_ll_tick() is currently registered as a notifier callback, but it's always triggered deterministically, always with the same-core-only flag, which leads to it being called immediately. So the notifier only adds a layer of indirection and reduces clarity. Replace it with a direct function call.