Uh oh!
There was an error while loading. Please reload this page.
tools: include types.h to build probes tool on musl - #11074
Open
eholzbach wants to merge 1 commit into
Open
Conversation
eholzbach
requested review from
dbaluta, kv2019i, lbetlej, lgirdwood, mmaka1 and plbossart
as code ownersAugust 8, 2026 21:34
sofci
commented
Aug 8, 2026
Collaborator
Can one of the admins verify this patch?
|
kv2019i
requested changes
Aug 10, 2026
kv2019i
left a comment
Collaborator
There was a problem hiding this comment.
Thank you @eholzbach for the contribution. Can you update the git commit description to match project style and add a proper sign-off (see https://thesofproject.github.io/latest/contribute/contribute_guidelines.html ).
sys/types.h is automatically included with glibc, not musl Signed-off-by: eholzbach <ericholzbach@pm.me>
kv2019i
commented
Aug 10, 2026
Collaborator
test this please |
kv2019i
approved these changes
Aug 10, 2026
kv2019i
left a comment
Collaborator
There was a problem hiding this comment.
Thanks, let me trigger the CI flows
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
sys/types.hexplicitly to build on musl