Uh oh!
There was an error while loading. Please reload this page.
Revert "soundwire: initial work" - #1262
Conversation
This reverts commit cba12f1.
xiulipan
commented
Apr 13, 2019
@plbossart@lgirdwood@tlauda@jajanusz |
@xiulipan Please specify what do you mean by regression. All things look like they have no impact on driver that is not even aware of soundwire. We bumped minor version what means that there are changes indeed but it should be backward compatible. |
xiulipan
commented
Apr 14, 2019
@jajanusz |
jajanusz
left a comment
There was a problem hiding this comment.
IMO it works as designed on FW side. You just have to make driver to correctly follow ABI versioning ideology.
lgirdwood
left a comment
There was a problem hiding this comment.
NAK, this is a kernel bug. Kernel should not reject minor ABI differences (only reject major ABI differences)
plbossart
commented
Apr 15, 2019
It doesn't help to just close bugs and push the issues under the rug. It's not a minor change and we need a process for ABI changes. I completely disagree with just waving things through on the grounds that things are minor. |
lgirdwood
commented
Apr 15, 2019
@plbossartthesofproject/linux#822 is showing only a minor ABI difference unless we are meaning another issue ? |
plbossart
commented
Apr 15, 2019
@lgirdwood exactly my point, the PR 822 is showing a minor ABI difference but I don't think it is. The classification looks wrong since by adding a DAI type you can end-up with a configuration that does not work. It's different from a field that gets ignored. |
Reverts #1244
ABI changes in this PR caused a blocking regression now. As no decision is made to update the kernel to align the ABI now.
Revert and have more discussion is a good option.