Skip to content

Dmic 16k capture with vol - #1293

Merged
tlauda merged 2 commits into
thesofproject:masterfrom
libinyang:dmic_16k_capture_with_vol
Apr 26, 2019
Merged

Dmic 16k capture with vol#1293
tlauda merged 2 commits into
thesofproject:masterfrom
libinyang:dmic_16k_capture_with_vol

Conversation

@libinyang

@libinyanglibinyang commented Apr 23, 2019

Copy link
Copy Markdown
Contributor

This PR add support dmic 16khz recording. this is to fix#1278

This was referenced Apr 23, 2019
Closed
Closed
@libinyang

libinyang commented Apr 23, 2019•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

This PR is an enhancement of #1271 to support volume control

@jajanusz

jajanusz commented Apr 23, 2019•
edited
Loading

Copy link
Copy Markdown
Contributor

@libinyang Sorry I got a bit lost.
Is this the only fix needed for #1278 ?
If that's enchancement of #1271 why is it closed?
If you change something that is already addressed in 1 PR please keep it there, because I don't know if it needs previous one of it is total replacement + something more.

@jajanusz

jajanusz commented Apr 23, 2019

Copy link
Copy Markdown
Contributor

@libinyang Also #1278 notes that there is no vol for 16&32 and this PR fixes 16b, so it's not full fix for #1278 right?

@libinyang

libinyang commented Apr 23, 2019

Copy link
Copy Markdown
ContributorAuthor

@jajanusz There are 2 DMICs. One is 48KHz and 32bit. Another is 16KHz and 16bit (maybe we still need support 32bit @RanderWang is working on it) and the patch for 48KHz and 32bit has already been merged into sof.

@libinyang Also #1278 notes that there is no vol for 16&32 and this PR fixes 16b, so it's not full fix for #1278 right?

@libinyang

libinyang commented Apr 23, 2019

Copy link
Copy Markdown
ContributorAuthor

@jajanusz I should not close that PR. Sorry for the inconvenience.

@libinyang Sorry I got a bit lost.
Is this the only fix needed for #1278 ?
If that's enchancement of #1271 why is it closed?
If you change something that is already addressed in 1 PR please keep it there, because I don't know if it needs previous one of it is total replacement + something more.

jajanusz
jajanusz suggested changes Apr 24, 2019
View reviewed changes

@jajanuszjajanusz left a comment •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@libinyang I think I can merge it, looks good for 16k, just one minor problem - I think you should change name of the topology file to use dashes instead of underscores, pipe-volume-capture_16k, should be pipe-volume-capture-16k or even pipe-volume-capture-16khz-16b

@libinyang
topology: sof: add pipe-volume-capture-16khz.m4
a07fa23
DMIC16k only supports 16000Hz sample rate. pipe-volume-capture.m4
only supports 48000Hz. Add pipe-volume-capture-16khz.m4 to support 16KHz
record.
Signed-off-by: Libin Yang <libin.yang@intel.com>
@libinyang
topology: DMIC: DMIC16k use pipe-volume-capture-16khz.m4
9a99a8c
DMIC16k only supports 16KHz sample rate. It should use
pipe-volume-capture-16khz.m4 to create the pipe which supports
the 16KHz recording.
Signed-off-by: Libin Yang <libin.yang@intel.com>
@libinyang
libinyangforce-pushed the dmic_16k_capture_with_vol branch from ddaa7d1 to 9a99a8cCompareApril 25, 2019 06:12
@libinyang

libinyang commented Apr 25, 2019

Copy link
Copy Markdown
ContributorAuthor

@jajanusz updated. Thanks.

@jajanusz

jajanusz commented Apr 25, 2019

Copy link
Copy Markdown
Contributor

@xiulipan I see here on GH: sof-ci/jenkins/pr-device-test — On-device Test Failed:Test Execption but when I click Details there is SUCCESS everywhere, so I guess that's just some reporting issue

@jajanusz

jajanusz commented Apr 25, 2019

Copy link
Copy Markdown
Contributor

@xiulipan I see that message is right and Tester itself failed because there are only 1 column for last category of tests

@xiulipan

xiulipan commented Apr 25, 2019

Copy link
Copy Markdown
Contributor

@jajanusz
I think something wrong inside CI steps is there. Will check and try to fix it then re-trigger the test.

@lgirdwood

lgirdwood commented Apr 26, 2019

Copy link
Copy Markdown
Member

@zrombel could you check code scan, not sure why it would fail for topologies

@tlauda
tlauda merged commit 68a237c into thesofproject:masterApr 26, 2019
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lgirdwoodlgirdwoodlgirdwood approved these changes
@lbetlejlbetlejAwaiting requested review from lbetlej
@mmaka1mmaka1Awaiting requested review from mmaka1
@plbossartplbossartAwaiting requested review from plbossart
+1 more reviewer
@jajanuszjajanuszjajanusz approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[CML]No volume controller for DMIC16/32

5 participants

@libinyang@jajanusz@xiulipan@lgirdwood@tlauda