Uh oh!
There was an error while loading. Please reload this page.
topology: byt: fix media pipeline period for nocodec - #1816
Conversation
Removes topologies, which have been removed and accidentally added again to the repository. Signed-off-by: Tomasz Lauda <tomasz.lauda@linux.intel.com>
Fixes media pipeline period for nocodec byt and cht topologies. Now codec and nocodec topologies are aligned in regards to pipe configurations. Signed-off-by: Tomasz Lauda <tomasz.lauda@linux.intel.com>
xiulipan
commented
Sep 10, 2019
@tlauda Can you give some simple explanation about how this change fix the issue? |
tlauda
commented
Sep 10, 2019
@xiulipan It's a little bit tricky and to be honest this is rather a workaround instead of a real fix. The real rootcause of the issue is the fact, that m4 scripts are unpredictable (at least for me) and setting period of media pipe to 4 ms has also changed period of capture pipeline to 4 ms. It worked after initial playback, because format played hasn't used the whole buffer reserved, so it resized it to smaller one and freed some extra space. That way capture pipe could allocate bigger buffers. @lgirdwood@plbossart Do you have any idea, why m4 scripts work this way? It seems that changing sequence of definitions changes parameters for all the pipelines. Also why do we need to separately define the same parameters in both PCM and DAI? I feel that DAI macro overwrites everything anyway. |
xiulipan
commented
Sep 11, 2019
@tlauda Thanks for the explanation, I will have a look about this m4 issue it would be related to variable. |
xiulipan
commented
Sep 11, 2019
xiulipan
commented
Sep 14, 2019
@tlauda@lgirdwood But the removing patches is indeed needed. We have changed the logic to generate some similar tplg and those m4 is no one used files. This should be some merge caused issue, some very old code base merged with file removed branch and bring the removed files back. But in our makefile system, those m4 is no longer used. @tlauda Can you confirm do we still need the 4000=>1000 change for byt nocodec media pipeline? |
tlauda
commented
Sep 14, 2019
@xiulipan Still needed as we currently don't support different periods in connected pipelines (media pipeline isn't scheduled separately, but the copy is propagated from the dai pipe). |
lgirdwood
commented
Sep 16, 2019
@tlauda Jenkins CI issue is realted to kernel bug, but can you look at QB I assume they are false positives. |
tlauda
commented
Sep 16, 2019
@lgirdwood QB is passing. |
Fixes media pipeline period for nocodec byt and cht topologies.
Now codec and nocodec topologies are aligned in regards to pipe
configurations.
Signed-off-by: Tomasz Lauda tomasz.lauda@linux.intel.com