Enable xcc build for all platform by xiulipan · Pull Request #2024 · thesofproject/sof

xiulipan · 2019-10-30T04:11:21Z

Fix xcc build for BYT/CHT/HSW/BDW/SUE
Improve the optimization level to reduce TEXT size in FW.
Fix void pointer arithmetic in hifi2 build.
Update xcc build config for all existing platforms.

xiulipan · 2019-10-30T04:15:40Z

@jajanusz @tlauda Could you help to check the build fail for the BYT, CHT, BDW, HSW and SUE.
Error for BYT, CHT

/home/pxl/xcc/install/tools/RD-2012.5-linux/XtensaTools/bin/xt-ld: sof section `.text' will not fit in region `sof_text_start'
CMakeFiles/sof.dir/src/lib/lib.c.o: In function `memset':
/home/pxl/work/sof/sof/src/lib/lib.c:56: undefined reference to `__vec_memcpy'
CMakeFiles/sof.dir/src/lib/lib.c.o: In function `memcpy_s':
/home/pxl/work/sof/sof/src/arch/xtensa/include/arch/string.h:58: undefined reference to `__vec_memcpy'

BDW, HSW

CMakeFiles/sof.dir/src/lib/lib.c.o: In function `memset':
/home/pxl/work/sof/sof/src/lib/lib.c:56: undefined reference to `__vec_memcpy'
CMakeFiles/sof.dir/src/lib/lib.c.o: In function `memcpy_s':
/home/pxl/work/sof/sof/src/arch/xtensa/include/arch/string.h:58: undefined reference to `__vec_memcpy'
/home/pxl/work/sof/sof/build_bdw_xcc/haswell.x:140: undefined symbol `XCHAL_VECBASE_RESET_PADDR' referenced in expression

SUE

/home/pxl/xcc/install/tools/RG-2017.8-linux/XtensaTools/bin/xt-ld: bootloader section `.text' will not fit in region `sof_text'

jajanusz · 2019-10-30T10:58:05Z

@jajanusz @tlauda Could you help to check the build fail for the BYT, CHT, BDW, HSW and SUE.
Error for BYT, CHT

/home/pxl/xcc/install/tools/RD-2012.5-linux/XtensaTools/bin/xt-ld: sof section `.text' will not fit in region `sof_text_start'
CMakeFiles/sof.dir/src/lib/lib.c.o: In function `memset':
/home/pxl/work/sof/sof/src/lib/lib.c:56: undefined reference to `__vec_memcpy'
CMakeFiles/sof.dir/src/lib/lib.c.o: In function `memcpy_s':
/home/pxl/work/sof/sof/src/arch/xtensa/include/arch/string.h:58: undefined reference to `__vec_memcpy'

BDW, HSW

CMakeFiles/sof.dir/src/lib/lib.c.o: In function `memset':
/home/pxl/work/sof/sof/src/lib/lib.c:56: undefined reference to `__vec_memcpy'
CMakeFiles/sof.dir/src/lib/lib.c.o: In function `memcpy_s':
/home/pxl/work/sof/sof/src/arch/xtensa/include/arch/string.h:58: undefined reference to `__vec_memcpy'
/home/pxl/work/sof/sof/build_bdw_xcc/haswell.x:140: undefined symbol `XCHAL_VECBASE_RESET_PADDR' referenced in expression

SUE

/home/pxl/xcc/install/tools/RG-2017.8-linux/XtensaTools/bin/xt-ld: bootloader section `.text' will not fit in region `sof_text'

Error says pretty much what problem is, .text section is too small to fit generated binary code. You need to tune memory.h in platform/{baytrail,haswell}.

tlauda · 2019-10-30T12:29:21Z

@xiulipan And also __vec_memcpy is probably not supported on HIFI2, so you need to add additional check in string.h in xtensa arch.

xiulipan · 2019-10-31T02:48:28Z

@jajanusz @tlauda Thanks for hint.
Can we merge this PR first so that we can have unify test env for the fix?

tlauda · 2019-10-31T07:59:06Z

@xiulipan Don't you want to add fixes into this PR first?

xiulipan · 2019-10-31T08:47:02Z

@tlauda @jajanusz And some fix and pass the test locally.
Please check.

xiulipan · 2019-11-05T03:53:06Z

@tlauda @jajanusz @macchian @lbetlej
Update the PR with optimization level change and hifi2 fix for void pointer arithmetic

plbossart · 2019-11-05T13:26:12Z

@xiulipan the IRAM sizes look wrong to me. we've always used 14000

e.g.

#defineSST_BYT_IRAM_PHY_START	0xff2c0000
#defineSST_BYT_IRAM_PHY_END	0xff2d4000
#defineSST_BYT_DRAM_PHY_START	0xff300000
#defineSST_BYT_DRAM_PHY_END	0xff320000

xiulipan · 2019-11-06T03:44:42Z

@xiulipan the IRAM sizes look wrong to me. we've always used 14000

e.g.

#defineSST_BYT_IRAM_PHY_START	0xff2c0000
#defineSST_BYT_IRAM_PHY_END	0xff2d4000
#defineSST_BYT_DRAM_PHY_START	0xff300000
#defineSST_BYT_DRAM_PHY_END	0xff320000

@plbossart @tlauda already correct me here, so we try to use -Os flag to avoid the issue.

@lgirdwood The -Os is just a test for my build test. I think I got @jajanusz help to have different optimization level with #2054
Will try to tune the default value for different build and compiler.

libinyang · 2019-11-12T08:56:44Z

@xiulipan I saw your patches changes some default value in common file. Will it impact on gcc build?

jajanusz · 2019-11-12T10:01:31Z

@xiulipan I saw your patches changes some default value in common file. Will it impact on gcc build?

These XTENSA_* variables are not used by GCC, only XCC toolchain is controlled by env variables

lgirdwood · 2019-11-12T16:28:37Z

@xiulipan any ETA for landing this ?

xiulipan · 2019-11-13T03:12:41Z

@lrgirdwo Hope I can do that in this week. Still need to figure out how to switch the optimization level by default.

jajanusz · 2019-11-13T08:44:38Z

@lrgirdwo Hope I can do that in this week. Still need to figure out how to switch the optimization level by default.

Just add CONFIG_OPTIMIZE_FOR_SIZE=y in baytrail_defconfig ;)

xcc HIFI2 do not vec_memcpy, we can only use vec_memcpy on HIFI3 supported platforms. Signed-off-by: Pan Xiuli <xiuli.pan@linux.intel.com>

Use SOF_MEM_VECBASE_TEXT_BASE to repalce unset variable. Signed-off-by: Pan Xiuli <xiuli.pan@linux.intel.com>

xcc build will have bigger TEXT. Need to keep the total block size unchange as the block need to be 4k align. Signed-off-by: Pan Xiuli <xiuli.pan@linux.intel.com>

bay cht and sue xcc build has bigger size, need to use -Os to reduce size. Signed-off-by: Pan Xiuli <xiuli.pan@linux.intel.com>

Update xcc build config for all existing platforms. xcc build with byt, cht and sue need special defconfig. Signed-off-by: Pan Xiuli <xiuli.pan@linux.intel.com>

xiulipan · 2019-11-14T11:07:04Z

@lrgirdwo @jajanusz updated to add CONFIG_OPTIMIZE_FOR_SIZE=y in baytrail_xcc_defconfig

All xcc build pass on byt cht bdw hsw apl skl kbl cnl icl jsl with local test.

lgirdwood

Can we roll this now int CI so that it builds using XCC and has download links for binaries (using community key) and ldc files.

tlauda · 2019-11-26T08:25:31Z

@xiulipan @lgirdwood Is this ready to be merged?

lgirdwood · 2019-11-26T11:19:22Z

@tlauda yep, if you approve it. We only have 1 approver atm. me.

Changes applied.

xiulipan requested a review from jajanusz as a code owner October 30, 2019 04:11

xiulipan mentioned this pull request Oct 31, 2019
pcm_converter: add implementations #2029
Merged

xiulipan force-pushed the pr/xccbuild branch from ae4eece to 7f4313cCompare October 31, 2019 08:46

xiulipan requested review from RanderWang, lbetlej, lgirdwood, mmaka1 and plbossart as code owners October 31, 2019 08:46

xiulipan changed the title ~~scripts: update xcc build for all platform~~Enable xcc build for all platformOct 31, 2019

xiulipan force-pushed the pr/xccbuild branch from 7f4313c to e328dd1Compare October 31, 2019 09:45

tlauda reviewed Oct 31, 2019
View reviewed changes

Comment threadsrc/platform/baytrail/include/platform/lib/memory.h Outdated

xiulipan force-pushed the pr/xccbuild branch from e328dd1 to 9f7211eCompare November 5, 2019 03:50

xiulipan requested a review from singalsu as a code owner November 5, 2019 03:50

xiulipan force-pushed the pr/xccbuild branch from 9f7211e to 13ff307Compare November 5, 2019 05:16

xiulipan requested a review from libinyang as a code owner November 5, 2019 05:16

jajanusz previously requested changes Nov 5, 2019
View reviewed changes

Comment threadsrc/arch/xtensa/CMakeLists.txt Outdated

jajanusz mentioned this pull request Nov 5, 2019
cmake: optimization levels #2054
Merged

lgirdwood requested changes Nov 5, 2019
View reviewed changes

Comment threadsrc/lib/alloc.c Outdated
Comment threadsrc/arch/xtensa/CMakeLists.txt Outdated

xiulipan mentioned this pull request Nov 6, 2019
simple build fix for warning #2059
Merged

xiulipan force-pushed the pr/xccbuild branch from 13ff307 to ae9679cCompare November 6, 2019 09:26

xiulipan changed the title ~~Enable xcc build for all platform~~[WIP]Enable xcc build for all platformNov 6, 2019

xiulipan added 5 commits November 14, 2019 17:52

arch: string: enable vec_memcpy only with HIFI3
8783b53
xcc HIFI2 do not vec_memcpy, we can only use vec_memcpy on HIFI3 supported platforms. Signed-off-by: Pan Xiuli <xiuli.pan@linux.intel.com>

haswell: fix _memmap_vecbase_reset address
ddc8080
Use SOF_MEM_VECBASE_TEXT_BASE to repalce unset variable. Signed-off-by: Pan Xiuli <xiuli.pan@linux.intel.com>

memory: modify bootloader for xcc build
c244a2e
xcc build will have bigger TEXT. Need to keep the total block size unchange as the block need to be 4k align. Signed-off-by: Pan Xiuli <xiuli.pan@linux.intel.com>

build: add xcc defconfig for byt cht and sue
66b28ef
bay cht and sue xcc build has bigger size, need to use -Os to reduce size. Signed-off-by: Pan Xiuli <xiuli.pan@linux.intel.com>

scripts: update xcc build for all platform
a84276a
Update xcc build config for all existing platforms. xcc build with byt, cht and sue need special defconfig. Signed-off-by: Pan Xiuli <xiuli.pan@linux.intel.com>

xiulipan force-pushed the pr/xccbuild branch from ae9679c to a84276aCompare November 14, 2019 11:03

xiulipan changed the title ~~[WIP]Enable xcc build for all platform~~Enable xcc build for all platformNov 14, 2019

lgirdwood approved these changes Nov 15, 2019
View reviewed changes

tlauda approved these changes Nov 26, 2019
View reviewed changes

tlauda merged commit 7d52bb6 into thesofproject:masterNov 26, 2019

xiulipan mentioned this pull request Dec 9, 2019
build: disable asrc xcc defconfig for byt cht #2183
Merged

Uh oh!

Conversation

xiulipan commented Oct 30, 2019• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

xiulipan commented Oct 30, 2019

Uh oh!

jajanusz commented Oct 30, 2019

Uh oh!

tlauda commented Oct 30, 2019

Uh oh!

xiulipan commented Oct 31, 2019

Uh oh!

tlauda commented Oct 31, 2019

Uh oh!

xiulipan commented Oct 31, 2019

Uh oh!

Uh oh!

xiulipan commented Nov 5, 2019

Uh oh!

Uh oh!

plbossart commented Nov 5, 2019

Uh oh!

Uh oh!

Uh oh!

xiulipan commented Nov 6, 2019

Uh oh!

libinyang commented Nov 12, 2019

Uh oh!

jajanusz commented Nov 12, 2019• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

lgirdwood commented Nov 12, 2019

Uh oh!

xiulipan commented Nov 13, 2019

Uh oh!

jajanusz commented Nov 13, 2019

Uh oh!

xiulipan commented Nov 14, 2019

Uh oh!

lgirdwood left a comment

Choose a reason for hiding this comment

Uh oh!

tlauda commented Nov 26, 2019

Uh oh!

lgirdwood commented Nov 26, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

xiulipan commented Oct 30, 2019•
edited
Loading

jajanusz commented Nov 12, 2019•
edited
Loading