Skip to content

ipc: apl: add check to avoid send IPC to HOST at same time#232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
xiulipan wants to merge 1 commit into from
Closed

ipc: apl: add check to avoid send IPC to HOST at same time #232

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions src/ipc/apl-ipc.c
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -54,6 +54,8 @@

extern struct ipc *_ipc;

static int host_ready = 1;

@lgirdwoodlgirdwoodAug 17, 2018

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, is this being use to track whether HW is ready to send a new notification IPC to the host ? If so, we should be using HW register bits to track this and not a flag

@lgirdwoodlgirdwoodAug 17, 2018

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also put more comment in your logic too.

@xiulipanxiulipanAug 20, 2018

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lgirdwood
Will sync with Rander to refine this patch set.
@RanderWang
I think I can just close this PR and you continue by add the CNL version.

@RanderWangRanderWangAug 20, 2018

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no, this is for APL, I will add a PR for CNL

@RanderWangRanderWangAug 20, 2018

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lgirdwood yes, a register should be checked for this case. I made a mistake and choose a wrong register.

@RanderWangRanderWangAug 20, 2018

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@xiulipan , can you help to close it? I create another PR. Thank you!


/* test code to check working IRQ */
static void irq_handler(void *arg)
{
Expand DownExpand Up@@ -95,6 +97,8 @@ static void irq_handler(void *arg)

/* unmask Done interrupt */
ipc_write(IPC_DIPCCTL, ipc_read(IPC_DIPCCTL) | IPC_DIPCCTL_IPCIDIE);

host_ready = 1;
}

}
Expand DownExpand Up@@ -157,6 +161,9 @@ void ipc_platform_send_msg(struct ipc *ipc)
goto out;
}

if (!host_ready)
goto out;

/* now send the message */
msg = list_first_item(&ipc->msg_list, struct ipc_msg, list);
mailbox_dspbox_write(0, msg->tx_data, msg->tx_size);
Expand All@@ -168,6 +175,7 @@ void ipc_platform_send_msg(struct ipc *ipc)
ipc_write(IPC_DIPCIE, 0);
ipc_write(IPC_DIPCI, 0x80000000 | msg->header);

host_ready = 0;
list_item_append(&msg->list, &ipc->empty_list);

out:
Expand Down