Skip to content

probes: Add extended boot data regarding probes support. - #2338

Merged
jajanusz merged 2 commits into
thesofproject:masterfrom
akloniex:probes-interface
Feb 11, 2020
Merged

probes: Add extended boot data regarding probes support.#2338
jajanusz merged 2 commits into
thesofproject:masterfrom
akloniex:probes-interface

Conversation

@akloniex

@akloniexakloniex commented Jan 30, 2020

Copy link
Copy Markdown
Member

Signed-off-by: ArturX Kloniecki arturx.kloniecki@linux.intel.com

@akloniexakloniex added the ABI ABI change involved label Jan 30, 2020
jajanusz
jajanusz suggested changes Jan 30, 2020
View reviewed changes
Comment threadsrc/ipc/CMakeLists.txt Outdated
Comment threadsrc/ipc/probe_support.c Outdated
lgirdwood
lgirdwood requested changes Jan 30, 2020
View reviewed changes

@lgirdwoodlgirdwood left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you be able to take care of the section attributes for the SRAM window, CC info structurse too in a new patch.

Comment threadsrc/include/ipc/info.h Outdated
Comment threadsrc/include/ipc/info.h Outdated
Comment threadsrc/ipc/probe_support.c Outdated
lgirdwood
lgirdwood requested changes Feb 4, 2020
View reviewed changes

@lgirdwoodlgirdwood left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still needs the section updates for this data too.

@akloniex
akloniex requested a review from lyakh as a code ownerFebruary 5, 2020 00:16
@akloniex

akloniex commented Feb 5, 2020

Copy link
Copy Markdown
MemberAuthor

@lgirdwood I've created new section .fw_ready_metadata to store extended boot messages and updated linker scripts to append that to .fw_ready section. This way we keep struct sof_ipc_fw_ready body as first member of that section to maintain proper section layout, so that it shouldn't cause any issues with veriosn verification in sof-logger.

lgirdwood
lgirdwood requested changes Feb 5, 2020
View reviewed changes

@lgirdwoodlgirdwood left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this series need squashed as the second patch undoes part of the first patch.

@lgirdwood

lgirdwood commented Feb 6, 2020

Copy link
Copy Markdown
Member

@akloniex can you take a quick look at checkpatch, not sure if it's attributes warnings are valid for XCC ?

@jajanusz

jajanusz commented Feb 7, 2020

Copy link
Copy Markdown
Contributor

@akloniex can you take a quick look at checkpatch, not sure if it's attributes warnings are valid for XCC ?

They are not valid for our project. We don't even have this macro and I'm not sure if we should introduce it. We don't have also __packed f.e. as we can't use these in abi headers. So I guess it's better to just leave attribute everywhere instead of porting part of kernel macros.

jajanusz
jajanusz suggested changes Feb 7, 2020
View reviewed changes
Comment threadsrc/include/ipc/fw-ready-metadata.h Outdated
@akloniex
probes: Add extended boot data regarding probes support.
19b9c3d
Create compile-time section .fw_ready_metadata and append it to
.fw_ready with linker.
Signed-off-by: ArturX Kloniecki <arturx.kloniecki@linux.intel.com>
@akloniex
boot metadata: Move mem window and cc version info to .fw_ready section.
db12b2c
Move extended boot metadata structures to compile-time section
.fw_ready_metadata which is appended to .fw_ready section of binary.
Signed-off-by: ArturX Kloniecki <arturx.kloniecki@linux.intel.com>
@jajanusz
jajanusz merged commit cb813bb into thesofproject:masterFeb 11, 2020
@akloniex
akloniex deleted the probes-interface branch February 11, 2020 10:57
This was referenced Mar 24, 2020
Merged
Closed
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lgirdwoodlgirdwoodlgirdwood approved these changes
@plbossartplbossartAwaiting requested review from plbossart
@crojewskcrojewskAwaiting requested review from crojewsk
@lbetlejlbetlejAwaiting requested review from lbetlej
@mmaka1mmaka1Awaiting requested review from mmaka1
@abonislawskiabonislawskiAwaiting requested review from abonislawski
@bardliaobardliaoAwaiting requested review from bardliao
@dbalutadbalutaAwaiting requested review from dbaluta
@RanderWangRanderWangAwaiting requested review from RanderWang
@tlaudatlaudaAwaiting requested review from tlauda
@xiulipanxiulipanAwaiting requested review from xiulipan
@lyakhlyakhAwaiting requested review from lyakh
+1 more reviewer
@jajanuszjajanuszjajanusz approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

ABIABI change involved

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@akloniex@lgirdwood@jajanusz