Uh oh!
There was an error while loading. Please reload this page.
kpb: fix broken doxygen link to kpbm-state-diagram - #2742
Merged
Conversation
dbaluta
approved these changes
Apr 8, 2020
dbaluta
reviewed
Apr 8, 2020
Collaborator
There was a problem hiding this comment.
@marc-hb I would rather add the git commit id inside commit message because it would be one git log away from the reader.
Also, use the Fixes tag.e.g Fixes: abcdef ("Commit subject of abdef")
marc-hb
commented
Apr 8, 2020
CollaboratorAuthor
Doxygen output is not published anywhere, is it? @deb-intel? I didn't find it at https://thesofproject.github.io/latest/api/index.html . It's only used as an input to Anyway I checked the doxygen output locally and this does fix the broken link; not just the warning. |
marc-hbforce-pushed
the
kpb-doxygen-broken-link
branch
from
April 8, 2020 06:56
c9f589b to
852449dCompareAs reported by PR thesofproject#2741: sof/src/include/sof/audio/kpb.h:46: warning: explicit link request to 'kpbm' could not be resolved Fixes: 36d4c9f ("kpb: add new state") Signed-off-by: Marc Herbert <marc.herbert@intel.com>
marc-hbforce-pushed
the
kpb-doxygen-broken-link
branch
from
April 8, 2020 06:57
852449d to
aa994d0Comparelgirdwood
approved these changes
Apr 8, 2020
lgirdwood
commented
Apr 8, 2020
Member
CI known issues |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As reported by PR #2741:
Fixes: 36d4c9f ("kpb: add new state")
Signed-off-by: Marc Herbert marc.herbert@intel.com