Uh oh!
There was an error while loading. Please reload this page.
uuid: Make entries monosized - #2836
Conversation
58e5e0e to
e8e7606CompareUh oh!
There was an error while loading. Please reload this page.
mmaka1
commented
May 4, 2020
This change seems to solve an issue with some uuid prints cut in the middle by the sof-logger. Maybe var-size struct has issues with string length computations similar to the ones with compiler info. And null-terminator is included while formatting full uuid string. |
mmaka1
commented
May 4, 2020
@lgirdwood Same as for the main ABI. Backward compatibility guaranteed (for all debug clients/tools, not only the sof-logger) within major version, X.Y+1 must work with tools built for X.Y. |
ktrzcinx
commented
May 4, 2020
Changed to major dgb ABI change because of loosing backward compatibility - removing redundant |
Uh oh!
There was an error while loading. Please reload this page.
It make code dealing with entries simpler, and allow to create UUID entries dictionary with constant access time to any entry. As long as struct definition is fixed, then can passed as pointer with correct type to function call, instead of void pointer. UUID entries aren't storred in flash memory, so entry size is not important. Explicit add zero at the end of entity_name to trigger string overflow warning for shortest incorrect string length. Resolve problem with cutted UUID info in logger output. Signed-off-by: Karol Trzcinski <karolx.trzcinski@linux.intel.com>
lgirdwood
left a comment
There was a problem hiding this comment.
ok, I'm wondering why the kernel needs to know about component UUIDs ? Or is this data purely for debug tools ? Is this data in the ext manifest ?
ktrzcinx
commented
May 8, 2020
@lgirdwood please look at https://github.com/orgs/thesofproject/teams/sof-developers/discussions/36 one more usage is runtime logger.
Should be, please look at #2914 |
lgirdwood
left a comment
There was a problem hiding this comment.
My approval is based on the dictionary being in the LDC file and not the kernel.
lgirdwood
commented
May 18, 2020
CI known issues. |
It make code dealing with entries simpler, and allow to create
UUID entries dictionary with constant access time to any entry.
As long as struct definition is fixed, then can passed as pointer
with correct type to function call, instead of void pointer.
UUID entries aren't storred in flash memory, so entry size is not
important.
Explicit add zero at the end of entity_name to trigger string overflow
warning for shortest incorrect string length.
Signed-off-by: Karol Trzcinski karolx.trzcinski@linux.intel.com