Skip to content

ext_man: Port SOF_IPC_EXT_WINDOW to extended manifest - #2906

Merged
lgirdwood merged 2 commits into
thesofproject:masterfrom
ktrzcinx:ext-man-windows
Jun 12, 2020
Merged

ext_man: Port SOF_IPC_EXT_WINDOW to extended manifest#2906
lgirdwood merged 2 commits into
thesofproject:masterfrom
ktrzcinx:ext-man-windows

Conversation

@ktrzcinx

@ktrzcinxktrzcinx commented May 5, 2020•
edited
Loading

Copy link
Copy Markdown
Member

This information known at build time does not need to be
provided in a mailbox.

thesofproject/linux#2087

lgirdwood
lgirdwood requested changes May 7, 2020
View reviewed changes
Comment threadsrc/include/ipc/info.h Outdated

@lgirdwoodlgirdwoodMay 7, 2020

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you need to change this ?

@ktrzcinxktrzcinxMay 8, 2020

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Used toolchain reject packing variable-size structures inside another one, even as last field - same situation as it was before for CC_VERSION

Comment threadsrc/include/kernel/abi.h Outdated
Comment threadsrc/platform/baytrail/platform.c Outdated
@ktrzcinxktrzcinx mentioned this pull request May 8, 2020
Merged
@ktrzcinx
ktrzcinx requested a review from lgirdwoodMay 8, 2020 09:39
@ktrzcinxktrzcinx added the ABI ABI change involved label May 11, 2020
@ktrzcinxktrzcinx changed the title ext_man: Port SOF_IPC_EXT_WINDOW to extended manifest[RFC] ext_man: Port SOF_IPC_EXT_WINDOW to extended manifestMay 11, 2020
@ktrzcinxktrzcinx changed the title [RFC] ext_man: Port SOF_IPC_EXT_WINDOW to extended manifestext_man: Port SOF_IPC_EXT_WINDOW to extended manifestMay 15, 2020
@ktrzcinx
ext_man: Add variables porting macro
72272fe
Such a macro can be used to port .fw_ready structures to .fw_metadata
section with proper header.
Signed-off-by: Karol Trzcinski <karolx.trzcinski@linux.intel.com>
@ktrzcinx
ext_man: Port SOF_IPC_EXT_WINDOW to extended manifest
4afcfbf
This information known at build time does not need to be
provided in a mailbox.
There was need to remove variable array from sof_ipc_window,
what give possibility to embed this struct inside another one,
but leads to ABI minor change.
Signed-off-by: Karol Trzcinski <karolx.trzcinski@linux.intel.com>
@ktrzcinx

ktrzcinx commented Jun 1, 2020

Copy link
Copy Markdown
MemberAuthor

I resolved conflicts

@lgirdwoodlgirdwood changed the title ext_man: Port SOF_IPC_EXT_WINDOW to extended manifest[DNM] ext_man: Port SOF_IPC_EXT_WINDOW to extended manifestJun 1, 2020
@lgirdwood

lgirdwood commented Jun 1, 2020

Copy link
Copy Markdown
Member

Need to align MINOR ABI prior to merging.

@ktrzcinx

ktrzcinx commented Jun 2, 2020•
edited
Loading

Copy link
Copy Markdown
MemberAuthor

@lgirdwood I can't see any issue with ABI number, as I see I updated from 3.16.0 (master ABI) to 3.17.0, what is aligned with changes from thesofproject/linux#2087

@lgirdwood

lgirdwood commented Jun 2, 2020

Copy link
Copy Markdown
Member

@ktrzcinx sorry, I mean that @kv2019i and I have to align these between kernel and FW. We are probably good to merge, but I just need to align with @kv2019i that kernel is happy with the ABI numbers too.

@kv2019i

kv2019i commented Jun 4, 2020

Copy link
Copy Markdown
Collaborator

@ktrzcinx wrote:

@ktrzcinx sorry, I mean that @kv2019i and I have to align these between kernel and FW. We are probably good to merge, but I just need to align with @kv2019i that kernel is happy with the ABI numbers too.

Sorry a bit late. This is good to merge, patch approved on kernel side.

@lgirdwoodlgirdwood changed the title [DNM] ext_man: Port SOF_IPC_EXT_WINDOW to extended manifestext_man: Port SOF_IPC_EXT_WINDOW to extended manifestJun 11, 2020
@lgirdwoodlgirdwood changed the title ext_man: Port SOF_IPC_EXT_WINDOW to extended manifest[DNM] ext_man: Port SOF_IPC_EXT_WINDOW to extended manifestJun 11, 2020
@lgirdwoodlgirdwood added this to the ABI-3.17 milestone Jun 12, 2020
@lgirdwoodlgirdwood changed the title [DNM] ext_man: Port SOF_IPC_EXT_WINDOW to extended manifestext_man: Port SOF_IPC_EXT_WINDOW to extended manifestJun 12, 2020
@lgirdwood
lgirdwood merged commit a10b0ad into thesofproject:masterJun 12, 2020
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lgirdwoodlgirdwoodlgirdwood approved these changes
@kv2019ikv2019ikv2019i approved these changes
@dbalutadbalutaAwaiting requested review from dbaluta
@jajanuszjajanuszAwaiting requested review from jajanusz
@lbetlejlbetlejAwaiting requested review from lbetlej
@mmaka1mmaka1Awaiting requested review from mmaka1
@plbossartplbossartAwaiting requested review from plbossart
@RanderWangRanderWangAwaiting requested review from RanderWang
@tlaudatlaudaAwaiting requested review from tlauda
@xiulipanxiulipanAwaiting requested review from xiulipan

Assignees

No one assigned

Labels

ABIABI change involved

Projects

None yet

Milestone

ABI-3.17

Development

Successfully merging this pull request may close these issues.

3 participants

@ktrzcinx@lgirdwood@kv2019i