topology: tgl-max98373-rt5682: adjust channel usage for sdw DSM support by RanderWang · Pull Request #2987 · thesofproject/sof

RanderWang · 2020-05-28T06:52:02Z

For original design, there are 4 channels 24bit stream for playback
and 8 channels 24bit IV feedback for capture. This requirement exhausts
all resource on single link. Now adjust it to 2ch stream for playback
and 4ch stream for capture

Signed-off-by: Rander Wang rander.wang@intel.com

RanderWang · 2020-05-28T06:53:07Z

@ClarexZhou please include this PR for release, thanks!

plbossart · 2020-05-28T16:23:27Z

that's still too much, we can only support 4 separate PCM transfers on a single link.

@plbossart I tested it on the TGL production. And 4 separate PCM transfers : two channels playback & two channels capture ? As you know, the channel number for capture is double size of playback for IV feedback.

@plbossart yes, it is impossible for 32bit * 6. 32bit PCM stream is used in DSM feature, but DAI config is set to 24bit (another story), so my PR works.

This has nothing to do with bandwidth, word length or channel count. At the ALH level, we can only do 4 DMA transfers to/from PDI_BD PCM targets.
#defineDAI_NUM_ALH_BI_DIR_LINKS_GROUP 6 staticconstuint8_talh_handshake_map[64] = { -1, /* 0 - INVALID */-1, /* 1 - INVALID */-1, /* 2 - INVALID */-1, /* 3 - INVALID */-1, /* 4 - INVALID */-1, /* 5 - INVALID */-1, /* 6 - INVALID */22, /* 7 - BIDIRECTIONAL */23, /* 8 - BIDIRECTIONAL */24, /* 9 - BIDIRECTIONAL */25, /* 10 - BIDIRECTIONAL */26, /* 11 - BIDIRECTIONAL */27, /* 12 - BIDIRECTIONAL */
We can only use e.g. 9..12 for PCM transfers. I am not sure how you managed to transfer 6 independent streams since it's not aligned with the documentation. Can you describe which ALH stream numbers you used?

@plbossart Iet's make it clear. There are only two PCMs in DSM feature: one is for playback (2ch) and another one is for capture (4ch).

I was talking about ALH/DMA transfers of PCM data, your reply does not answer to my question.

@plbossart I don't need to transfer 6 independent streams, right ? There are only two streams, so 32, /* 23 - BIDIRECTIONAL / is used for playback and 33, / 24 - BIDIRECTIONAL */ is used for capture.

I dumped the stream id in driver, 32 /* 23 - BIDIRECTIONAL / is used for playback and 33 /* 24 - BIDIRECTIONAL / is used for capture ( link1).

Got it now from the comments, best to say "FEEDBACK" instead of "FB" in the naming.

RanderWang · 2020-05-29T06:18:31Z

update my commit message, thanks!

keyonjie · 2020-06-01T02:27:58Z

For original design, there are 4 channels 24bit stream for playback
and 8 channels 24bit IV feedback for capture. This requirement exhausts
all resource on single link. Now adjust it to 2ch stream for playback
and 4ch stream for capture
Signed-off-by: Rander Wang rander.wang@intel.com

@RanderWang Is it possible to split them to 2 links if the customer still need 4ch playback and 8ch capture?

RanderWang · 2020-06-01T02:47:51Z

For original design, there are 4 channels 24bit stream for playback
and 8 channels 24bit IV feedback for capture. This requirement exhausts
all resource on single link. Now adjust it to 2ch stream for playback
and 4ch stream for capture
Signed-off-by: Rander Wang rander.wang@intel.com
@RanderWang Is it possible to split them to 2 links if the customer still need 4ch playback and 8ch capture?

it is more complex. we need to add support in FW & kernel & topology. The key issue is shortage of such platform. @plbossart Do you have any conclusion about this feature ? Thanks!

aiChaoSONG · 2020-06-01T03:31:44Z

SOFCI TEST

RanderWang · 2020-06-01T06:53:57Z

SOFCI TEST

failed cases were not caused by this PR for this topology is not used by CI

lgirdwood · 2020-06-11T10:19:54Z

@plbossart is this good for you now ?

plbossart

I am not going to lay on the tracks for this but allow me to state that RX_CHANNELS and FB_CHANNELS are poorly defined. The amp provides I/V feedback, and at some point there's an echo reference generated, so I am not sure what RX and FB refer to.

lgirdwood · 2020-06-12T09:58:47Z

I am not going to lay on the tracks for this but allow me to state that RX_CHANNELS and FB_CHANNELS are poorly defined. The amp provides I/V feedback, and at some point there's an echo reference generated, so I am not sure what RX and FB refer to.

Same here, @RanderWang can you explain what RX and FB are meaning here. We can probably make this easier to read with some name changes.

RanderWang · 2020-06-15T12:02:00Z

I am not going to lay on the tracks for this but allow me to state that RX_CHANNELS and FB_CHANNELS are poorly defined. The amp provides I/V feedback, and at some point there's an echo reference generated, so I am not sure what RX and FB refer to.
Same here, @RanderWang can you explain what RX and FB are meaning here. We can probably make this easier to read with some name changes.

@lgirdwood . update comments in topology. Thanks!

plbossart

Comments are not helping @RanderWang

plbossart · 2020-06-15T13:13:26Z

and this even less clear, sorry.

@plbossart copy the comment in sof-smart-amplifier.m4

FB_CHANNELS is used in mux input/output configuration, please check pipe-amp-ref-capture.m4. I spent almost an hour to check the FW but I didn't find anything about it. Then I consulted to a smart-amp expert. The FW patch is still not merged in master ! It is only adopted in release branch. According to tgl-006-drop-stable, the FB channel is the number of capture stream (I/V) sent to user mode application.

plbossart

still not sure what 'feedback' is

ClarexZhou

Verify OK

RanderWang · 2020-06-24T03:11:17Z

update comments based on comments from @keyonjie. Thanks!

For original design, there are 4 channels 24bit stream for playback and 8 channels 24bit IV feedback for capture stream. This requirement exhausts all resource on single link. Now adjust it to a 2 channels stream for playback and a 4 channels stream for capture Signed-off-by: Rander Wang <rander.wang@intel.com>

lgirdwood · 2020-06-24T08:55:33Z

@zrombel looks like CI stalled ?

zrombel · 2020-06-24T15:54:38Z

Build was re run and all test are PASS.

plbossart

we'll need to rename RX and FB in a follow-up patch, this is just confusing

RanderWang requested review from bardliao, keyonjie, kv2019i, lgirdwood, plbossart and ranj063 May 28, 2020 06:52

RanderWang requested a review from xiulipan as a code owner May 28, 2020 06:52

RanderWang requested a review from ClarexZhou May 28, 2020 06:52

plbossart requested changes May 28, 2020
View reviewed changes

RanderWang force-pushed the sdw-dsm-tgl branch from 7bba7f0 to 583110cCompare May 29, 2020 06:13

RanderWang force-pushed the sdw-dsm-tgl branch from 583110c to 804e757Compare June 1, 2020 02:11

YvonneYang2 mentioned this pull request Jun 4, 2020
[BUG][TGL] pop noise issue on max98357 speaker when doing pause/resume test thesofproject/linux#2111
Closed

plbossart approved these changes Jun 11, 2020
View reviewed changes

RanderWang force-pushed the sdw-dsm-tgl branch from 804e757 to d500955Compare June 15, 2020 12:00

plbossart requested changes Jun 15, 2020
View reviewed changes

RanderWang force-pushed the sdw-dsm-tgl branch 2 times, most recently from 940f201 to eaf4287Compare June 16, 2020 07:17

plbossart requested changes Jun 16, 2020
View reviewed changes

Comment threadtools/topology/sof-tgl-sdw-max98373-rt5682.m4 Outdated

ClarexZhou mentioned this pull request Jun 19, 2020
[TGL][007-drop-stable]"error: ipc error for 0x50040000 size 124" occurred when system boot up. #3068
Closed

keqiaozhang mentioned this pull request Jun 22, 2020
[BUG] firmware load failure on JSL Chrome with LPS changes #3076
Closed

ClarexZhou approved these changes Jun 24, 2020
View reviewed changes

RanderWang force-pushed the sdw-dsm-tgl branch from eaf4287 to a57450dCompare June 24, 2020 03:09

lgirdwood approved these changes Jun 24, 2020
View reviewed changes

plbossart approved these changes Jun 24, 2020
View reviewed changes

lgirdwood merged commit 642ac57 into thesofproject:masterJun 24, 2020

Liviali155 mentioned this pull request Jun 29, 2020
[BUG][JSL][DP-MST]Cannot playback to 2 DP displays connected through a DP-MST hub simultaneously thesofproject/linux#2239
Closed

Uh oh!

Conversation

RanderWang commented May 28, 2020• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

RanderWang commented May 28, 2020

Uh oh!

plbossartMay 28, 2020• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

RanderWangJun 2, 2020• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

RanderWang commented May 29, 2020

Uh oh!

keyonjie commented Jun 1, 2020

Uh oh!

RanderWang commented Jun 1, 2020

Uh oh!

aiChaoSONG commented Jun 1, 2020

Uh oh!

RanderWang commented Jun 1, 2020

Uh oh!

lgirdwood commented Jun 11, 2020

Uh oh!

plbossart left a comment

Choose a reason for hiding this comment

Uh oh!

lgirdwood commented Jun 12, 2020

Uh oh!

RanderWang commented Jun 15, 2020

Uh oh!

plbossart left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

RanderWangJun 16, 2020• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

plbossart left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

ClarexZhou left a comment

Choose a reason for hiding this comment

Uh oh!

RanderWang commented Jun 24, 2020

Uh oh!

lgirdwood commented Jun 24, 2020

Uh oh!

zrombel commented Jun 24, 2020

Uh oh!

plbossart left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

RanderWang commented May 28, 2020•
edited
Loading

plbossartMay 28, 2020•
edited
Loading

RanderWangJun 2, 2020•
edited
Loading

RanderWangJun 16, 2020•
edited
Loading