Uh oh!
There was an error while loading. Please reload this page.
sof: Define possible UUID entries usage in IPC during declaration - #3010
Conversation
paulstelian97
commented
Jun 2, 2020
We'll wait until we're sure this won't cause any Out Of Memory issues in DSP SRAM. |
There was a problem hiding this comment.
I'd keep the DECLARE_SOF_UUID()/SOF_UUID() for logging-only case unchanged. And introduce DECLARE_SOF_RT_UUID()/SOF_RT_UUID() for run-time identification.
From CI: @singalsu maybe you have a suggestion what is going on ? |
Uh oh!
There was an error while loading. Please reload this page.
singalsu
commented
Jun 3, 2020
OK, I'll see what causes that. |
singalsu
commented
Jun 3, 2020
@ktrzcinx It segfaults to this line
Where is it set normally? Probably when updating this it has been forgotten to add to testbench runtime too. The trace output in testbench has been somewhat broken for a while already due to left without updates but this is fist time that it segfaults. |
Each component driver should have assigned UUID value and trace contecxt, to allow generic component creation routine usage. It's espiecially important for trace context, because it's accessed by pointer so dereferencing NULL pointer will lead to segmentation fault. Signed-off-by: Karol Trzcinski <karolx.trzcinski@linux.intel.com>
UUID entries, related with components from topology, should be loaded into SRAM to allow runtime comparison with value in IPC message during component creation. UUID of the components whose are not created by IPC message are not needed in runtime, so there should not be there to reduce memory consumtion - as it is now. It's untouched. Signed-off-by: Karol Trzcinski <karolx.trzcinski@linux.intel.com>
It allows to comparison this full UUID value with value in IPC message, what is important step to create new component from topology by their UUID value. Signed-off-by: Karol Trzcinski <karolx.trzcinski@linux.intel.com>
ktrzcinx
commented
Jun 3, 2020
@singalsu Thanks, |
singalsu
commented
Jun 3, 2020
Superb, thanks!! Yes I just ran the process_test and everything worked again. |
If it's possible, each line with comment to struct field should be aligned, to keep code style consistent. Signed-off-by: Karol Trzcinski <karolx.trzcinski@linux.intel.com>
lgirdwood
commented
Jun 4, 2020
Jenkins DUT failure. |
A few UUID entries, related with components from topology,
should be loaded into SRAM to allow runtime comparison with
value in IPC message during component creation. UUID of the
components whose are not created by IPC message are not needed
in runtime, so there should not be there to reduce memory
consumtion.
Signed-off-by: Karol Trzcinski karolx.trzcinski@linux.intel.com
It's a part of #2920
@keyonjie please check if I choose 'RT` UUID for all needed components.