Skip to content

Smart amp tplg fixes - #3053

Merged
lgirdwood merged 2 commits into
thesofproject:masterfrom
keyonjie:smart_amp_tplg
Jun 24, 2020
Merged

Smart amp tplg fixes#3053
lgirdwood merged 2 commits into
thesofproject:masterfrom
keyonjie:smart_amp_tplg

Conversation

@keyonjie

@keyonjiekeyonjie commented Jun 16, 2020

Copy link
Copy Markdown
Contributor

make sure the SMART_SSP_QUIRK is configured, and use the unify mclk among SSPs.

This will fixthesofproject/linux#2190

@keyonjiekeyonjie mentioned this pull request Jun 16, 2020
Closed
lgirdwood
lgirdwood requested changes Jun 16, 2020
View reviewed changes
Comment threadtools/topology/sof-smart-amplifier.m4 Outdated
plbossart
plbossart requested changes Jun 16, 2020
View reviewed changes

@plbossartplbossart left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should not output a 38.4 MCLK, that's way too much.

Comment threadtools/topology/sof-tgl-max98373-rt5682.m4 Outdated
Comment threadtools/topology/sof-smart-amplifier.m4 Outdated
@keyonjie
topology: sof-smart-amplifier: configure ssp quirk to 0 by default
4527652
We should make sure SMART_SSP_QUIRK is set, if it is not defined from
the upper layer, let's set it to explicit 0.
Signed-off-by: Keyon Jie <yang.jie@linux.intel.com>
@keyonjie
topology: sof-smart-amplifier: change the mclk to fix the noise issue
6338fe9
Since we are sharing the same mclk_id among SSP interfaces, we should
use the fixed frequency for the mclk. Here add a macro for it to make
sure it is aligned with the SSP configure in the upper layer.
Change to use 19.2MHz as the default mclk for smart_amp SSP.
Signed-off-by: Keyon Jie <yang.jie@linux.intel.com>
@keyonjie
keyonjie requested a review from plbossartJune 17, 2020 03:07
@keyonjie

keyonjie commented Jun 17, 2020

Copy link
Copy Markdown
ContributorAuthor

@lgirdwood@plbossart updated.

@bardliao

bardliao commented Jun 18, 2020

Copy link
Copy Markdown
Collaborator

Maybe we should use this opportunity to review the mclk value for all existing machines.

@jajanusz

jajanusz commented Jun 18, 2020

Copy link
Copy Markdown
Contributor

@lgirdwood@plbossart updated.

@plbossart@lgirdwood please review this PR, we need it for tgl 0.7 release, thanks

@jajanusz
jajanusz requested a review from lgirdwoodJune 18, 2020 10:13
@ClarexZhouClarexZhou mentioned this pull request Jun 19, 2020
Closed
@keqiaozhangkeqiaozhang mentioned this pull request Jun 22, 2020
Closed
@keyonjie

keyonjie commented Jun 24, 2020

Copy link
Copy Markdown
ContributorAuthor

@lgirdwood@plbossart ping for comments, this is fix so in urgent.

@lgirdwood

lgirdwood commented Jun 24, 2020

Copy link
Copy Markdown
Member

Jenkins CI know issues.

@lgirdwood

lgirdwood commented Jun 24, 2020

Copy link
Copy Markdown
Member

@zrombel looks like CI got stuck, are we good to merge or do you want to rerun ?

@zrombel

zrombel commented Jun 24, 2020

Copy link
Copy Markdown

Build was re run, and all tests PASS.

@lgirdwood
lgirdwood merged commit 20ab16c into thesofproject:masterJun 24, 2020
@Liviali155Liviali155 mentioned this pull request Jun 29, 2020
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@plbossartplbossartplbossart approved these changes
@lgirdwoodlgirdwoodlgirdwood approved these changes
@ranj063ranj063Awaiting requested review from ranj063
@xiulipanxiulipanAwaiting requested review from xiulipan
@bkokoszxbkokoszxAwaiting requested review from bkokoszx
@RDharageswariRDharageswariAwaiting requested review from RDharageswari
+2 more reviewers
@RanderWangRanderWangRanderWang approved these changes
@jajanuszjajanuszjajanusz approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[But][TGL Chrome I2S] Headset audio output is harsh after runtime PM suspended.

7 participants

@keyonjie@bardliao@jajanusz@lgirdwood@zrombel@plbossart@RanderWang