Skip to content

cmake: set git hash to 8 digit - #3323

Closed
fredoh9 wants to merge 1 commit into
thesofproject:masterfrom
fredoh9:fix/sof_hash_error
Closed

cmake: set git hash to 8 digit#3323
fredoh9 wants to merge 1 commit into
thesofproject:masterfrom
fredoh9:fix/sof_hash_error

Conversation

@fredoh9

Copy link
Copy Markdown
Contributor

GIT_LOG_HASH can be more than 8 digits. Limit hash value up to
8 digits.

Signed-off-by: Fred Oh fred.oh@linux.intel.com

fixes: #3322

@ktrzcinxktrzcinx added the P1 Blocker bugs or important features label Aug 19, 2020
@plbossart

Copy link
Copy Markdown
Member

Maybe complete nonsense, but does this take the first 8 digits or the 8 last? the latter might be difficult to use?

@ktrzcinx

Copy link
Copy Markdown
Member

@plbossart the first 8 digits

@mmaka1

Copy link
Copy Markdown

Should the commit message include a hash of the original commit being fixed?

@fredoh9

Copy link
Copy Markdown
ContributorAuthor

Should the commit message include a hash of the original commit being fixed?

Should I make this as a fixup commit then?

@fredoh9

Copy link
Copy Markdown
ContributorAuthor

fixup commit is making sense. Changed to fixup of 60b737a.
fixup! sof: Calculate source code hash

@lgirdwoodlgirdwood left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you fix the commit subject and add a commit message. It looks like these are in the GH PR but not the patch.

GIT_LOG_HASH can be more than 8 digits. Limit hash value up to
first 8 digits.
Signed-off-by: Fred Oh <fred.oh@linux.intel.com>
@fredoh9

Copy link
Copy Markdown
ContributorAuthor

Can you fix the commit subject and add a commit message. It looks like these are in the GH PR but not the patch.

Commit subject is fixup, sorry for missing commit message. I didn't pay attention to the message when using --fixup.

@fredoh9
fredoh9 requested a review from lgirdwoodAugust 20, 2020 19:13

@lgirdwoodlgirdwood left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fredoh9 you may have pushed the wrong branch, it's still showing the wrong subject. Best to rebase and check with git log prior to force pushing.

@lgirdwood

Copy link
Copy Markdown
Member

@fredoh9 I've fixed the subject and pushed here. #3331. closing this one.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

P1Blocker bugs or important features

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] APL/CNL Build failed due to bigger SOF_SRC_HASH

5 participants

@fredoh9@plbossart@ktrzcinx@mmaka1@lgirdwood