Uh oh!
There was an error while loading. Please reload this page.
cmake: set git hash to 8 digit - #3323
Conversation
plbossart
commented
Aug 19, 2020
Maybe complete nonsense, but does this take the first 8 digits or the 8 last? the latter might be difficult to use? |
ktrzcinx
commented
Aug 19, 2020
@plbossart the first 8 digits |
mmaka1
commented
Aug 19, 2020
Should the commit message include a hash of the original commit being fixed? |
fredoh9
commented
Aug 19, 2020
Should I make this as a fixup commit then? |
53aaa15 to
d19577fComparefredoh9
commented
Aug 19, 2020
fixup commit is making sense. Changed to fixup of 60b737a. |
d19577f to
11e8c9eCompare
lgirdwood
left a comment
There was a problem hiding this comment.
Can you fix the commit subject and add a commit message. It looks like these are in the GH PR but not the patch.
11e8c9e to
e4ec45aCompareGIT_LOG_HASH can be more than 8 digits. Limit hash value up to first 8 digits. Signed-off-by: Fred Oh <fred.oh@linux.intel.com>
fredoh9
commented
Aug 20, 2020
Commit subject is fixup, sorry for missing commit message. I didn't pay attention to the message when using --fixup. |
GIT_LOG_HASH can be more than 8 digits. Limit hash value up to
8 digits.
Signed-off-by: Fred Oh fred.oh@linux.intel.com
fixes: #3322