Uh oh!
There was an error while loading. Please reload this page.
smart_amp: remove hardcoded frame_fmt value - #3404
Merged
lgirdwood merged 1 commit intoSep 14, 2020
Merged
Conversation
In order to allow stream different audio formats, the hardcodec frame fmt value should be removed. Signed-off-by: Bartosz Kokoszko <bartoszx.kokoszko@linux.intel.com>
bkokoszx
requested review from
dbaluta, jajanusz, lbetlej, lgirdwood, mmaka1 and plbossart
as code ownersSeptember 14, 2020 09:42
zrombel
commented
Sep 14, 2020
This PR is fixing DSP panic in DSM python tests introduced by #2788 and should be merged as soon as possible. |
lgirdwood
approved these changes
Sep 14, 2020
lgirdwood
left a comment
Member
There was a problem hiding this comment.
@plbossart@kv2019i this looks like a kernel or DUT issue on TGL CI (given the amount of kernel errors) ?
kv2019i
commented
Sep 14, 2020
Collaborator
@lgirdwood wrote:
The TGL target run clearly fails, driver fails to probe, but I don't see any connection with this SOF pull req. |
dbaluta
approved these changes
Sep 14, 2020
kv2019i
commented
Sep 14, 2020
Collaborator
Also same failures for: |
lgirdwood
commented
Sep 14, 2020
Member
@kv2019i thanks, looks unrelated to this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In order to allow stream different audio formats,
the hardcodec frame fmt value should be removed.
Signed-off-by: Bartosz Kokoszko bartoszx.kokoszko@linux.intel.com