Uh oh!
There was an error while loading. Please reload this page.
travis: run build-tools.sh with CMAKE_BUILD_TYPE=Release - #3411
Conversation
72bcf06 to
ca3dbadComparemarc-hb
commented
Sep 15, 2020
The warnings in https://travis-ci.org/github/thesofproject/sof/jobs/727258703 are fixed by PR #3412 |
As reported by shellcheck Signed-off-by: Marc Herbert <marc.herbert@intel.com>
... thanks to the docker --env option which is smart enough not to pass anything when there is nothing to pass. Signed-off-by: Marc Herbert <marc.herbert@intel.com>
For some reason gcc prints more warnings this way and of course CI is meant to catch warnings as soon as possible. Signed-off-by: Marc Herbert <marc.herbert@intel.com>
ca3dbad to
a7a9f6fComparemarc-hb
commented
Sep 15, 2020
I don't know what the docker image uses right now, I use a plain Ubuntu 20.04 and it has gcc 9.3. This is how I found the compilation issues fixed in #3412 I generally don't follow where the docker image is at.
I understand the convenience of docker for not having to build toolchains (which is not long but a bit tedious and error-prone) for new users and making sure they all use the same ones. However for me it's more an additional layer of indirection/obfuscation when you want to test and fix build issues. Unless the docker image uses something special for native compilation too, using it to build |
marc-hb
commented
Sep 15, 2020
You can see that Travis default distribution is Xenial 16.04: https://travis-ci.org/github/thesofproject/sof/builds/727431437/ In the same logs you can see 16.04 has a very old gcc 5.4 by default. Inside the docker image CMake conveniently reports that gcc is currently 7.5 Switching to 20.04 (or anything else) in |
lgirdwood
commented
Sep 15, 2020
@xiulipan can you confirm what GCC version docker/travis is using for CI |
xiulipan
left a comment
There was a problem hiding this comment.
I think we do not need the change to the docker scripts.
Uh oh!
There was an error while loading. Please reload this page.
For some reason gcc prints more warnings this way and of course CI is
meant to catch warnings as soon as possible.