audio: codec_adapter: add Waves api by stolx · Pull Request #3977 · thesofproject/sof

stolx · 2021-03-29T20:28:16Z

add Waves MaxxEffect API definition.
API is required to build SOF with Waves codec.

Signed-off-by: Oleksandr Strelchenko oleksandr.strelchenko@waves.com

stolx · 2021-03-29T20:31:57Z

compared to #3938 removed trail whitespace checkpatch errors

lgirdwood · 2021-03-30T21:26:01Z

SOFCI TEST

dbaluta · 2021-03-31T06:49:15Z

This should be under sof/src/include/sof/audio/codec_adapter/codec/MaxxEffect.

I wonder if maybe we should do a codec_adapter/codecs/ and in the kconfig just include a kconfig in the respective dir so all include info can be pushed down to individual kconfigs/cmakelists

@cujomalainey
I think this is a good idea but I prefer it to be handled in a separate PR.
Another thing I thought about is to upstream pass-through code for Waves codec.
It will come in handy to add SOF with Waves codec to CI checks.
Where is a place to discuss if this is needed?

dbaluta · 2021-03-31T06:52:24Z

If the headers as provided "as it is" we shouldn't fix checkpatch errors. Just let them be. Otherwise, updating the headers to a new version will be painful.

lgirdwood · 2021-03-31T15:37:02Z

If the headers as provided "as it is" we shouldn't fix checkpatch errors. Just let them be. Otherwise, updating the headers to a new version will be painful.

Ack, this was my opinion too - we dont want to change 3rd party headers as it will have unnecessary impact on 3rd party non upstream code - we upstream them "as-is" but with permissive license.

marc-hb · 2021-03-31T23:39:24Z

Github Actions hang fixed by #3992, please git commit --amend and force push to re-trigger.

lgirdwood · 2021-04-01T12:05:48Z

@stolx same rebase with main branch latest is needed here too.

dbaluta · 2021-04-05T17:03:21Z

@stolx thanks for moving the header file location. It looks good now.
I have one question though. Do you really need to add the line above? I would have expected to just work. If it is really needed that fine by me. The change looks good and useful!

agreed, if your stuff is in include you shouldnt need this

fixed include dir to be ${CMAKE_CURRENT_LIST_DIR}/../../include/sof/audio/codec_adapter/codec/
we need it to keep MaxxEffect folder on includes path

@stolx OK, I got your point. It works for me. Another approach would have been to use
#include "codec_adapter/codec/MaxxEffect/MaxxEffect.h"

unfortunately, it will not work due to how MaxxEffect API is designed.
For example, take a look at MaxxEffect_Revision.h, it contains the following lines
#include "MaxxEffect/MaxxEffect.h" #include "MaxxEffect/MaxxStatus.h"
So API headers themself expect MaxxEffect folder to be on the include path.
And since API headers are provided "as-is", the only way is to add the MaxxEffect folder to includes

@stolx thanks for your explanation! It makes sense.

add Waves MaxxEffect API definition. API is required to build SOF with Waves codec. Signed-off-by: Oleksandr Strelchenko <oleksandr.strelchenko@waves.com>

dbaluta · 2021-04-06T08:44:45Z

@lgirdwood this is read to merge from my point of view.

lgirdwood · 2021-04-06T13:26:02Z

@zrombel good to merge , looks like CI pending ?
@stolx can you try and build docs ./scripts/gen-doc.sh as it looks like doxygen is failing to build one of your files.

dbaluta · 2021-04-06T13:29:12Z

@lgirdwood I don't think we should fix the header to pass the doxygen build just because these are 3rd party headers and we need to have them in the tree without any modification.

I think the best way is to instruct doxygen to skip these files.

lgirdwood · 2021-04-06T13:34:08Z

@lgirdwood I don't think we should fix the header to pass the doxygen build just because these are 3rd party headers and we need to have them in the tree without any modification.
I think the best way is to instruct doxygen to skip these files.

This could be a valid doxygen issue that also impacts the private repo. i.e. a typo
I dont seen any harm here since this should be all standard doxygen, but I'd like to see the errors being reported first.

dbaluta · 2021-04-06T14:33:50Z

@lgirdwood you are right. we should at least figure out the cause of the errors.

cujomalainey · 2021-04-06T22:41:47Z

@lgirdwood you are right. we should at least figure out the cause of the errors.

I think we should just add an exclusion case https://stackoverflow.com/questions/1354056/ignoring-files-in-project-folder-for-doxygen

lgirdwood · 2021-04-07T08:07:59Z

CI failure is unrelated kernel suspend and resume

lgirdwood · 2021-04-07T08:14:00Z

/home/lrg/work/sof/sof/src/include/sof/audio/codec_adapter/codec/MaxxEffect/MaxxStream.h:95: warning: unable to resolve reference to 'CoreConcepts_DataPath_StreamFormat' for \ref command
/home/lrg/work/sof/sof/src/include/sof/audio/codec_adapter/codec/MaxxEffect/MaxxStream.h:109: warning: unable to resolve reference to 'CoreConcepts_DataPath_Stream' for \ref command
/home/lrg/work/sof/sof/src/include/sof/audio/codec_adapter/codec/MaxxEffect/MaxxEffect.h:47: warning: unable to resolve reference to 'CoreConcepts_MaxxEffect' for \ref command
/home/lrg/work/sof/sof/src/include/sof/audio/codec_adapter/codec/MaxxEffect/MaxxStream.h:95: warning: unable to resolve reference to 'CoreConcepts_DataPath_StreamFormat' for \ref command
/home/lrg/work/sof/sof/src/include/sof/audio/codec_adapter/codec/MaxxEffect/MaxxStream.h:109: warning: unable to resolve reference to 'CoreConcepts_DataPath_Stream' for \ref command
/home/lrg/work/sof/sof/src/include/sof/audio/codec_adapter/codec/MaxxEffect/MaxxStream.h:60: warning: unable to resolve reference to 'CoreConcepts_DataPath_Buffer' for \ref command
/home/lrg/work/sof/sof/src/include/sof/audio/codec_adapter/codec/MaxxEffect/MaxxStream.h:83: warning: unable to resolve reference to 'CoreConcepts_DataPath_MultichannelStreams' for \ref command
/home/lrg/work/sof/sof/src/include/sof/audio/codec_adapter/codec/MaxxEffect/MaxxStream.h:109: warning: unable to resolve reference to 'CoreConcepts_DataPath_Stream' for \ref command
/home/lrg/work/sof/sof/src/include/sof/audio/codec_adapter/codec/MaxxEffect/MaxxStream.h:109: warning: unable to resolve reference to 'CoreConcepts_DataPath_Stream' for \ref command
/home/lrg/work/sof/sof/src/include/sof/audio/codec_adapter/codec/MaxxEffect/MaxxStream.h:95: warning: unable to resolve reference to 'CoreConcepts_DataPath_StreamFormat' for \ref command
/home/lrg/work/sof/sof/src/include/sof/audio/codec_adapter/codec/MaxxEffect/MaxxStream.h:95: warning: unable to resolve reference to 'CoreConcepts_DataPath_StreamFormat' for \ref command
/home/lrg/work/sof/sof/src/include/sof/audio/codec_adapter/codec/MaxxEffect/MaxxStream.h:109: warning: unable to resolve reference to 'CoreConcepts_DataPath_Stream' for \ref command
/home/lrg/work/sof/sof/src/include/sof/audio/codec_adapter/codec/MaxxEffect/MaxxStream.h:95: warning: unable to resolve reference to 'CoreConcepts_DataPath_StreamFormat' for \ref command
/home/lrg/work/sof/sof/src/include/sof/audio/codec_adapter/codec/MaxxEffect/MaxxStream.h:109: warning: unable to resolve reference to 'CoreConcepts_DataPath_Stream' for \ref command
/home/lrg/work/sof/sof/src/include/sof/audio/codec_adapter/codec/MaxxEffect/MaxxStream.h:95: warning: unable to resolve reference to 'CoreConcepts_DataPath_StreamFormat' for \ref command
/home/lrg/work/sof/sof/src/include/sof/audio/codec_adapter/codec/MaxxEffect/MaxxStream.h:109: warning: unable to resolve reference to 'CoreConcepts_DataPath_Stream' for \ref command
/home/lrg/work/sof/sof/src/include/sof/audio/codec_adapter/codec/MaxxEffect/MaxxStream.h:95: warning: unable to resolve reference to 'CoreConcepts_DataPath_StreamFormat' for \ref command
/home/lrg/work/sof/sof/src/include/sof/audio/codec_adapter/codec/MaxxEffect/MaxxEffect.h:47: warning: unable to resolve reference to 'CoreConcepts_MaxxEffect' for \ref command
/home/lrg/work/sof/sof/src/include/sof/audio/codec_adapter/codec/MaxxEffect/MaxxStream.h:83: warning: unable to resolve reference to 'CoreConcepts_DataPath_MultichannelStreams' for \ref command
/home/lrg/work/sof/sof/src/include/sof/audio/codec_adapter/codec/MaxxEffect/MaxxStream.h:60: warning: unable to resolve reference to 'CoreConcepts_DataPath_Buffer' for \ref command

marc-hb · 2021-04-09T14:17:17Z

The doxygen build is now broken for every PR.

dbaluta · 2021-04-09T14:22:58Z

@marc-hb should be fixed with updated version of 55cf12b

stolx requested review from dbaluta, lbetlej, lgirdwood, mmaka1 and plbossart as code owners March 29, 2021 20:28

cujomalainey self-requested a review March 29, 2021 22:39

lgirdwood approved these changes Mar 30, 2021
View reviewed changes

dbaluta reviewed Mar 31, 2021
View reviewed changes

Comment threadsrc/audio/codec_adapter/CMakeLists.txt Outdated

stolx force-pushed the add-waves-api branch from ba99b98 to 2c3fe9dCompare April 5, 2021 16:04

stolx requested a review from mrajwa as a code owner April 5, 2021 16:04

dbaluta reviewed Apr 5, 2021
View reviewed changes

audio: codec_adapter: add Waves api
9d4dbca
add Waves MaxxEffect API definition. API is required to build SOF with Waves codec. Signed-off-by: Oleksandr Strelchenko <oleksandr.strelchenko@waves.com>

stolx force-pushed the add-waves-api branch from 2c3fe9d to 9d4dbcaCompare April 6, 2021 08:13

dbaluta approved these changes Apr 6, 2021
View reviewed changes

lgirdwood merged commit d9a7dfd into thesofproject:mainApr 7, 2021

stolx deleted the add-waves-api branch April 26, 2021 14:50

Uh oh!

Conversation

stolx commented Mar 29, 2021

Uh oh!

stolx commented Mar 29, 2021

Uh oh!

lgirdwood commented Mar 30, 2021

Uh oh!

dbalutaMar 31, 2021

Choose a reason for hiding this comment

Uh oh!

cujomalaineyApr 2, 2021• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

stolxApr 5, 2021

Choose a reason for hiding this comment

Uh oh!

Uh oh!

dbaluta commented Mar 31, 2021

Uh oh!

lgirdwood commented Mar 31, 2021

Uh oh!

marc-hb commented Mar 31, 2021• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

lgirdwood commented Apr 1, 2021

Uh oh!

dbalutaApr 5, 2021

Choose a reason for hiding this comment

Uh oh!

cujomalaineyApr 5, 2021

Choose a reason for hiding this comment

Uh oh!

stolxApr 6, 2021

Choose a reason for hiding this comment

Uh oh!

dbalutaApr 6, 2021• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

stolxApr 6, 2021

Choose a reason for hiding this comment

Uh oh!

dbalutaApr 6, 2021

Choose a reason for hiding this comment

Uh oh!

dbaluta commented Apr 6, 2021

Uh oh!

lgirdwood commented Apr 6, 2021

Uh oh!

dbaluta commented Apr 6, 2021

Uh oh!

lgirdwood commented Apr 6, 2021

Uh oh!

dbaluta commented Apr 6, 2021• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cujomalainey commented Apr 6, 2021

Uh oh!

lgirdwood commented Apr 7, 2021

Uh oh!

lgirdwood commented Apr 7, 2021

Uh oh!

marc-hb commented Apr 9, 2021

Uh oh!

dbaluta commented Apr 9, 2021• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

cujomalaineyApr 2, 2021•
edited
Loading

marc-hb commented Mar 31, 2021•
edited
Loading

dbalutaApr 6, 2021•
edited
Loading

dbaluta commented Apr 6, 2021•
edited
Loading

dbaluta commented Apr 9, 2021•
edited
Loading