Uh oh!
There was an error while loading. Please reload this page.
numbers.h: simplify #ifndef ZEPHYR for MIN and MAX - #4130
Merged
Conversation
Undefining and re-defining MIN/MAX when already defined is convoluted. Simply define them if not __ZEPHYR__ instead. Signed-off-by: Marc Herbert <marc.herbert@intel.com>
marc-hb
marked this pull request as ready for review
May 4, 2021 05:58
marc-hb
requested review from
dbaluta, lbetlej, mmaka1 and plbossart
as code ownersMay 4, 2021 05:58
CollaboratorAuthor
WHL_HDA failed everything in https://sof-ci.01.org/sof-pr-viewer/#/build/PR4130/build6388021 but the exact same happened in this entirely different and unrelated PR so it's hopefully unrelated: https://sof-ci.01.org/sof-pr-viewer/#/build/PR4131/build6388373 @zrombel, @kkarask or @wszypelt could you check what's going on with WHL_HDA? https://sof-ci.01.org/sofpr/PR4130/build8910/devicetest was all green |
jgunn0262
approved these changes
May 4, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Undefining and re-defining MIN/MAX when already defined is
convoluted. Simply define them if not
__ZEPHYR__instead.Signed-off-by: Marc Herbert marc.herbert@intel.com