Skip to content

topology: Modify RTNR to work with KWD on TGL and ADL. - #4989

Merged
lgirdwood merged 1 commit into
thesofproject:mainfrom
MingJenTai:RTNR_with_hotwording
Nov 23, 2021
Merged

topology: Modify RTNR to work with KWD on TGL and ADL.#4989
lgirdwood merged 1 commit into
thesofproject:mainfrom
MingJenTai:RTNR_with_hotwording

Conversation

@MingJenTai

@MingJenTaiMingJenTai commented Nov 15, 2021

Copy link
Copy Markdown
Contributor

This PR modifies RTNR to work with KWD on TGL and ADL, and removes unused RTNR 16kHz topology.
It also adds RTNR support to max98390 on ADL.

@MingJenTai
Modify RTNR to work with KWD on TGL and ADL.
96022c9
Modify RTNR to work with KWD on TGL and ADL.
Remove unused RTNR 16kHz topology.
Add RTNR support to max98390 on ADL.
Signed-off-by: Ming Jen Tai <mingjen_tai@realtek.com>
@MingJenTaiMingJenTai mentioned this pull request Nov 15, 2021
Closed
lgirdwood
lgirdwood reviewed Nov 15, 2021
View reviewed changes

@lgirdwoodlgirdwood left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this needs to be 3 patches since the commit message say we are doing 3 different things.
@macchian@plbossart any comments. ?

@jairaj-aravajairaj-arava mentioned this pull request Nov 16, 2021
Closed
@macchian

macchian commented Nov 18, 2021

Copy link
Copy Markdown
Contributor

Looks like this needs to be 3 patches since the commit message say we are doing 3 different things. @macchian@plbossart any comments. ?

@lgirdwood , same thoughts.
remove 16k RTNR topology unused relevant codes as one,
then another: add 'RTNR' support in intel-generic-dmic-kwd.m4,
the other: add 'RTNR' macro for TGL and ADL.
@plbossart , any comments?

@MingJenTai

MingJenTai commented Nov 19, 2021

Copy link
Copy Markdown
ContributorAuthor

Hi, @lgirdwood and @macchian thanks for the opinion. I created 3 separate PRs to make it clearer. Please review them instead, thank you!
#5008
#5009
#5010

@lgirdwood

lgirdwood commented Nov 23, 2021

Copy link
Copy Markdown
Member

Zephyr build failure already fixed.

@lgirdwood
lgirdwood merged commit d959089 into thesofproject:mainNov 23, 2021
@marc-hbmarc-hb mentioned this pull request Nov 23, 2021
Closed
@ujfalusiujfalusi mentioned this pull request Nov 24, 2021
Closed
@MingJenTaiMingJenTai mentioned this pull request Dec 1, 2021
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lgirdwoodlgirdwoodlgirdwood approved these changes
@dbalutadbalutaAwaiting requested review from dbaluta
@lbetlejlbetlejAwaiting requested review from lbetlej
@mmaka1mmaka1Awaiting requested review from mmaka1
@plbossartplbossartAwaiting requested review from plbossart

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@MingJenTai@macchian@lgirdwood