audio: volume: optimize volume component with HIFI3 by andrula-song · Pull Request #5169 · thesofproject/sof

andrula-song · 2022-01-10T07:05:04Z

There are 2 methods to optimize volume component in HiFi3

1.Method 1 : Processing data per channel instead of per sample. Skipping address reading and
writing, only load volume gain once for one channel. This method can
reduce about 20% MCPS than the original one

Method 2: Processing continuous data. Asking a 8-byte aligned memory
to store volume gain 4 times, using 2-way or 4-way pipeline operations
of xtensa intrinsics. This method can reduce about 40% MCPS than the
original one.

Signed-off-by: Andurla Song xiaoyuan.song@intel.com

lyakh

wouldn't it be easier to create two additional files for the new optimisation options and link one of them in CMakeLists.txt?

lgirdwood

@singalsu any comments ?

singalsu

Good work! Some comments:

cujomalainey · 2022-01-11T22:20:12Z

@andrula-song if you have fixed comments please mark them as resolved

lgirdwood

Just one minor thing in the regular C code, I'll let @singalsu and others review the intrinsics.
Btw, can you check the formatting in the commit message (the lines look very short). It could be your git config.

andrula-song · 2022-01-14T05:26:42Z

becuse there is still a failed case about check-alsabat-headset-playback.sh on ADLP_RVP_NOCODEC device, I am trying to fix it and may need many submission， so i will creat a new draft to test it.
sorry for disturbing you， and thanks for your comment.

lgirdwood · 2022-01-14T16:48:50Z

becuse there is still a failed case about check-alsabat-headset-playback.sh on ADLP_RVP_NOCODEC device, I am trying to fix it and may need many submission， so i will creat a new draft to test it. sorry for disturbing you， and thanks for your comment.

Please use the same PR and just force push your updates. This keeps the history and context for your changes.

andrula-song · 2022-01-18T08:35:48Z

@lgirdwood It seems like this commit passed all sof-ci test cases except heck-suspend-resume-with-playback-5.sh(other PRs also failed this case). But there is still tgl failed cases of Internal Intel CI System/merge/build, if these are unrelated cases, maybe the latest commit is ready for review.

lgirdwood · 2022-01-18T13:20:07Z

@andrula-song there is an issues with CI that @kkarask is fixing. We should be able to retest later today.

andrula-song · 2022-01-19T04:19:25Z

@kkarask can you provid wav file of failed cases in Internal Intel CI System/merge/build?

andrula-song · 2022-01-20T00:42:17Z

hi @lgirdwood ,
It seems this draft is ready to review now. Can you help to review it?
Thanks.

singalsu

Looks very good, minor things to change!

lgirdwood

@andrula-song looks like we are almost done, but we do need that alignment API as I would imagine other will be doing the same thing. @singalsu any comment ?

lgirdwood

Just need to remove the alignment check and we are good.

Processing continuous data. Asking a 8-byte aligned memory to store volume gain 4 times, using 2-way or 4-way pipeline operations of xtensa intrinsics. This method can reduce about 40% MCPS than the original one. Signed-off-by: Andrula Song <xiaoyuan.song@intel.com>

aiChaoSONG requested review from bkokoszx, cujomalainey and singalsu and removed request for cujomalainey and singalsu January 10, 2022 07:06

aiChaoSONG changed the title ~~Audio: volume component optimization: 2 new methods in HiFi3~~audio: volume: optimize volume component with HIFI3Jan 10, 2022

lyakh reviewed Jan 10, 2022
View reviewed changes

Comment threadsrc/audio/volume/volume.c Outdated
Comment threadsrc/audio/volume/volume_hifi3.c Outdated

lgirdwood requested changes Jan 10, 2022
View reviewed changes

Comment threadsrc/audio/volume/volume.c Outdated
Comment threadsrc/audio/volume/volume_hifi3.c Outdated
Comment threadsrc/audio/volume/volume_hifi3.c Outdated
Comment threadsrc/audio/volume/volume_hifi3.c Outdated

singalsu reviewed Jan 10, 2022
View reviewed changes

cujomalainey reviewed Jan 10, 2022
View reviewed changes

Comment threadsrc/audio/volume/volume.c Outdated
Comment threadsrc/audio/volume/volume_hifi3.c Outdated
Comment threadsrc/audio/volume/volume_hifi3.c Outdated

andrula-song force-pushed the vol-opt branch from 0f736b8 to 415e231Compare January 11, 2022 06:16

lgirdwood reviewed Jan 12, 2022
View reviewed changes

Comment threadsrc/audio/volume/volume.c Outdated

cujomalainey reviewed Jan 13, 2022
View reviewed changes

Comment threadsrc/audio/volume/volume.c Outdated
Comment threadsrc/audio/volume/volume_hifi3.c Outdated

andrula-song mentioned this pull request Jan 13, 2022
ipc4: add S24_3LE for ipc4 #5198
Merged

aiChaoSONG removed the request for review from bkokoszx January 13, 2022 09:56

andrula-song force-pushed the vol-opt branch from 415e231 to cdb4ebbCompare January 14, 2022 04:35

aiChaoSONG requested review from bkokoszx, cujomalainey, lyakh and singalsu and removed request for bkokoszx, cujomalainey, lyakh and singalsu January 14, 2022 05:04

andrula-song force-pushed the vol-opt branch from cdb4ebb to 43b143dCompare January 17, 2022 06:00

andrula-song force-pushed the vol-opt branch from 00faeab to ae45132Compare January 17, 2022 11:48

lgirdwood reviewed Jan 18, 2022
View reviewed changes

Comment threadsrc/audio/volume/volume_hifi3.c Outdated

andrula-song force-pushed the vol-opt branch from ab57a31 to be0591fCompare January 19, 2022 04:37

andrula-song marked this pull request as ready for review January 19, 2022 06:44

andrula-song requested review from dbaluta, lbetlej, mmaka1 and plbossart as code owners January 19, 2022 06:44

andrula-song removed request for dbaluta, lbetlej, mmaka1 and plbossart January 19, 2022 06:47

andrula-song force-pushed the vol-opt branch from be0591f to 8c5d89eCompare January 19, 2022 08:02

cujomalainey suggested changes Jan 20, 2022
View reviewed changes

Comment threadsrc/audio/volume/volume.c Outdated
Comment threadsrc/audio/volume/volume.c Outdated
Comment threadsrc/audio/volume/volume.c Outdated

singalsu reviewed Jan 20, 2022
View reviewed changes

Comment threadsrc/audio/volume/volume.c Outdated
Comment threadsrc/audio/volume/volume.c Outdated
Comment threadsrc/audio/volume/volume.c Outdated
Comment threadsrc/audio/volume/volume_hifi3.c Outdated
Comment threadsrc/audio/volume/volume_hifi3.c Outdated

andrula-song force-pushed the vol-opt branch from 8c5d89e to d129ca5Compare January 21, 2022 14:19

lgirdwood reviewed Jan 24, 2022
View reviewed changes

Comment threadsrc/audio/volume/volume.c Outdated
Comment threadsrc/audio/volume/volume.c Outdated

andrula-song force-pushed the vol-opt branch from d129ca5 to d621ea0Compare January 26, 2022 01:47

lgirdwood reviewed Jan 26, 2022
View reviewed changes

Comment threadsrc/audio/volume/volume.c Outdated

cujomalainey approved these changes Jan 26, 2022
View reviewed changes

cujomalainey mentioned this pull request Jan 26, 2022
[BUG] Remove HiFi code duplication in HiFi buffer management #5273
Closed

andrula-song force-pushed the vol-opt branch from d621ea0 to 3896921Compare January 27, 2022 03:13

lgirdwood approved these changes Jan 27, 2022
View reviewed changes

lgirdwood merged commit 3eaf974 into thesofproject:mainJan 27, 2022

andrula-song deleted the vol-opt branch March 23, 2022 09:05

Uh oh!

Conversation

andrula-song commented Jan 10, 2022

Uh oh!

lyakh left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

lgirdwood left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

singalsu left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

cujomalainey commented Jan 11, 2022

Uh oh!

lgirdwood left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

andrula-song commented Jan 14, 2022

Uh oh!

lgirdwood commented Jan 14, 2022

Uh oh!

andrula-song commented Jan 18, 2022

Uh oh!

lgirdwood commented Jan 18, 2022

Uh oh!

Uh oh!

andrula-song commented Jan 19, 2022

Uh oh!

andrula-song commented Jan 20, 2022

Uh oh!

Uh oh!

Uh oh!

Uh oh!

singalsu left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

lgirdwood left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

lgirdwood left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!