Uh oh!
There was an error while loading. Please reload this page.
xtensa-build-zephyr.py: add ipc4 build support for tgl - #5412
Conversation
aiChaoSONG
commented
Feb 24, 2022
Andrey proposed a very nice solution for sof+zephyr+ipc4 build, but it cannot implemented very soon because of the complexity, and it is still under discussion. This PR borrows some concepts from there, for example, file structure. The solution here uses the OVERLAY_CONFIG for IPC4 software config overlay instead of CONF_FILE, and make use of Marc's patch on This solution targeting on a temporary solution for sof+zephyr+ipc4 build, it has no implementation conflict with the Andrey's solution. Your can take this PR here as part of Andrey's solution |
kv2019i
left a comment
There was a problem hiding this comment.
Looks great, thanks @aiChaoSONG ! Slight typo in commit "zepher"->"zephyr".
gkbldcig
commented
Feb 24, 2022
Can one of the admins verify this patch? |
lgirdwood
commented
Feb 24, 2022
@aborisovich any comments ? |
marc-hb
left a comment
There was a problem hiding this comment.
Slight typo in commit "zepher"->"zephyr".
Also, don't drop the .py suffix in the subject because we still have the .sh script right now (for a limited time)
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Add ipc4 build support for tgl with OVERLAY_CONFIG. Signed-off-by: Chao Song <chao.song@linux.intel.com>
aiChaoSONG
commented
Feb 25, 2022
Version 2:
|
Can you rename tgl_ipc4_overlay.conf to just ipc4_overlay.conf ? All the rest LGTM
marc-hb
commented
Feb 28, 2022
We have two xtensa-build-zephyr build scripts right now, transitioning from .sh to .py. Please keep the filename extension in the commit subject otherwise it makes managing the transition period much harder than it has to be. |
marc-hb
commented
Sep 21, 2022
I'm removing the |
Add ipc4 build support for tgl with OVERLAY_CONFIG.
Signed-off-by: Chao Song chao.song@linux.intel.com
if any other IPC4 config should be added, please comment.
similar implementation in xtensa-build-zephyr.sh will not be done, because it is going to be deprecated, use xtensa-build-zephyr.py instead.