Uh oh!
There was an error while loading. Please reload this page.
preproc: varargscount: bugfix for tokens starting with '(' not being counted - #543
Conversation
4e0c843 to
cefa580CompareUh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
I am thinking about removing all whitespaces for this check in the future, as it really doesn't matter whether preprocessor gives usuint32_t param0 , uint32_t... oruint32_t param0,uint32_t...
as the compiler doesn't care.
Again, I'd rather not do this in bugfix PR.
There was a problem hiding this comment.
New unit tests:
#define PARENTHESIS_PRE() (1+3)/2
#define PARENTHESIS_POST() 4/(3-1)
...
TEST_HERE_DECLARE(func_name, with_parenthesis_pre, 1, PARENTHESIS_PRE())
TEST_HERE_DECLARE(func_name, with_parenthesis_post, 1,PARENTHESIS_POST())
…g with parenthesis not being counted ; also introduced unit tests to check the issue Signed-off-by: Michal Jerzy Wierzbicki <michalx.wierzbicki@linux.intel.com>
cefa580 to
87dad4aComparemwierzbix
commented
Nov 6, 2018
Great, Travis build for SUE hanged during |
xiulipan
commented
Nov 6, 2018
@mwierzbix
|
lgirdwood
commented
Nov 6, 2018
@mwierzbix Fwiw, Travis can be restarted if you click on details and the rebuild. |
mwierzbix
commented
Nov 7, 2018
@lgirdwood@xiulipan Thanks :) |
lgirdwood
commented
Nov 7, 2018
Added @slawblauciak for cmocka parts |
…ount_0_for_parenthesis
; also introduced unit tests to check the issue
Signed-off-by: Michal Jerzy Wierzbicki michalx.wierzbicki@linux.intel.com
varargscount is macro META_COUNT_VARARGS_BEFORE_COMPILE
Fix for issue #542