Skip to content

host: trace: revert host traces to fprintf - #548

Merged
lgirdwood merged 1 commit into
thesofproject:masterfrom
bkokoszx:revert-host-traces
Nov 8, 2018
Merged

host: trace: revert host traces to fprintf#548
lgirdwood merged 1 commit into
thesofproject:masterfrom
bkokoszx:revert-host-traces

Conversation

@bkokoszx

@bkokoszxbkokoszx commented Nov 7, 2018

Copy link
Copy Markdown
Collaborator

Host doesn't use trace mechanism - I've reverted
all host traces to simple fprintf.

Signed-off-by: Bartosz Kokoszko bartoszx.kokoszko@linux.intel.com

@bkokoszx
bkokoszxforce-pushed the revert-host-traces branch 3 times, most recently from bea10b4 to 4196244CompareNovember 7, 2018 16:44
@sofci

sofci commented Nov 8, 2018

Copy link
Copy Markdown
Collaborator

Can one of the admins verify this patch?

@xiulipan

xiulipan commented Nov 8, 2018

Copy link
Copy Markdown
Contributor

SOFCI TEST

@lgirdwood

lgirdwood commented Nov 8, 2018

Copy link
Copy Markdown
Member

@bkokoszx can you check the travis CI, lost of build errors for host. Btw, did you run the host build all script ?

@bkokoszx

bkokoszx commented Nov 8, 2018

Copy link
Copy Markdown
CollaboratorAuthor

@lgirdwood
I'm aware of CI failure. I'm working on that now.

@bkokoszxbkokoszx mentioned this pull request Nov 8, 2018
Merged
@bkokoszx
bkokoszxforce-pushed the revert-host-traces branch 2 times, most recently from fea1fd5 to 1a315fbCompareNovember 8, 2018 09:37
@bkokoszx
bkokoszxforce-pushed the revert-host-traces branch 5 times, most recently from 35509e7 to bdde0d8CompareNovember 8, 2018 12:08
mwierzbix
mwierzbix suggested changes Nov 8, 2018
View reviewed changes

@mwierzbixmwierzbix left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice solution but please do fix whitespace changes.

Comment threadsrc/include/sof/trace.h Outdated
Comment threadsrc/include/sof/trace.h Outdated
Comment threadsrc/include/sof/trace.h Outdated
Comment threadsrc/include/sof/trace.h Outdated
Comment threadsrc/include/sof/trace.h Outdated
Comment threadsrc/include/sof/trace.h Outdated
Comment threadsrc/include/sof/trace.h Outdated
Comment threadsrc/include/sof/trace.h Outdated
Comment threadsrc/host/trace.c Outdated
@bkokoszx
bkokoszxforce-pushed the revert-host-traces branch 3 times, most recently from bfdd7a3 to 838184eCompareNovember 8, 2018 12:50
mwierzbix
mwierzbix suggested changes Nov 8, 2018
View reviewed changes
Comment threadsrc/host/trace.c Outdated
@bkokoszx
bkokoszxforce-pushed the revert-host-traces branch 2 times, most recently from 6f0d1a4 to a9c9ddaCompareNovember 8, 2018 14:11
@bkokoszx
host: trace: revert host traces to fprintf
e69b42f
Host doesn't use trace mechanism - I've reverted
all host traces to simple fprintf.
Signed-off-by: Bartosz Kokoszko <bartoszx.kokoszko@linux.intel.com>
@bkokoszx

bkokoszx commented Nov 8, 2018

Copy link
Copy Markdown
CollaboratorAuthor

@lgirdwood
It looks like travis is ok now. Internal Ci fails, because of #553

@lgirdwood
lgirdwood merged commit 9b376d7 into thesofproject:masterNov 8, 2018
@bkokoszxbkokoszx mentioned this pull request Nov 9, 2018
Closed
@bkokoszx
bkokoszx deleted the revert-host-traces branch November 22, 2018 09:52
@marc-hbmarc-hb mentioned this pull request Sep 6, 2022
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@akloniexakloniexAwaiting requested review from akloniex
1 more reviewer
@mwierzbixmwierzbixmwierzbix approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@bkokoszx@sofci@xiulipan@lgirdwood@mwierzbix