Skip to content

ipc4: return ipc4 error status instead of posix error - #5799

Merged
lgirdwood merged 1 commit into
thesofproject:mainfrom
RanderWang:ipc4_error_refine
May 12, 2022
Merged

ipc4: return ipc4 error status instead of posix error#5799
lgirdwood merged 1 commit into
thesofproject:mainfrom
RanderWang:ipc4_error_refine

Conversation

@RanderWang

Copy link
Copy Markdown
Collaborator

Convert posix error to ipc4 error and return ipc4 error for
functions in ipc4 directory.

fixes#5737

@lgirdwoodlgirdwood left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lyakhlyakh left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also return 0 in ipc4_create_pipeline(), in ipc_comp_connect(), ipc_comp_disconnect() should be return IPC4_SUCCESS. Also a bit strange, that a static function process_dma_index() in that file returns POSIX error codes, although they're replaced with IPC4 codes later, so, it isn't really a bug

Convert posix error to ipc4 error and return ipc4 error for
functions in ipc4 directory.
Signed-off-by: Rander Wang <rander.wang@intel.com>
@lgirdwood

Copy link
Copy Markdown
Member

also return 0 in ipc4_create_pipeline(), in ipc_comp_connect(), ipc_comp_disconnect() should be return IPC4_SUCCESS. Also a bit strange, that a static function process_dma_index() in that file returns POSIX error codes, although they're replaced with IPC4 codes later, so, it isn't really a bug

@RanderWang can you make this a new PR to align these other functions with correct IPC4 return codes.

@RanderWang

Copy link
Copy Markdown
CollaboratorAuthor

@lgirdwood@lyakh updated according to your comments. Thanks!

@lgirdwood
lgirdwood merged commit 1e7220e into thesofproject:mainMay 12, 2022
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG][IPC4] wrong error handling in IPC4, potentially leading to missed failures

5 participants

@RanderWang@lgirdwood@lyakh@marcinszkudlinski@tmleman