Skip to content

ipc4: add mixing-based processing in channel selector - #6383

Merged
kv2019i merged 1 commit into
thesofproject:mainfrom
tlissows:sof-selector_ipc4
Oct 18, 2022
Merged

ipc4: add mixing-based processing in channel selector#6383
kv2019i merged 1 commit into
thesofproject:mainfrom
tlissows:sof-selector_ipc4

Conversation

@tlissows

@tlissowstlissows commented Oct 7, 2022

Copy link
Copy Markdown
Contributor

Add mixing-based processing in channel selector to implement capabilities resulting from IPC4 configuration.

Signed-off-by: Tomasz Lissowski tomasz.lissowski@intel.com

lyakh
lyakh reviewed Oct 10, 2022
View reviewed changes
Comment threadsrc/audio/selector/selector.c Outdated
Comment threadsrc/audio/selector/selector.c Outdated
Comment threadsrc/audio/selector/selector_generic.c Outdated
Comment threadsrc/audio/selector/selector_generic.c Outdated
RanderWang
RanderWang reviewed Oct 11, 2022
View reviewed changes
Comment threadsrc/audio/selector/selector_generic.c Outdated
RanderWang
RanderWang reviewed Oct 12, 2022
View reviewed changes
Comment threadsrc/audio/selector/selector_generic.c Outdated
RanderWang
RanderWang approved these changes Oct 12, 2022
View reviewed changes

@RanderWangRanderWang left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LTGM

@wszypelt

wszypelt commented Oct 13, 2022

Copy link
Copy Markdown

SOFCI TEST

@miRoox

miRoox commented Oct 14, 2022

Copy link
Copy Markdown

SOFCI TEST

mmaka1
mmaka1 reviewed Oct 14, 2022
View reviewed changes
Comment threadsrc/include/sof/audio/selector.h Outdated
Comment threadsrc/include/sof/audio/selector.h Outdated
@tlissows
ipc4: add mixing-based processing in channel selector
91c7b6c
Add mixing-based processing in channel selector to implement
capabilities resulting from IPC4 configuration. Enable flexible
channels count (from 1 to 8) independently for input and output.
Signed-off-by: Tomasz Lissowski <tomasz.lissowski@intel.com>
@tlissows
tlissows requested a review from mmaka1October 14, 2022 13:36
@kv2019i

kv2019i commented Oct 17, 2022

Copy link
Copy Markdown
Collaborator

@mmaka1 Good to go?

@kv2019ikv2019i mentioned this pull request Oct 17, 2022
Merged
@kv2019i

kv2019i commented Oct 18, 2022

Copy link
Copy Markdown
Collaborator

Known fail in IPC4 test set, proceeding with merge.

@kv2019i
kv2019i merged commit 8c60a56 into thesofproject:mainOct 18, 2022
@tlissows
tlissows deleted the sof-selector_ipc4 branch October 18, 2022 11:46
@fkwasowifkwasowi mentioned this pull request Oct 20, 2022
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mmaka1mmaka1mmaka1 approved these changes
@kv2019ikv2019ikv2019i approved these changes
@lgirdwoodlgirdwoodAwaiting requested review from lgirdwoodlgirdwood is a code owner
@plbossartplbossartAwaiting requested review from plbossartplbossart is a code owner
@lbetlejlbetlejAwaiting requested review from lbetlejlbetlej is a code owner
@dbalutadbalutaAwaiting requested review from dbalutadbaluta is a code owner
@lyakhlyakhAwaiting requested review from lyakh
@singalsusingalsuAwaiting requested review from singalsu
+1 more reviewer
@RanderWangRanderWangRanderWang approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@tlissows@wszypelt@miRoox@kv2019i@lyakh@singalsu@RanderWang@mmaka1