Skip to content

ipc4: fix for mixout not working after reset - #6433

Merged
kv2019i merged 1 commit into
thesofproject:mainfrom
serhiy-katsyuba-intel:mixin_mixout_6405
Oct 19, 2022
Merged

ipc4: fix for mixout not working after reset#6433
kv2019i merged 1 commit into
thesofproject:mainfrom
serhiy-katsyuba-intel:mixin_mixout_6405

Conversation

@serhiy-katsyuba-intel

@serhiy-katsyuba-intelserhiy-katsyuba-intel commented Oct 17, 2022

Copy link
Copy Markdown
Contributor

Fixes a bug in mixout_reset(): mixin pointers in mixed data info should not be cleared on reset. They should only be set on bind and cleared on unbind.

Signed-off-by: Serhiy Katsyuba serhiy.katsyuba@intel.com

@serhiy-katsyuba-intel
ipc4: fix for mixout not working after reset
05505a4
Fixes a bug in mixout_reset(): mixin pointers in mixed data info
should not be cleared on reset. They should only be set on bind
and cleared on unbind.
Signed-off-by: Serhiy Katsyuba <serhiy.katsyuba@intel.com>
@serhiy-katsyuba-intel
serhiy-katsyuba-intel marked this pull request as ready for review October 17, 2022 19:36
This was referenced Oct 17, 2022
Closed
Closed
@kv2019i

kv2019i commented Oct 18, 2022

Copy link
Copy Markdown
Collaborator

@serhiy-katsyuba-intel Can you undraft this, this seems very good. Together with kernel PR thesofproject/linux#3917 , this is getting much better results with mixer topologies.

@serhiy-katsyuba-intel

serhiy-katsyuba-intel commented Oct 18, 2022

Copy link
Copy Markdown
ContributorAuthor

@serhiy-katsyuba-intel Can you undraft this, this seems very good. Together with kernel PR thesofproject/linux#3917 , this is getting much better results with mixer topologies.

The PR is not draft since yesterday. Probably some refresh issue on your side. The PR is ready to merge.
The failure reported by the CI looks like the CI problem and is unrelated to modifications made.

@kv2019i

kv2019i commented Oct 18, 2022

Copy link
Copy Markdown
Collaborator

@serhiy-katsyuba-intel wrote:

The PR is not draft since yesterday. Probably some refresh issue on your side. The PR is ready to merge. The failure reported by the CI looks like the CI problem and is unrelated to modifications made.

Ack, this is good to now! We need to wait for the few mandatory CI runs to complete and then this should be good to merge. The already reported CI issues are known ones.

@kv2019i

kv2019i commented Oct 19, 2022

Copy link
Copy Markdown
Collaborator

@wszypelt sorry, need to bug you again. I couldn't find this PR at all in Intel CI dashboards, so it appears it was not queued. Need a retrigger?

@wszypelt

wszypelt commented Oct 19, 2022•
edited
Loading

Copy link
Copy Markdown

@kv2019i
It's good to let me know. in fact qb did not queue this pr correctly, I started it manually, within 30 minutes there should be results

@kv2019i

kv2019i commented Oct 19, 2022

Copy link
Copy Markdown
Collaborator

Thank you @wszypelt ! Now all looks good. One known failure (fix in review at thesofproject/sof-test#971 ), so proceeding with merge.

@kv2019i
kv2019i merged commit 5c6bac4 into thesofproject:mainOct 19, 2022
@lyakhlyakh mentioned this pull request Oct 21, 2022
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lyakhlyakhlyakh approved these changes
@kv2019ikv2019ikv2019i approved these changes
@marcinszkudlinskimarcinszkudlinskimarcinszkudlinski approved these changes
@lgirdwoodlgirdwoodAwaiting requested review from lgirdwoodlgirdwood is a code owner
@plbossartplbossartAwaiting requested review from plbossartplbossart is a code owner
@mmaka1mmaka1Awaiting requested review from mmaka1mmaka1 is a code owner
@lbetlejlbetlejAwaiting requested review from lbetlejlbetlej is a code owner
@dbalutadbalutaAwaiting requested review from dbalutadbaluta is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@serhiy-katsyuba-intel@kv2019i@wszypelt@lyakh@marcinszkudlinski