Skip to content

native drivers test - #6438

Closed
juimonen wants to merge 2 commits into
thesofproject:mainfrom
juimonen:native_drivers_test
Closed

native drivers test#6438
juimonen wants to merge 2 commits into
thesofproject:mainfrom
juimonen:native_drivers_test

Conversation

@juimonen

@juimonenjuimonen commented Oct 18, 2022

Copy link
Copy Markdown

test native drivers build

Signed-off-by: Jaska Uimonen jaska.uimonen@intel.com

@juimonen
juimonenforce-pushed the native_drivers_test branch 11 times, most recently from d19dec5 to 8794603CompareNovember 2, 2022 18:46
@kv2019ikv2019i mentioned this pull request Nov 4, 2022
Closed
@juimonen
juimonenforce-pushed the native_drivers_test branch 8 times, most recently from dea20f9 to 33eb611CompareNovember 10, 2022 18:26
@lgirdwood

lgirdwood commented Nov 11, 2022

Copy link
Copy Markdown
Member

@juimonen@abonislawski good work guys - I was able to move dai-legacy.h and dai-zephyr.h to the xtos/zephyr folders without too much pain. @juimonen can you pls complete my topic/lrg/rtos-dai branch for the dai header move. It shows we still use some xtos headers for dai api, but the number is getting smaller :)

@juimonen
juimonenforce-pushed the native_drivers_test branch 6 times, most recently from 9bd33bc to 6596054CompareNovember 18, 2022 08:45
@lgirdwood

lgirdwood commented Nov 18, 2022

Copy link
Copy Markdown
Member

@juimonen how is this looking and the dai.h move looking. Do we have an ETA ?

@juimonen

juimonen commented Nov 18, 2022

Copy link
Copy Markdown
Author

@juimonen how is this looking and the dai.h move looking. Do we have an ETA ?

This has now some experimental commits for the hda dai -> but if you look at my last comments in zephyrproject-rtos/zephyr#51000, we probably need to go first with the 19 hda nodes.
I tried to spend last couple of days thinking/testing different options to make the hda dt "clean", but concerning all parties
requirements -> we should just stick with the model in the pr, just fix the warnings.

So test results are good for all dais -> we should/could move to native immediately after above hda dai pr is merged (with tgl DT entries).

lyakh
lyakh reviewed Nov 21, 2022
View reviewed changes
Comment threadsrc/lib/dai.c Outdated

@lyakhlyakhNov 21, 2022

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could simplify this a bit by placing

if (cfg->type != type)
continue;

before the switch

@juimonen
juimonenforce-pushed the native_drivers_test branch 7 times, most recently from dbcc33c to acb38a5CompareNovember 25, 2022 07:43
Jaska Uimonen added 2 commits November 29, 2022 14:05
Jaska Uimonen
tgl: ipc4: zephyr: move to native drivers
e312855
Set tgl ipc4 overlays to use zephyr native drivers.
Signed-off-by: Jaska Uimonen <jaska.uimonen@intel.com>
Jaska Uimonen
west.yaml: upgrade Zephyr to stable2.4
782763f
Upgrade Zephyr to stable2.4 branch in thesofproject, which has
cherry-picked hda dai not yet in zephyr upstream. Other changes only
from zephyr upstream.
bd60b9289a635 hda dai
063984d0b8dec zephyr upstream main
Signed-off-by: Jaska Uimonen <jaska.uimonen@intel.com>
@juimonen
juimonenforce-pushed the native_drivers_test branch 3 times, most recently from 170cab6 to 782763fCompareNovember 29, 2022 12:44
@juimonen

juimonen commented Dec 20, 2022

Copy link
Copy Markdown
Author

closing, everything merged in other PRs.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lyakhlyakhlyakh left review comments
@lgirdwoodlgirdwoodAwaiting requested review from lgirdwoodlgirdwood will be requested when the pull request is marked ready for reviewlgirdwood is a code owner
@plbossartplbossartAwaiting requested review from plbossartplbossart will be requested when the pull request is marked ready for reviewplbossart is a code owner
@mmaka1mmaka1Awaiting requested review from mmaka1mmaka1 will be requested when the pull request is marked ready for reviewmmaka1 is a code owner
@lbetlejlbetlejAwaiting requested review from lbetlejlbetlej will be requested when the pull request is marked ready for reviewlbetlej is a code owner
@dbalutadbalutaAwaiting requested review from dbalutadbaluta will be requested when the pull request is marked ready for reviewdbaluta is a code owner
@kv2019ikv2019iAwaiting requested review from kv2019ikv2019i will be requested when the pull request is marked ready for reviewkv2019i is a code owner
Copilot code reviewCopilot
Copilot will automatically review once the pull request is marked ready for review

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@juimonen@lgirdwood@lyakh