mtl upstream: mux: fix FW build with xt-clang

[marcinszkudlinski]

Newer Xtensa toolchain replaces xt-xcc with xt-clang. For some reason xt-clang fails to build SOF when uint8_t type is used as index of for() loop. This change unblocks building of SOF with xt-clang.

Signed-off-by: Jaroslaw Stelter Jaroslaw.Stelter@intel.com

[kv2019i]

This seems like a welcome change in general. Using stdint.h as local variable is not a good practise. One note on signed/unsigned differnece here, it could cause further compiler warnings later on.

[kv2019i]

Thanks, looks good now.

[lgirdwood]

Ah , now seeing this compile error on several PRs.

/zep_workspace/sof/src/audio/up_down_mixer/up_down_mixer.c
/zep_workspace/sof/src/audio/up_down_mixer/up_down_mixer.c: In function 'up_down_mixer_new':
/zep_workspace/sof/src/audio/up_down_mixer/up_down_mixer.c:423:39: error: passing argument 2 of 'init_up_down_mixer' discards 'const' qualifier from pointer target type [-Werror=discarded-qualifiers]
423 | ret = init_up_down_mixer(dev, config, spec);
| ^~~~~~
/zep_workspace/sof/src/audio/up_down_mixer/up_down_mixer.c:340:77: note: expected 'struct comp_ipc_config *' but argument is of type 'const struct comp_ipc_config *'
340 | static int init_up_down_mixer(struct comp_dev *dev, struct comp_ipc_config *config, void *spec)
| ~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~
/zep_workspace/sof/src/audio/up_down_mixer/up_down_mixer.c:423:47: error: passing argument 3 of 'init_up_down_mixer' discards 'const' qualifier from pointer target type [-Werror=discarded-qualifiers]
423 | ret = init_up_down_mixer(dev, config, spec);
| ^~~~
/zep_workspace/sof/src/audio/up_down_mixer/up_down_mixer.c:340:91: note: expected 'void *' but argument is of type 'const void *'
340 | static int init_up_down_mixer(struct comp_dev *dev, struct comp_ipc_config *config, void *spec)
| ~~~~~~^~~~

[jxstelter]

Ah , now seeing this compile error on several PRs.

/zep_workspace/sof/src/audio/up_down_mixer/up_down_mixer.c
/zep_workspace/sof/src/audio/up_down_mixer/up_down_mixer.c: In function 'up_down_mixer_new':
/zep_workspace/sof/src/audio/up_down_mixer/up_down_mixer.c:423:39: error: passing argument 2 of 'init_up_down_mixer' discards 'const' qualifier from pointer target type [-Werror=discarded-qualifiers]
423 | ret = init_up_down_mixer(dev, config, spec);
| ^~~~~~
/zep_workspace/sof/src/audio/up_down_mixer/up_down_mixer.c:340:77: note: expected 'struct comp_ipc_config *' but argument is of type 'const struct comp_ipc_config *'
340 | static int init_up_down_mixer(struct comp_dev *dev, struct comp_ipc_config *config, void *spec)
| ~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~
/zep_workspace/sof/src/audio/up_down_mixer/up_down_mixer.c:423:47: error: passing argument 3 of 'init_up_down_mixer' discards 'const' qualifier from pointer target type [-Werror=discarded-qualifiers]
423 | ret = init_up_down_mixer(dev, config, spec);
| ^~~~
/zep_workspace/sof/src/audio/up_down_mixer/up_down_mixer.c:340:91: note: expected 'void *' but argument is of type 'const void *'
340 | static int init_up_down_mixer(struct comp_dev *dev, struct comp_ipc_config *config, void *spec)
| ~~~~~~^~~~

It looks like failures unrelated with this particular change.

[kv2019i]

@jxstelter wrote:

It looks like failures unrelated with this particular change.

Ack , fixed in #6529

[kv2019i]

Was about to merge, but then noticed the checkpatch warning on missing signed-off-by. This needs to be added... then it's good. Tests are ok now, only known failures in the report.

[kv2019i]

@marcinszkudlinski Checkpatch is stil not happy:
ERROR: Missing Signed-off-by: line by nominal patch author 'Marcin Szkudlinski marcin.szkudlinski@intel.com'

[marcinszkudlinski]

@marcinszkudlinski wrote:

yes, I'm not the author, Jarek is, I'm only upstreaming the commit. So the signed off line says the truth
I can change it, no problem, yet better to leave it as is

Ack, so please change the author to Jarek as well. E.g.

git commit --amend --author="Jaroslaw Stelter <Jaroslaw.Stelter@intel.com>" -s

There needs to be a signed-off by the author. You can add your own signed-off as well as you are upstreaming the change, so the "-s" is good above.

UPDATE: sorry, I edited your comment when I was supposed to reply. It seems as a maintainer I can do this which is very confusing.

[kv2019i]

Thanks! Once the CI run completes, I'll proceed with merge..