Uh oh!
There was an error while loading. Please reload this page.
dai: move AMD_HS to end of list to restore backwards-compatibility - #6616
Merged
Conversation
The addition of AMD_HS breaks Mediatek platforms by using an index previously allocated to Mediatek. This is a backwards-compatibility issue and needs to be fixed. All firmware released by AMD needs to be re-generated and re-distributed. Fixes: 83ee5b4 ("dai: support for amd specific hs dai id") Link: thesofproject#6615 Link: https://lore.kernel.org/alsa-devel/36a45c7a-820a-7675-d740-c0e83ae2c417@collabora.com/ Reported-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
plbossart
requested review from
RanderWang and marcinszkudlinski
as code ownersNovember 16, 2022 15:46
lgirdwood
commented
Nov 16, 2022
Member
@thesofproject/amd @thesofproject/google @thesofproject/mediatek pls see and comment for impact on your platforms. |
plbossart
requested review from
balakishorepati, bhiregou, bhiregoudar, cujomalainey, kuanhsuncheng and lgirdwoodNovember 16, 2022 16:54
bhiregoudar
approved these changes
Nov 17, 2022
kholk
commented
Nov 17, 2022
|
plbossart
commented
Nov 17, 2022
MemberAuthor
@lgirdwood ready on my side to merge the kernel side, you good here? |
lgirdwood
approved these changes
Nov 18, 2022
lgirdwood
commented
Nov 18, 2022
Member
SOFCI TEST |
lgirdwood
commented
Nov 18, 2022
Member
Looks like CI got stuck so rerun. |
lgirdwood
commented
Nov 18, 2022
Member
@thesofproject/mediatek any comments ? |
plbossart
commented
Nov 18, 2022
MemberAuthor
@lgirdwood the change is in Mark Brown's tree now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The addition of AMD_HS breaks Mediatek platforms by using an index previously allocated to Mediatek. This is a backwards-compatibility issue and needs to be fixed. All firmware released by AMD needs to be re-generated and re-distributed.
Fixes: 83ee5b4 ("dai: support for amd specific hs dai id")
Link: #6615
Link: https://lore.kernel.org/alsa-devel/36a45c7a-820a-7675-d740-c0e83ae2c417@collabora.com/
Reported-by: AngeloGioacchino Del Regno angelogioacchino.delregno@collabora.com
Signed-off-by: Pierre-Louis Bossart pierre-louis.bossart@linux.intel.com