Uh oh!
There was an error while loading. Please reload this page.
ipc4: use IMR_BOOT_LDR_MANIFEST_BASE definition from adsp_memory.h - #6678
Merged
Merged
Conversation
kv2019i
requested review from
dbaluta, lbetlej, lgirdwood, mmaka1 and plbossart
as code ownersNovember 28, 2022 15:36
kv2019i
commented
Nov 28, 2022
CollaboratorAuthor
@marcinszkudlinski This is overlapping with your #6613 , so if you are quick with that, we can just go ahead and merge that. But here's just the build fixes in a separate PR. |
juimonen
approved these changes
Nov 28, 2022
juimonen
left a comment
There was a problem hiding this comment.
lgtm. and removes the warning from mtl build.
marcinszkudlinski
approved these changes
Nov 28, 2022
marcinszkudlinski
left a comment
Contributor
There was a problem hiding this comment.
proceed with this, warnings are really annoying
my PR need to wait for build system changes
lgirdwood
approved these changes
Nov 28, 2022
lgirdwood
commented
Nov 28, 2022
Member
@kv2019i looks like one config needs a fix |
Start migrating to use Zephyr definitions for the memory layout. As we cannot move all users of legacy memory.h, selectively mark the definitions that have already moved to make. Signed-off-by: Kai Vehmanen <kai.vehmanen@linux.intel.com>
kv2019iforce-pushed
the
202211-fix-memory-h-warnings
branch
from
November 28, 2022 17:29
fb276c7 to
9359c4cComparekv2019i
commented
Nov 28, 2022
CollaboratorAuthor
V2:
|
tmleman
approved these changes
Nov 28, 2022
kv2019i
commented
Nov 29, 2022
CollaboratorAuthor
CI checks ok, proceeding with merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Start migrating to use Zephyr definitions for the memory layout. As we cannot move all users of legacy memory.h, selectively mark the definitions that have already moved to make.
Signed-off-by: Kai Vehmanen kai.vehmanen@linux.intel.com