Math: Library: Add the hifi4 exponential function by ShriramShastry · Pull Request #6801 · thesofproject/sof

ShriramShastry · 2022-12-14T08:22:47Z

The 32-bit HiFi4 exponential library function has an accuracy of 1e-4, a unit in last place error of 5.60032793, and output ranges from 0.0067379470 to 148.4131591026 for inputs from -5 to +5 (Q4.28) (Q9.23).

Signed-off-by: ShriramShastry malladi.sastry@intel.com

lgirdwood

@andrula-song @singalsu pls review

singalsu · 2022-12-19T10:11:08Z

Extra blanks after ae_int64 *. You could also avoid this function proto with move of mul_s64() here.

singalsu · 2022-12-19T10:22:11Z

declare variables in the begin of function

singalsu · 2022-12-19T10:26:10Z

Declare all variables in the beginning

singalsu · 2022-12-19T10:30:56Z

Can you compare qt directly to integer constant without need for qt_temp?

qt temp = qt; is used to prevent the following error in the event that (qt < CONVERG_ERROR)
no operator overload defined for binary operator '<' (operand types 'ae_int64' (aka '_TIE_xt_hifi2_ae_int64') 'long long')
can you please suggest clean approach.

ShriramShastry

Thank you for looking at the code.
I incorporated the proposal and expressed my opinion.

ShriramShastry · 2022-12-26T12:21:54Z

qt temp = qt; is used to prevent the following error in the event that (qt < CONVERG_ERROR)
no operator overload defined for binary operator '<' (operand types 'ae_int64' (aka '_TIE_xt_hifi2_ae_int64') 'long long')
can you please suggest clean approach.

ShriramShastry · 2022-12-26T12:23:20Z

ShriramShastry · 2022-12-26T12:23:32Z

lgirdwood · 2023-01-04T17:03:56Z

@ShriramShastry btw, whats the speedup here vs generic C version ?

singalsu · 2023-06-09T08:15:28Z

This unrelated change could be in another commit with title indicating improvement of cmocka test coverage. I assume the old test with 256 points would work with hifi4 version too.

kv2019i

Code looks ready to go, but the Kconfig addition/rename needs clarification. See comment inline.

ShriramShastry · 2023-06-12T11:35:25Z

Code looks ready to go, but the Kconfig addition/rename needs clarification. See comment inline.

Kconfig, is enabled or disabled by below code, In the moment, it is disabled, to enable make default n to y

config EXP_FIXED
bool "Exponential functions"
default n
help
By selecting this, the 32-bit sofm_exp_int32() function can be used to calculate
exponential values. With a maximum ulp of 5, an exponential function with
an input range of -5 to +5 gives positive numbers between 0.00673794699908547 and
148.413159102577. The precision of this function is 1e-4.

ShriramShastry · 2023-06-12T12:13:40Z

Code looks ready to go, but the Kconfig addition/rename needs clarification. See comment inline.
Kconfig, is enabled or disabled by below code, In the moment, it is disabled, to enable make default n to y
config EXP_FIXED bool "Exponential functions" default n help By selecting this, the 32-bit sofm_exp_int32() function can be used to calculate exponential values. With a maximum ulp of 5, an exponential function with an input range of -5 to +5 gives positive numbers between 0.00673794699908547 and 148.413159102577. The precision of this function is 1e-4.

Done !! Renamed EXP_FIXED to MATH_EXP.
Thanks

kv2019i

Thanks @ShriramShastry , looks good now.

ShriramShastry · 2023-06-14T01:54:21Z

Thanks @ShriramShastry , looks good now.

Thank you. Is there any other unresolved issue that needs to be addressed?

kv2019i · 2023-06-14T09:53:26Z

@cujomalainey Ok to proceed with this? You still have a requested-changes pending.

cujomalainey · 2023-06-14T16:27:24Z

@cujomalainey Ok to proceed with this? You still have a requested-changes pending.

I'll re-review today

cujomalainey · 2023-06-15T00:07:41Z

looks like my comment is still open, would be nice to get it fixed but i won't block on it

The 32-bit HiFi4 exponential library function has an accuracy of 1e-4, a unit in last place error of 5.60032793, and output ranges from 0.0067379470 to 148.4131591026 for inputs from -5 to +5 (Q4.28) (Q9.23). Signed-off-by: ShriramShastry <malladi.sastry@intel.com>

ShriramShastry · 2023-06-15T02:01:02Z

looks like my comment is still open, would be nice to get it fixed but i won't block on it

Done !!

ShriramShastry force-pushed the Hifi4_Exponential_function_dev branch 7 times, most recently from 3ed16a6 to 131fc13Compare December 14, 2022 14:19

lgirdwood reviewed Dec 15, 2022
View reviewed changes

Comment threadsrc/math/Kconfig Outdated

singalsu reviewed Dec 19, 2022
View reviewed changes

ShriramShastry force-pushed the Hifi4_Exponential_function_dev branch 17 times, most recently from 51bc618 to 3465959Compare December 27, 2022 06:55

ShriramShastry force-pushed the Hifi4_Exponential_function_dev branch from 3465959 to a771b4aCompare January 3, 2023 15:31

ShriramShastry commented Jan 3, 2023
View reviewed changes

ShriramShastry force-pushed the Hifi4_Exponential_function_dev branch from a771b4a to 8eab8d6Compare January 4, 2023 06:08

ShriramShastry requested review from andrula-song, btian1 and lgirdwood June 3, 2023 01:34

ShriramShastry force-pushed the Hifi4_Exponential_function_dev branch 2 times, most recently from 9533b89 to cacde9dCompare June 3, 2023 02:02

cujomalainey reviewed Jun 6, 2023
View reviewed changes

Comment threadsrc/math/exp_fcn_hifi4.c Outdated

ShriramShastry requested a review from cujomalainey June 8, 2023 06:09

singalsu requested changes Jun 9, 2023
View reviewed changes

ShriramShastry force-pushed the Hifi4_Exponential_function_dev branch from cacde9d to 954d65fCompare June 9, 2023 09:13

singalsu reviewed Jun 9, 2023
View reviewed changes

Comment threadtest/cmocka/src/math/arithmetic/exponential.c Outdated

ShriramShastry force-pushed the Hifi4_Exponential_function_dev branch 6 times, most recently from 04ebea6 to b4c6345Compare June 9, 2023 16:21

ShriramShastry requested a review from singalsu June 9, 2023 16:50

singalsu approved these changes Jun 12, 2023
View reviewed changes

kv2019i reviewed Jun 12, 2023
View reviewed changes

Comment threadsrc/math/CMakeLists.txt Outdated

ShriramShastry force-pushed the Hifi4_Exponential_function_dev branch from b4c6345 to 751f887Compare June 12, 2023 12:07

kv2019i approved these changes Jun 12, 2023
View reviewed changes

cujomalainey approved these changes Jun 16, 2023
View reviewed changes

Uh oh!

Conversation

ShriramShastry commented Dec 14, 2022• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

lgirdwood left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ShriramShastryDec 26, 2022• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

ShriramShastry left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ShriramShastryDec 26, 2022• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

lgirdwood commented Jan 4, 2023

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

kv2019i left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

ShriramShastry commented Jun 12, 2023

Uh oh!

ShriramShastry commented Jun 12, 2023

Uh oh!

kv2019i left a comment

Choose a reason for hiding this comment

Uh oh!

ShriramShastry commented Jun 14, 2023

Uh oh!

kv2019i commented Jun 14, 2023

Uh oh!

cujomalainey commented Jun 14, 2023

Uh oh!

cujomalainey commented Jun 15, 2023

Uh oh!

ShriramShastry commented Jun 15, 2023

Uh oh!

Reviewers

ShriramShastry commented Dec 14, 2022•
edited
Loading

ShriramShastryDec 26, 2022•
edited
Loading

ShriramShastryDec 26, 2022•
edited
Loading