sof-logger: print error if -u uart option is given with no infile

[kv2019i]

sof-logger -u 115200 -d /lib/firmware/sof-foo.ldc

Leads to silent failure as a NULL is passed to open(). Add explicit error handling for this case.

Signed-off-by: Kai Vehmanen kai.vehmanen@linux.intel.com

[paulstelian97]

I'm surprised this is in here in the first place. There may be another place to check this but here is good too and should be no issue.

[paulstelian97]

Oh actually maybe a warning that e.g. the uart isn't used and the regular etrace/DMA trace file is being read instead could be good? Since you're not aborting the program...

[marc-hb]

Suggested change

	fprintf(stderr, "error: Input file not specified with -u option\n");
	fprintf(stderr, "error: Input file not specified with -i option\n");

[marc-hb]

@kv2019i you thumbed up my comment and resolved it but made no change.

PS: thanks to eagle-eyed @ranj063 for spotting this.

Maybe even better:

Suggested change

	fprintf(stderr, "error: Input file not specified with -u option\n");
	fprintf(stderr, "error: Input device not specified with -i option\n");

[kv2019i]

@marc-hb Sorry, I didn't you had a different issue. Ok, I'll rephrase that message.

[kv2019i]

@paulstelian97 wrote:

Oh actually maybe a warning that e.g. the uart isn't used and the regular etrace/DMA trace file is being read
instead could be good? Since you're not aborting the program...

....a bit of surprise (to me as well), but usage() actually calls exit, so the program does exit here.

[marc-hb]

@kv2019i you thumbed up my comment and resolved it but made no change.

PS: thanks to eagle-eyed @ranj063 for spotting this.

Maybe even better:

Suggested change

	fprintf(stderr, "error: Input file not specified with -u option\n");
	fprintf(stderr, "error: Input device not specified with -i option\n");

[kv2019i]

@marc-hb Now updated.