Uh oh!
There was an error while loading. Please reload this page.
cherry-pick: dts: code update for library 1.0.7 and newer - #6859
Closed
johnylin76 wants to merge 2 commits into
Closed
cherry-pick: dts: code update for library 1.0.7 and newer#6859johnylin76 wants to merge 2 commits into
johnylin76 wants to merge 2 commits into
Conversation
1. Add a free memory function to support PR#6230 and PR#6331, the latest prepare/reset API flow update of module_adapter. 2. This requires DTS library v1.0.7 to support this change. Signed-off-by: Joe.Cheng <joe.cheng@xperi.com> (cherry picked from commit a26f83c) Signed-off-by: Pin-chih Lin <johnylin@google.com>
1. Remove totalBufferLengthInBytes as it's handled by SDK internally now. 2. Add debug log to print config size Signed-off-by: Joe.Cheng <joe.cheng@xperi.com> (cherry picked from commit 33cd4ce)
johnylin76
requested review from
dbaluta, lbetlej, lgirdwood, mmaka1 and plbossart
as code ownersDecember 20, 2022 14:10
lgirdwood
approved these changes
Dec 20, 2022
lgirdwood
left a comment
Member
There was a problem hiding this comment.
@thesofproject/mediatek pls review and merge. ICI does not run on all production branches, hence there will be some failures/pendings.
yaochunhung
approved these changes
Dec 21, 2022
| unsigned int alignment); | ||
| void *pMemoryAllocationContext, | ||
| unsigned int length, | ||
| unsigned int alignment); |
Contributor
There was a problem hiding this comment.
It looks like wrong alignment but since it is a cherry-pick patch so may be fixed in another/next patch. Thanks
| DtsSofInterfaceInst **ppInst, | ||
| DtsSofInterfaceAllocateMemory pMemoryAllocationFn, | ||
| DtsSofInterfaceFreeMemory pMemoryFreeFn, | ||
| void *MemoryAllocationContext) DTS_SOF_INTERFACE_NOEXCEPT; |
kuanhsuncheng
approved these changes
Dec 21, 2022
johnylin76
commented
Dec 21, 2022
ContributorAuthor
duplicated as #6750 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Minor modification is made due to module_adapter-->codec_adapter conversion
@joechengxperi please help to review
@Zames-Chang for viz