Add Smart amp feedback pipeline in nocodec topology by ranj063 · Pull Request #6996 · thesofproject/sof

ranj063 · 2023-01-27T04:22:01Z

This is a replacement for #6799 and depends on the kernel PR thesofproject/linux#4160

ujfalusi · 2023-01-30T09:47:59Z

value of 0 as index is valid? As far as I know the pin0 format is derived from the generic base format, so index = 0 is ignored.

thats right pin 0 will be ignored. Now changed the min to 1

kv2019i

Looks good. I'll wait until other folks working on this area are good with this. @aiChaoSONG @ujfalusi @libinyang ....

kv2019i · 2023-01-30T10:53:46Z

-payload_with_output_fmt 901
+ # The token init_payload_format is used to describe the
+ # module instance initialization payload format
+init_payload_format 901


Allowing for multiple types of init payload is something we seem to need, so this seems more practical approach. It would be nice to have a pointer where the enumerated options are documented. This PR now defines "1".

Yes, fixed now.

ujfalusi · 2023-01-30T11:16:57Z

Note that the abi header is going to change to match with the sof_abi_hdr

ranj063 · 2023-01-30T20:53:15Z

Same comment as the kernel PR. The audio formats in the current tplg's need to be reworked to make them extensible for multiple input/output pins. This PR needs to wait until that is done.

The micsel will need to use the base config extension and the init config type will need to be set in the manifest. Signed-off-by: Ranjani Sridharan <ranjani.sridharan@linux.intel.com>

This patch adds the widget class for smart_amp module Signed-off-by: Chao Song <chao.song@linux.intel.com> Signed-off-by: Ranjani Sridharan <ranjani.sridharan@linux.intel.com>

This patch adds mixout-gain-smart-amp-dai-copier-playback pipeline. Signed-off-by: Chao Song <chao.song@linux.intel.com> Signed-off-by: Ranjani Sridharan <ranjani.sridharan@linux.intel.com>

plbossart

I didn't see anything that would look wrong but my understanding of topology isn't exactly stellar.

ranj063 · 2023-02-08T22:34:45Z

Please don't merge this before the rimage and kernel dependencies are merged

Use mixout-gain-smart-amp-dai-copier-playback pipeline for SSP0 DAI playback. Signed-off-by: Chao Song <chao.song@linux.intel.com> Signed-off-by: Ranjani Sridharan <ranjani.sridharan@linux.intel.com>

ranj063 · 2023-02-09T23:05:59Z

SOFCI TEST

mengdonglin · 2023-02-13T02:57:39Z

SOFCI TEST

@ranj063 It seems the kernel and rimage dependencies all got merged. So we only need to fix the CI failure, right?

@aiChaoSONG Can you please check if we have observed the same error in local test?

kv2019i · 2023-02-13T11:55:56Z

This depends on #7069

ranj063 · 2023-02-14T16:34:55Z

SOFCI TEST

ranj063 · 2023-02-14T18:14:49Z

SOFCI TEST

ranj063 · 2023-02-14T23:57:12Z

SOFCI TEST

kv2019i · 2023-02-15T16:47:00Z

Removed DNM prefix after #7099 and #7100 merged. Proceeding with merge.

ranj063 force-pushed the pr6799 branch from ab3423a to d4d63f5Compare January 27, 2023 04:23

lgirdwood reviewed Jan 27, 2023
View reviewed changes

Comment threadtools/topology/topology2/cavs-nocodec.conf Outdated

ranj063 mentioned this pull request Jan 28, 2023
Add Base config extension support for processing modules in IPC4 thesofproject/linux#4160
Merged

ranj063 marked this pull request as ready for review January 28, 2023 08:39

ranj063 requested review from dbaluta, lbetlej, mmaka1 and plbossart as code owners January 28, 2023 08:39

ranj063 force-pushed the pr6799 branch 2 times, most recently from 7209ba2 to 4f96ad9Compare January 30, 2023 06:30

ujfalusi reviewed Jan 30, 2023
View reviewed changes

kv2019i reviewed Jan 30, 2023
View reviewed changes

ujfalusi reviewed Jan 30, 2023
View reviewed changes

ranj063 force-pushed the pr6799 branch 2 times, most recently from 7fd7670 to 2aaf250Compare January 30, 2023 16:40

ranj063 requested a review from aiChaoSONG January 30, 2023 17:05

ranj063 force-pushed the pr6799 branch from 2aaf250 to 7ebd0b2Compare January 30, 2023 17:16

ranj063 marked this pull request as draft January 30, 2023 20:53

ranj063 force-pushed the pr6799 branch 6 times, most recently from ec8ffc4 to 7c084ceCompare February 3, 2023 07:22

ujfalusi reviewed Feb 3, 2023
View reviewed changes

Comment threadtools/topology/topology2/include/components/smart_amp.conf Outdated

aiChaoSONG mentioned this pull request Feb 7, 2023
samples: convert smart amp test module to not expect the blob during init with IPC4 #7042
Merged

ranj063 force-pushed the pr6799 branch 3 times, most recently from 9f06156 to 5abbb6aCompare February 8, 2023 01:05

ranj063 marked this pull request as ready for review February 8, 2023 15:56

ranj063 requested review from kv2019i and ujfalusi February 8, 2023 15:56

ranj063 force-pushed the pr6799 branch from b1b2340 to b744ca6Compare February 8, 2023 18:37

ranj063and others added 3 commits February 8, 2023 11:15

topology2: tokens: Remove the payload_with_output_format token
4c5880a
The micsel will need to use the base config extension and the init config type will need to be set in the manifest. Signed-off-by: Ranjani Sridharan <ranjani.sridharan@linux.intel.com>

Topology2: add smart_amp widget class
b813414
This patch adds the widget class for smart_amp module Signed-off-by: Chao Song <chao.song@linux.intel.com> Signed-off-by: Ranjani Sridharan <ranjani.sridharan@linux.intel.com>

Topology2: add mixout-gain-smart-amp-dai-copier-playback pipeline
26fcfb0
This patch adds mixout-gain-smart-amp-dai-copier-playback pipeline. Signed-off-by: Chao Song <chao.song@linux.intel.com> Signed-off-by: Ranjani Sridharan <ranjani.sridharan@linux.intel.com>

ranj063 force-pushed the pr6799 branch from b744ca6 to 9e92fc9Compare February 8, 2023 19:23

plbossart approved these changes Feb 8, 2023
View reviewed changes

Topology2: add smart amp pipeline in nocodec topology
10c7ff5
Use mixout-gain-smart-amp-dai-copier-playback pipeline for SSP0 DAI playback. Signed-off-by: Chao Song <chao.song@linux.intel.com> Signed-off-by: Ranjani Sridharan <ranjani.sridharan@linux.intel.com>

ranj063 force-pushed the pr6799 branch from 9e92fc9 to 10c7ff5Compare February 9, 2023 00:07

aiChaoSONG mentioned this pull request Feb 9, 2023
Topology2: add smart amp nocodec test topology #6799
Closed

lgirdwood changed the title ~~Add Smart amp feedback pipeline in nocodec topology~~[DNM] Add Smart amp feedback pipeline in nocodec topologyFeb 9, 2023

lgirdwood approved these changes Feb 9, 2023
View reviewed changes

ranj063 changed the title ~~[DNM] Add Smart amp feedback pipeline in nocodec topology~~Add Smart amp feedback pipeline in nocodec topologyFeb 14, 2023

ranj063 changed the title ~~Add Smart amp feedback pipeline in nocodec topology~~[DNM] Add Smart amp feedback pipeline in nocodec topologyFeb 15, 2023

This was referenced Feb 15, 2023
Fix pipeline source/sink component discovery and smart_amp_test #7099
Merged
smart_amp_test: Correct bytes calculations for processing #7100
Merged

kv2019i changed the title ~~[DNM] Add Smart amp feedback pipeline in nocodec topology~~Add Smart amp feedback pipeline in nocodec topologyFeb 15, 2023

kv2019i merged commit 2f29bc3 into thesofproject:mainFeb 15, 2023

ranj063 deleted the pr6799 branch February 15, 2023 16:50

lyakh mentioned this pull request Feb 16, 2023
[BUG] ipc timed out for 0x13000004|0x1 GLB_SET_PIPELINE_STATE on IPC4 NOCODEC and SDW platforms #6864
Closed

Uh oh!

Conversation

ranj063 commented Jan 27, 2023• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

ujfalusiJan 30, 2023

Choose a reason for hiding this comment

Uh oh!

ranj063Jan 30, 2023

Choose a reason for hiding this comment

Uh oh!

kv2019i left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

kv2019iJan 30, 2023

Choose a reason for hiding this comment

Uh oh!

ranj063Jan 30, 2023

Choose a reason for hiding this comment

Uh oh!

ujfalusiJan 30, 2023

Choose a reason for hiding this comment

Uh oh!

ranj063 commented Jan 30, 2023

Uh oh!

Uh oh!

plbossart left a comment

Choose a reason for hiding this comment

Uh oh!

ranj063 commented Feb 8, 2023

Uh oh!

ranj063 commented Feb 9, 2023

Uh oh!

mengdonglin commented Feb 13, 2023

Uh oh!

kv2019i commented Feb 13, 2023

Uh oh!

ranj063 commented Feb 14, 2023

Uh oh!

ranj063 commented Feb 14, 2023

Uh oh!

ranj063 commented Feb 14, 2023

Uh oh!

kv2019i commented Feb 15, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

ranj063 commented Jan 27, 2023•
edited
Loading