Skip to content

Fixed warnings issued by new xt-clang compiler#7096

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kv2019i merged 1 commit into from
Feb 17, 2023
Merged

Fixed warnings issued by new xt-clang compiler #7096

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions src/audio/selector/selector.c
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -579,14 +579,12 @@ static void build_config(struct comp_data *cd, struct module_config *cfg)
enum sof_ipc_frame __sparse_cache frame_fmt, valid_fmt;
int i;

frame_fmt = cfg->base_cfg.audio_fmt.depth;
audio_stream_fmt_conversion(cfg->base_cfg.audio_fmt.depth,
cfg->base_cfg.audio_fmt.valid_bit_depth,
&frame_fmt, &valid_fmt,
cfg->base_cfg.audio_fmt.s_type);
cd->source_format = frame_fmt;

frame_fmt = cd->sink_format;

@marc-hbmarc-hbFeb 17, 2023

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this file be in a separate commit?

@marc-hbmarc-hbFeb 17, 2023

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even if it's not a functional change, it very much looks like one.

@aborisovichaborisovichFeb 17, 2023

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's focus on what it actually is and not what it looks to be. As some people say "don't judge the book by the cover" :-)

@kv2019ikv2019iFeb 17, 2023

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aborisovich You do need to explain this in the git commit in some way why is it ok to remove these two lines. This is not unheard of to have code that doesn't do anything, but expectation is that you explain in commit to explain why this is the case.

@aborisovichaborisovichFeb 17, 2023

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok sure, I'll add some proper message

audio_stream_fmt_conversion(cd->output_format.depth,
cd->output_format.valid_bit_depth,
&frame_fmt, &valid_fmt,
Expand Down
9 changes: 9 additions & 0 deletions src/include/sof/audio/module_adapter/iadk/system_service.h
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -13,6 +13,11 @@

#include <stdint.h>

#ifdef __clang__
#pragma clang diagnostic push
#pragma clang diagnostic ignored "-Wextern-c-compat"
#endif //__clang__

#ifdef __cplusplus
extern "C" {
#endif
Expand DownExpand Up@@ -233,4 +238,8 @@ struct SystemService : public AdspSystemService {};
}
#endif

#ifdef __clang__
#pragma clang diagnostic pop // ignored "-Wextern-c-compat"
#endif //__clang__

#endif /* _ADSP_SYSTEM_SERVICE_H_ */