Skip to content

common.h: Prevent error when compiling with Clang - #7411

Merged
kv2019i merged 1 commit into
thesofproject:mainfrom
nishalkulkarni:clang_fixes
Apr 25, 2023
Merged

common.h: Prevent error when compiling with Clang#7411
kv2019i merged 1 commit into
thesofproject:mainfrom
nishalkulkarni:clang_fixes

Conversation

@nishalkulkarni

@nishalkulkarninishalkulkarni commented Apr 6, 2023

Copy link
Copy Markdown
Contributor

Clang requires fields to have a constant size and does not support variable length array in structure causing build to to fail at compile_check()

error: fields must have a constant size: 'variable length array in structure' extension will never be supported

This change selects the compatible version of ALIGN_UP and ALIGN_DOWN macro when compiling with Clang.

While there's no official support for LLVM toolchain right now, this change should help in that direction.

@nishalkulkarni
common.h: Prevent error when compiling with Clang
a6dee9f
Clang requires fields to have a constant size and does not
support variable length array in structure causing build to
to fail at compile_check()
This change selects the compatible version of ALIGN_UP and
ALIGN_DOWN macro when compiling with Clang.
Signed-off-by: Nishal Kulkarni <nishalkulkarni@gmail.com>
@sofci

sofci commented Apr 6, 2023

Copy link
Copy Markdown
Collaborator

Can one of the admins verify this patch?

reply test this please to run this test once

@sys-pt1s

sys-pt1s commented Apr 6, 2023

Copy link
Copy Markdown

Can one of the admins verify this patch?

@lgirdwood

This comment was marked as outdated.

Sign in to view
@lgirdwood

lgirdwood commented Apr 6, 2023

Copy link
Copy Markdown
Member

test this please

@kv2019i

kv2019i commented Apr 12, 2023

Copy link
Copy Markdown
Collaborator

@wszypelt This one got stuck as well.

@lgirdwood

lgirdwood commented Apr 24, 2023

Copy link
Copy Markdown
Member

@wszypelt@lrudyX good to merge ?

@wszypelt

wszypelt commented Apr 25, 2023

Copy link
Copy Markdown

@lgirdwood good to merge

@kv2019i

kv2019i commented Apr 25, 2023

Copy link
Copy Markdown
Collaborator

Test infra issue in https://sof-ci.01.org/sofpr/PR7411/build5584/devicetest/index.html , not blocking this PR.

@kv2019i
kv2019i merged commit c8253af into thesofproject:mainApr 25, 2023
@marc-hb

marc-hb commented Apr 26, 2023•
edited
Loading

Copy link
Copy Markdown
Collaborator

Which clang version does this solve a problem with? We've been routinely using xt-clang for a while now and this has never been an issue: https://sof-ci.01.org/sofpr/PR7411/build5583/build/mtl_zph_ipc4.txt

-- The C compiler identification is Clang 10.0.1
-- The CXX compiler identification is Clang 10.0.1

@marc-hb

marc-hb commented Apr 26, 2023•
edited
Loading

Copy link
Copy Markdown
Collaborator

Oh wait, I suspect xt-clang defines BOTH __XCC__ and __clang__, that would explain why we didn't hit this issue.

@dcpleung should this be changed to ! GCC or something?

More background:

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@paulstelian97paulstelian97paulstelian97 approved these changes
@lgirdwoodlgirdwoodlgirdwood approved these changes
@kv2019ikv2019ikv2019i approved these changes
@plbossartplbossartAwaiting requested review from plbossartplbossart is a code owner
@mmaka1mmaka1Awaiting requested review from mmaka1mmaka1 is a code owner
@lbetlejlbetlejAwaiting requested review from lbetlejlbetlej is a code owner
@dbalutadbalutaAwaiting requested review from dbalutadbaluta is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@nishalkulkarni@sofci@sys-pt1s@lgirdwood@kv2019i@wszypelt@marc-hb@paulstelian97