[SKIP CI] parse_sparse_output.sh: add "removes address space" and "too many"

[marc-hb]

Catch the additional two warnings below:

warning: too many warnings
warning: cast removes address space

[marc-hb]

This is unhiding the following warnings:
https://github.com/thesofproject/sof/actions/runs/4761818377/jobs/8463408808?pr=7488

/zep_workspace/zephyr/drivers/dai/intel/ssp/ssp.c:2084:17: warning: too many warnings
/zep_workspace/sof/zephyr/../src/include/sof/audio/component.h:826:9: warning: too many warnings
/zep_workspace/sof/src/audio/src/src.c:977:21: warning: cast removes address space '__cache' of expression
/zep_workspace/sof/src/audio/src/src.c:977:18: warning: incorrect type in assignment (different address spaces)
/zep_workspace/sof/src/audio/src/src.c:978:19: warning: cast removes address space '__cache' of expression
/zep_workspace/sof/src/audio/src/src.c:978:16: warning: incorrect type in assignment (different address spaces)
/zep_workspace/sof/src/lib/ams.c:61:29: warning: cast removes address space '__cache' of expression
/zep_workspace/sof/src/lib/ams.c:68:44: warning: cast removes address space '__cache' of expression
/zep_workspace/sof/src/lib/ams.c:288:41: warning: cast removes address space '__cache' of expression

EDIT: src. fixes submitted in #7492

[paulstelian97]

Worth having enabled. That said are those warnings useful on current platforms, or just good for the purpose of porting to new ones?

[marc-hb]

According to @lyakh (please correct me) these two warnings should have always been caught from the beginning, this was a miss. This is not checking something new.

[marc-hb]

After #7492 was merged the list got smaller in https://github.com/thesofproject/sof/actions/runs/4769307682/jobs/8479546182?pr=7488

/zep_workspace/zephyr/drivers/dai/intel/ssp/ssp.c:2084:17: warning: too many warnings
/zep_workspace/sof/zephyr/../src/include/sof/audio/component.h:826:9: warning: too many warnings
/zep_workspace/sof/src/lib/ams.c:61:29: warning: cast removes address space '__cache' of expression
/zep_workspace/sof/src/lib/ams.c:68:44: warning: cast removes address space '__cache' of expression
/zep_workspace/sof/src/lib/ams.c:288:41: warning: cast removes address space '__cache' of expression

EDIT: --cmake-args=-DCONFIG_AMS=n gets rid of the ams.c warnings. Only for sparse, in the short term? @lyakh ?

[lyakh]

EDIT: --cmake-args=-DCONFIG_AMS=n gets rid of the ams.c warnings. Only for sparse, in the short term? @lyakh ?

I'd rather fix AMS - IIUC it's supposed to be a rather central common functionality, included by default in most builds

[lyakh]

/zep_workspace/zephyr/drivers/dai/intel/ssp/ssp.c:2084:17: warning: too many warnings
/zep_workspace/sof/zephyr/../src/include/sof/audio/component.h:826:9: warning: too many warnings

@marc-hb I don't see these warnings in the logs, that you've linked?
UPDATE: found them in https://github.com/thesofproject/sof/actions/runs/4769307682/jobs/8479546253?pr=7488 - one of them should be fixed by zephyrproject-rtos/zephyr#56972 as for the one in component.h - I see where the warning comes from, and we could silence it by making the data array in struct sof_abi_hdr of size 0 instead of flexible, as we've done in multiple other locations. Still I'm not sure how that single warning gets multiplied to "too many"

[marc-hb]

@marc-hb I don't see these warnings in the logs, that you've linked?

They were probably in MTL while I linked to TGL or vice-versa.

[marc-hb]

Only the 3 AMS warnings left in https://github.com/thesofproject/sof/actions/runs/4789322954/jobs/8517045526?pr=7488 after the big zephyr upgrade #6480! \o/

EDIT: AMS just fixed in #7501

[marc-hb]

Green sparse log in https://github.com/thesofproject/sof/actions/runs/4791424286/jobs/8521820464?pr=7488

Thanks @lyakh !

Can we merge this quickly before someone adds a new sparse regression? :-)

Ooops: re-requested @lyakh 's review and lost his approval by accident. It's still above on April 23.

https://sof-ci.01.org/sof-pr-viewer/#/build/PR7488/build11882024 is red but this PR is a pure SPARSE filter change, totally unrelated.

[kv2019i]

The CI failures are unrelated as this PR only changes the sparse script, proceeding with merge.

[marc-hb]

as for the one in component.h - I see where the warning comes from, and we could silence it by making the data array in struct sof_abi_hdr of size 0 instead of flexible, as we've done in multiple other locations.

Actually the warning in component.h is on this (the comment rang a bell, then git blame pointed it at... me)

/* Flexible array members[] are forbidden in unions but this * does not seem to bother gcc as long as non-standard * zero-length arrays[0] are used instead. Nesting flexible * array member declarations in arrays or structures is * forbidden too. Cleaning this up would likely require code * changes to explicitly cast intermediate steps. *//* control data - add new types if needed */union {
/* channel values can be used by volume type controls */structsof_ipc_ctrl_value_chanchanv[0];
/* component values used by routing controls like mux, mixer */structsof_ipc_ctrl_value_compcompv[0];
/* data can be used by binary controls */structsof_abi_hdrdata[0];
};