Skip to content

cmocka fixes for native host target - #750

Merged
lgirdwood merged 2 commits into
masterfrom
lrg/topic/cmocka
Dec 19, 2018
Merged

cmocka fixes for native host target#750
lgirdwood merged 2 commits into
masterfrom
lrg/topic/cmocka

Conversation

@lgirdwood

@lgirdwoodlgirdwood commented Dec 18, 2018

Copy link
Copy Markdown
Member

Update cmocka UT for new comp cmd API update and get cmocka working on host test bench.

@lrgirdwo
cmocka: update component cmd API to new convention.
49562e8
Signed-off-by: Liam Girdwood <liam.r.girdwood@linux.intel.com>
@lrgirdwo
cmocka: host: Make sure cmocka builds and runs for host test bench
35588cc
Fix some build issues with cmocka for host test bench target so that
cmocka UTs can run native on host architecture. This makes it easy for
users to update UTs when APIs change as they dont need architecture
specific version of cmocka.
Signed-off-by: Liam Girdwood <liam.r.girdwood@linux.intel.com>
@lgirdwood

lgirdwood commented Dec 18, 2018•
edited
Loading

Copy link
Copy Markdown
MemberAuthor

@mwierzbix@akloniex there are some updates to pre-processing and trace items in here, please make sure this is fine for host targets.

@lgirdwoodlgirdwood changed the title cmocka updatescmocka fixes for native host targetDec 18, 2018
@lgirdwood

lgirdwood commented Dec 18, 2018

Copy link
Copy Markdown
MemberAuthor

@jajanusz most tests pass, but some processing component tests fail. These can be fixed to pass after merge, but we probably want to check if there is any difference between native host and xtensa UT results.

@jajanusz

jajanusz commented Dec 18, 2018•
edited
Loading

Copy link
Copy Markdown
Contributor

@lgirdwood
UTs has been developed with xtensa arch in mind, so someone will have to update what can run on host to run on host and what needs xt simulator should be wrapped in if BUILD_XTENSA. For now just to make it all running again I'll wrap all tests that fail on host with if BUILD_XTENSA and later someone can update UTs for host. I don't like how UTs are done now and I'd like to do it in different way with kbuild, so I'd not invest too much time into fixing UTs now.

There are still some issues for xtensa UTs caused by #730, I'll fix them after this one is merged.

@jajanusz

jajanusz commented Dec 18, 2018

Copy link
Copy Markdown
Contributor

@lgirdwood
Now I see you fixed issue with #730, but xtensa UTs still fail because of #698 changes. I can fix it anyway

@mengdonglin

mengdonglin commented Dec 19, 2018•
edited
Loading

Copy link
Copy Markdown
Collaborator

@lgirdwood Would you please merge this PR? Firmware team will cherry pick it to GLK release branch glk-005-drop-stable.

@lgirdwood
lgirdwood merged commit 699321e into masterDec 19, 2018
@lgirdwoodlgirdwood mentioned this pull request Dec 19, 2018
Closed
@jajanuszjajanusz mentioned this pull request Dec 20, 2018
Merged
@lgirdwood
lgirdwood deleted the lrg/topic/cmocka branch September 12, 2019 16:14
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lbetlejlbetlejAwaiting requested review from lbetlej
@libinyanglibinyangAwaiting requested review from libinyang
@mmaka1mmaka1Awaiting requested review from mmaka1
@plbossartplbossartAwaiting requested review from plbossart
@ranj063ranj063Awaiting requested review from ranj063
@xiulipanxiulipanAwaiting requested review from xiulipan
@mwierzbixmwierzbixAwaiting requested review from mwierzbix
@akloniexakloniexAwaiting requested review from akloniex
1 more reviewer
@jajanuszjajanuszjajanusz approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@lgirdwood@jajanusz@mengdonglin@lrgirdwo