Skip to content

[Ipc4] add fw panic notification support - #7597

Merged
kv2019i merged 2 commits into
thesofproject:mainfrom
RanderWang:ipc4-fw-panic
May 23, 2023
Merged

[Ipc4] add fw panic notification support#7597
kv2019i merged 2 commits into
thesofproject:mainfrom
RanderWang:ipc4-fw-panic

Conversation

@RanderWang

@RanderWangRanderWang commented May 12, 2023

Copy link
Copy Markdown
Collaborator

Send fw panic notification message to host.

@RanderWangRanderWang mentioned this pull request May 12, 2023
Closed
@RanderWang
RanderWangforce-pushed the ipc4-fw-panic branch 5 times, most recently from 4cd46d9 to 12793beCompareMay 12, 2023 09:19
@RanderWang
RanderWangforce-pushed the ipc4-fw-panic branch 4 times, most recently from 9ce86bb to 1d59283CompareMay 15, 2023 05:00
lyakh
lyakh reviewed May 15, 2023
View reviewed changes
Comment threadsrc/ipc/ipc-common.c Outdated
Comment threadsrc/ipc/ipc4/handler.c Outdated
Comment threadsrc/ipc/ipc4/handler.c Outdated
btian1
btian1 reviewed May 15, 2023
View reviewed changes
Comment threadsrc/platform/library/include/platform/platform.h Outdated
kv2019i
kv2019i reviewed May 15, 2023
View reviewed changes

@kv2019ikv2019i left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @RanderWang for taking this forward. Some comments inline.

Comment threadsrc/drivers/amd/rembrandt/ipc.c Outdated
Comment threadsrc/ipc/ipc4/handler.c Outdated
@RanderWang
RanderWangforce-pushed the ipc4-fw-panic branch 2 times, most recently from b2dd14d to 38ead98CompareMay 15, 2023 09:00
lyakh
lyakh reviewed May 16, 2023
View reviewed changes
Comment threadsrc/ipc/ipc-common.c Outdated
kv2019i added 2 commits May 16, 2023 16:54
@kv2019i@RanderWang
ipc: add ipc_msg_send_direct support
ee05e96
For emergency like FW panic event, we need to send notification IPC
message to host directly without inserting this message in msg_list
since at this time the system is not stable now and it is very possible
that the normal message processing logic can't work.
Signed-off-by: Kai Vehmanen <kai.vehmanen@linux.intel.com>
Signed-off-by: Rander Wang <rander.wang@intel.com>
Co-developed-by: Rander Wang <rander.wang@intel.com>
@kv2019i@RanderWang
ipc4 : send panic on Zephyr OS panic
076cf68
Send panic notification message to host when panic happens. The panic
detail is built by Zephyr framework and included in debug memory window.
Signed-off-by: Kai Vehmanen <kai.vehmanen@linux.intel.com>
Signed-off-by: Rander Wang <rander.wang@intel.com>
Co-developed-by: Rander Wang <rander.wang@intel.com>
kv2019i
kv2019i approved these changes May 16, 2023
View reviewed changes

@kv2019ikv2019i left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @RanderWang !

@kv2019i

kv2019i commented May 23, 2023

Copy link
Copy Markdown
Collaborator

Known fails in Intel device tests https://sof-ci.01.org/sofpr/PR7597/build7839/devicetest/index.htmlhttps://sof-ci.01.org/sofpr/PR7597/build7838/devicetest/index.html . Zephyr upstream fails are known as well. Checkpatch warning we can live with. Proceeding with merge.

@kv2019i
kv2019i merged commit 9ea2f05 into thesofproject:mainMay 23, 2023
@aborisovichaborisovich mentioned this pull request Jun 27, 2023
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lyakhlyakhlyakh left review comments
@btian1btian1btian1 left review comments
@kv2019ikv2019ikv2019i approved these changes
@tmlemantmlemantmleman approved these changes
@iuliana-prodaniuliana-prodanAwaiting requested review from iuliana-prodaniuliana-prodan is a code owner
@dbalutadbalutaAwaiting requested review from dbalutadbaluta is a code owner
@abonislawskiabonislawskiAwaiting requested review from abonislawskiabonislawski is a code owner
@bardliaobardliaoAwaiting requested review from bardliaobardliao is a code owner
@marcinszkudlinskimarcinszkudlinskiAwaiting requested review from marcinszkudlinski
@pblaszkopblaszkoAwaiting requested review from pblaszkopblaszko is a code owner
@aborisovichaborisovichAwaiting requested review from aborisovich
@lgirdwoodlgirdwoodAwaiting requested review from lgirdwoodlgirdwood is a code owner
@plbossartplbossartAwaiting requested review from plbossartplbossart is a code owner
@mmaka1mmaka1Awaiting requested review from mmaka1mmaka1 is a code owner
@lbetlejlbetlejAwaiting requested review from lbetlejlbetlej is a code owner
@yaochunhungyaochunhungAwaiting requested review from yaochunhungyaochunhung is a code owner
@kuanhsunchengkuanhsunchengAwaiting requested review from kuanhsunchengkuanhsuncheng is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@RanderWang@kv2019i@lyakh@btian1@tmleman