Uh oh!
There was an error while loading. Please reload this page.
dai-zephyr: do not set local buffer if no process func found - #7690
dai-zephyr: do not set local buffer if no process func found#7690kv2019i wants to merge 1 commit into
Conversation
kv2019i
commented
May 25, 2023
Not sure @lyakh this helps much, but we do avoid one extra dd->local_buffer write. |
juimonen
left a comment
There was a problem hiding this comment.
not sure I understand the optimization, but looks innocent enough to me
lyakh
left a comment
There was a problem hiding this comment.
looks good, thanks for fixing it! But need to fix one hick up.
Uh oh!
There was an error while loading. Please reload this page.
lyakh
commented
May 26, 2023
@kv2019i@juimonen Given two possibilities: and as long as the order indeed isn't important - often both will work correctly, but I think one is clearly preferable over the other and should be used whenever possible. |
Uh oh!
There was an error while loading. Please reload this page.
Rework set_new_local_buffer() to not set dd->local_buffer multiple times. Also remove erroneous __sparse_cache attribute for "local_buf". Signed-off-by: Kai Vehmanen <kai.vehmanen@linux.intel.com>
55ceca3 to
1ac1ea1Comparekv2019i
commented
Jun 5, 2023
V2 uploaded, please review. |
kv2019i
commented
Jun 6, 2023
The Intel CI System/merge/build fails to one run of "TestSrcFullScope::test_01_04_src" indicating a glitch on one platform. I don't think it can be related to this PR, but need to do another run to be sure. |
lgirdwood
commented
Jul 4, 2023
SOFCI TEST |
lgirdwood
commented
Jul 4, 2023
@kv2019i still failing CI, can you check. Thanks |
Rework set_new_local_buffer() to not set dd->local_buffer multiple times.