Skip to content

ipc3: helper: Do not silently accept unrecognized component type in IPC - #7948

Merged
kv2019i merged 1 commit into
thesofproject:mainfrom
jsarha:ipc3_msg_check
Jul 17, 2023
Merged

ipc3: helper: Do not silently accept unrecognized component type in IPC#7948
kv2019i merged 1 commit into
thesofproject:mainfrom
jsarha:ipc3_msg_check

Conversation

@jsarha

Copy link
Copy Markdown
Contributor

Return an error code from comp_specific_builder() if the component type is not recognized, instead of just silently ignoring the error.

@jsarha
jsarhaforce-pushed the ipc3_msg_check branch 2 times, most recently from 0c4c197 to c543af9CompareJuly 14, 2023 10:01
@jsarha
jsarha marked this pull request as ready for review July 14, 2023 10:01
Comment threadsrc/ipc/ipc3/helper.c Outdated
Return an error code from comp_specific_builder() if the component
type is not recognized, instead of just silently ignoring the error.
Signed-off-by: Jyri Sarha <jyri.sarha@linux.intel.com>
@lgirdwood

Copy link
Copy Markdown
Member

@wszypelt@lrudyX not expecting ipc3 fix to fail, good to merge ?

@lrudyX

Copy link
Copy Markdown

@wszypelt@lrudyX not expecting ipc3 fix to fail, good to merge ?

There was a problem with CI, several PRs are waiting for rerun.

@kv2019i
kv2019i merged commit 21ed10a into thesofproject:mainJul 17, 2023
@dbaluta

Copy link
Copy Markdown
Collaborator

@jsarha we get some problems with this patch when testing mixer on IPC3.

Looks like there is no case for mixer and it goes on default -EINVAL value. Please see comp_specific_builder.

We get this error:

[ 10468552.448600] ( 10468552.000000) c0 dma-trace src/trace/dma-trace.c:664 ERROR dtrace_add_event(): number of dropped logs = 13
[ 10495936.249596] ( 27383.800781) c0 dma-trace src/ipc/ipc3/helper.c:333 ERROR comp_new(): component type not recognized
[ 10496074.582923] ( 138.333328) c0 dma-trace src/ipc/ipc3/helper.c:660 ERROR ipc_comp_new(): component cd = NULL
[ 10496211.666251] ( 137.083328) c0 dma-trace src/ipc/ipc3/handler.c:1301 ERROR ipc: pipe 1 comp 0 creation failed -22

@lyakh

Copy link
Copy Markdown
Collaborator

@jsarha we get some problems with this patch when testing mixer on IPC3.

Looks like there is no case for mixer and it goes on default -EINVAL value. Please see comp_specific_builder.

@dbaluta would someone be submitting a PR to fix this?

@dbaluta

Copy link
Copy Markdown
Collaborator

@lyakh I am looking at this.

@dbaluta

Copy link
Copy Markdown
Collaborator

@lyakh sent this for review #7963

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

@jsarha@lgirdwood@lrudyX@dbaluta@lyakh@kv2019i