Uh oh!
There was an error while loading. Please reload this page.
west.yml: Update rimage revision to aa0ac9ea - #7974
Merged
Merged
Conversation
aborisovich
requested review from
dbaluta, lbetlej, lgirdwood, mmaka1 and plbossart
as code ownersJuly 24, 2023 08:22
pjdobrowolski
approved these changes
Jul 24, 2023
marcinszkudlinski
approved these changes
Jul 24, 2023
aborisovichforce-pushed
the
update-rimage-revision
branch
from
July 25, 2023 04:41
441b038 to
cd86f30Comparetmleman
approved these changes
Jul 25, 2023
ContributorAuthor
Any concerns with this PR? Can we merge @lrgirdwo? Bat scope results on Windows CI shows no regression. |
btian1
reviewed
Jul 26, 2023
btian1
left a comment
Contributor
There was a problem hiding this comment.
@aborisovich you can try to push again for SOFCI TEST.
aborisovichforce-pushed
the
update-rimage-revision
branch
from
July 26, 2023 07:51
cd86f30 to
c6fa097Comparemarcinszkudlinski
commented
Jul 26, 2023
Contributor
CI is failing because of #7985 |
lgirdwood
commented
Jul 26, 2023
Member
SOFCI TEST |
aborisovichforce-pushed
the
update-rimage-revision
branch
from
July 26, 2023 16:19
c6fa097 to
ff708d8ComparePull in following rimage changes: aa0ac9e rimage.c: fix bug where -p requires a new and ignored parameter Signed-off-by: Andrey Borisovich <andrey.borisovich@intel.com>
aborisovichforce-pushed
the
update-rimage-revision
branch
from
July 26, 2023 16:20
ff708d8 to
6d8edf6Comparelgirdwood
commented
Jul 27, 2023
Member
@aborisovich not sure why we would get a build failure in internal CI and not other CIs, can you check. @wszypelt@lrudyX false positive ? |
wszypelt
commented
Jul 27, 2023
@lgirdwood finally it worked, I'm a little worried that it failed twice on building, but now it's ok |
btian1
approved these changes
Jul 31, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull in following rimage changes:
aa0ac9e rimage.c: fix bug where -p requires a new and ignored parameter
Signed-off-by: Andrey Borisovich andrey.borisovich@intel.com