topology2: merge multi-core test into nocodec topology by RanderWang · Pull Request #8240 · thesofproject/sof

RanderWang · 2023-09-21T07:17:14Z

The multi-core topology was created since multi-core feature had a few bugs at that time so it was for validation test. Now this feature works fine so merge it into nocodec topology then it will be tested by github CI. And we don't need to maintain a dedicated multi-core topology.

ranj063 · 2023-09-21T13:49:43Z

 {
 index	6
 direction	playback
+ core_id $SSP2_PCM_CORE_ID


@RanderWang the suggested change is fine for the regular nocodec topology. But for the passthrough nocodec topology, I'd suggest to keep all core IDs as 0. @plbossart what do you think?

sure, I can image it. Removed.

lgirdwood · 2023-09-25T15:39:01Z

@RanderWang conflicts.

RanderWang · 2023-09-26T02:49:21Z

rebased, thanks

lgirdwood · 2023-09-26T12:52:14Z

@RanderWang are we still expecting some rough edges ?

2023-09-26 03:18:58 UTC [ERROR] Caught kernel log error
===========================>>
[ 317.740853] kernel: sof-audio-pci-intel-tgl 0000:00:1f.3: FW reported error: 6 - Unknown error while processing the request
[ 317.741220] kernel: sof-audio-pci-intel-tgl 0000:00:1f.3: ipc error for msg 0x47000000|0x0
[ 317.741236] kernel: sof-audio-pci-intel-tgl 0000:00:1f.3: error: failed to disable target core: 2 for widget pipeline.6
[ 317.741249] kernel: sof-audio-pci-intel-tgl 0000:00:1f.3: Failed to free connected widgets
[ 317.741276] kernel: sof-audio-pci-intel-tgl 0000:00:1f.3: ASoC: error at snd_soc_pcm_component_hw_free on 0000:00:1f.3: -22

RanderWang · 2023-09-27T02:51:43Z

@RanderWang are we still expecting some rough edges ?

2023-09-26 03:18:58 UTC [ERROR] Caught kernel log error
===========================>>
[ 317.740853] kernel: sof-audio-pci-intel-tgl 0000:00:1f.3: FW reported error: 6 - Unknown error while processing the request
[ 317.741220] kernel: sof-audio-pci-intel-tgl 0000:00:1f.3: ipc error for msg 0x47000000|0x0
[ 317.741236] kernel: sof-audio-pci-intel-tgl 0000:00:1f.3: error: failed to disable target core: 2 for widget pipeline.6
[ 317.741249] kernel: sof-audio-pci-intel-tgl 0000:00:1f.3: Failed to free connected widgets
[ 317.741276] kernel: sof-audio-pci-intel-tgl 0000:00:1f.3: ASoC: error at snd_soc_pcm_component_hw_free on 0000:00:1f.3: -22

We have a [BUG] [v2.7-rc1] IPC timed out for 0x47000000|MOD_SET_DX when suspending on ADLP_RVP_NOCODEC #8072. I will check this issue later since it has low priority

kv2019i · 2023-10-02T06:31:15Z

@RanderWang #8072 has low priority only because we haven't seen it in a long time (i.e. observed reproduction rate is low). The cases with this PR also look different. 8072 is an IPC timeout, but here we see IPC error response "FW reported error: 4 - The system or resource is busy".

kv2019i · 2023-10-18T10:31:20Z

ping @RanderWang ?

RanderWang · 2023-10-19T02:53:10Z

@kv2019i We get some issues with cavs platforms and I am debugging it

lgirdwood · 2023-10-23T13:42:23Z

@kv2019i We get some issues with cavs platforms and I am debugging it

Does the newest update resolve issues ?

RanderWang · 2023-10-24T06:44:58Z

@kv2019i We get some issues with cavs platforms and I am debugging it
Does the newest update resolve issues ?

I just rebased the code. It is a fw bug and I am still debugging it

RanderWang · 2023-10-25T13:25:16Z

SOFCI TEST

lgirdwood · 2023-10-25T15:59:16Z

@kv2019i We get some issues with cavs platforms and I am debugging it
Does the newest update resolve issues ?
I just rebased the code. It is a fw bug and I am still debugging it

Does the latest update resolve the issue ?

lyakh · 2023-10-26T06:10:49Z

 DECLARE_TR_CTX(power_tr, SOF_UUID(power_uuid), LOG_LEVEL_INFO);

 #if defined(CONFIG_PM_POLICY_CUSTOM)
+struct pm_state_info default_pm_state = {PM_STATE_ACTIVE, 0, 0};


const static

The multi-core topology was created since multi-core feature had a few bugs at that time so it was for validation test. Now this feature works fine so merge it into nocodec topology then it will be tested by github CI. And we don't need to maintain a dedicated multi-core topology. Signed-off-by: Rander Wang <rander.wang@intel.com>

kv2019i · 2023-11-10T10:33:26Z

Only single system PM fail now in https://sof-ci.01.org/sofpr/PR8240/build14811/devicetest/index.html , looks good to go.

RanderWang requested review from jsarha and ranj063 as code owners September 21, 2023 07:17

RanderWang requested review from keqiaozhang, kv2019i, lgirdwood and mengdonglin September 21, 2023 07:17

RanderWang force-pushed the multi-core-merge branch from 4d891fe to f3108f2Compare September 21, 2023 08:02

ranj063 reviewed Sep 21, 2023
View reviewed changes

RanderWang force-pushed the multi-core-merge branch from f3108f2 to dbb598dCompare September 22, 2023 01:26

ranj063 approved these changes Sep 22, 2023
View reviewed changes

lgirdwood approved these changes Sep 22, 2023
View reviewed changes

RanderWang force-pushed the multi-core-merge branch from dbb598d to a8023d0Compare September 26, 2023 02:46

RanderWang force-pushed the multi-core-merge branch from a8023d0 to 42c9f0eCompare October 19, 2023 01:08

RanderWang force-pushed the multi-core-merge branch 2 times, most recently from 4fccb54 to 432dbbaCompare October 23, 2023 05:39

RanderWang requested review from abonislawski, dbaluta, iuliana-prodan and lyakh as code owners October 25, 2023 07:53

RanderWang force-pushed the multi-core-merge branch from 867c9e3 to e62f19dCompare October 26, 2023 01:39

lyakh reviewed Oct 26, 2023
View reviewed changes

This was referenced Oct 26, 2023
mailbox: use uncached address to write sw regs #8398
Merged
soc: intel_adsp: cavs: don't enable interrupt before k_cpu_idle zephyrproject-rtos/zephyr#64541
Merged

RanderWang force-pushed the multi-core-merge branch from e62f19d to b913dfeCompare November 4, 2023 07:33

RanderWang requested review from lbetlej, mmaka1, plbossart and tmleman as code owners November 4, 2023 07:33

RanderWang force-pushed the multi-core-merge branch from b913dfe to 8011537Compare November 4, 2023 10:26

RanderWang mentioned this pull request Nov 6, 2023
[Depends on 62522] zephyr: cavs: add secondary core context save support #8185
Merged

lgirdwood added this to the v2.8 milestone Nov 8, 2023

RanderWang force-pushed the multi-core-merge branch from 8011537 to b22a4d4Compare November 10, 2023 05:19

kv2019i merged commit 547132b into thesofproject:mainNov 10, 2023

fredoh9 mentioned this pull request Nov 17, 2023
[BUG] multiple-pipeline test fails with DSP EXCEPTION with multicore nocodec topology #8492
Closed

Uh oh!

Conversation

RanderWang commented Sep 21, 2023• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ranj063Sep 21, 2023

Choose a reason for hiding this comment

Uh oh!

RanderWangSep 22, 2023

Choose a reason for hiding this comment

Uh oh!

lgirdwood commented Sep 25, 2023

Uh oh!

RanderWang commented Sep 26, 2023

Uh oh!

lgirdwood commented Sep 26, 2023

Uh oh!

RanderWang commented Sep 27, 2023

Uh oh!

kv2019i commented Oct 2, 2023

Uh oh!

kv2019i commented Oct 18, 2023

Uh oh!

RanderWang commented Oct 19, 2023

Uh oh!

lgirdwood commented Oct 23, 2023

Uh oh!

RanderWang commented Oct 24, 2023

Uh oh!

RanderWang commented Oct 25, 2023

Uh oh!

lgirdwood commented Oct 25, 2023

Uh oh!

lyakhOct 26, 2023

Choose a reason for hiding this comment

Uh oh!

kv2019i commented Nov 10, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

RanderWang commented Sep 21, 2023•
edited
Loading