Skip to content

base_fw: sync time between host and fw for logging#8480

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lgirdwood merged 3 commits into from
Jan 8, 2024
Merged

base_fw: sync time between host and fw for logging #8480

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e0d3a55
base_fw: convert dsp hw cycle to dsp time
RanderWang Nov 23, 2023
a506f9e
base_fw: sync time between host and fw for logging
RanderWang Dec 6, 2023
f22f2d4
board: enable 64 bits timestamp support on intel platforms
RanderWang Dec 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions app/boards/intel_adsp_ace15_mtpm.conf
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -91,3 +91,4 @@ CONFIG_DEBUG_COREDUMP_MEMORY_DUMP_MIN=y

CONFIG_PROBE=y
CONFIG_PROBE_DMA_MAX=2
CONFIG_LOG_TIMESTAMP_64BIT=y
Comment thread
RanderWang marked this conversation as resolved.
1 change: 1 addition & 0 deletions app/boards/intel_adsp_ace20_lnl.conf
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -76,3 +76,4 @@ CONFIG_COMP_KPB=y
CONFIG_COMP_ARIA=y
CONFIG_CLOCK_CONTROL_ADSP=y
CONFIG_CLOCK_CONTROL=y
CONFIG_LOG_TIMESTAMP_64BIT=y
1 change: 1 addition & 0 deletions app/boards/intel_adsp_cavs25.conf
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -75,3 +75,4 @@ CONFIG_DMA_DW_FIFO_PARTITION=y
CONFIG_DMA_INTEL_ADSP_GPDMA_HAS_LLP=y

CONFIG_HEAP_MEM_POOL_SIZE=8192
CONFIG_LOG_TIMESTAMP_64BIT=y
1 change: 1 addition & 0 deletions app/boards/intel_adsp_cavs25_tgph.conf
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -74,3 +74,4 @@ CONFIG_DMA_DW_FIFO_PARTITION=y
CONFIG_DMA_INTEL_ADSP_GPDMA_HAS_LLP=y

CONFIG_HEAP_MEM_POOL_SIZE=8192
CONFIG_LOG_TIMESTAMP_64BIT=y
Comment thread
lgirdwood marked this conversation as resolved.
33 changes: 29 additions & 4 deletions src/audio/base_fw.c
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -21,6 +21,7 @@
#include <zephyr/device.h>
#include <zephyr/drivers/counter.h>
#endif
#include <zephyr/logging/log_ctrl.h>

/* TODO: Remove platform-specific code, see https://github.com/thesofproject/sof/issues/7549 */
#if defined(CONFIG_SOC_SERIES_INTEL_ACE) || defined(CONFIG_INTEL_ADSP_CAVS)
Expand All@@ -35,6 +36,7 @@ DECLARE_SOF_RT_UUID("basefw", basefw_comp_uuid, 0xe398c32, 0x5ade, 0xba4b,
DECLARE_TR_CTX(basefw_comp_tr, SOF_UUID(basefw_comp_uuid), LOG_LEVEL_INFO);

static struct ipc4_system_time_info global_system_time_info;
static uint64_t global_cycle_delta;

static int basefw_config(uint32_t *data_offset, char *data)
{
Expand DownExpand Up@@ -241,23 +243,46 @@ static int basefw_mem_state_info(uint32_t *data_offset, char *data)
return 0;
}

static log_timestamp_t basefw_get_timestamp(void)
{
return sof_cycle_get_64() + global_cycle_delta;
}

static uint32_t basefw_set_system_time(uint32_t param_id,
bool first_block,
bool last_block,
uint32_t data_offset,
const char *data)
{
/* TODO: configurate time to logging subsystem */
uint64_t dsp_time;
uint64_t dsp_cycle;
uint64_t host_time;
Comment thread
RanderWang marked this conversation as resolved.
uint64_t host_cycle;

Comment thread
RanderWang marked this conversation as resolved.
if (!(first_block && last_block))
return IPC4_INVALID_REQUEST;

global_system_time_info.host_time.val_l = ((const struct ipc4_system_time *)data)->val_l;
global_system_time_info.host_time.val_u = ((const struct ipc4_system_time *)data)->val_u;

uint64_t current_dsp_time = sof_cycle_get_64();
dsp_cycle = sof_cycle_get_64();
dsp_time = k_cyc_to_us_floor64(dsp_cycle);

global_system_time_info.dsp_time.val_l = (uint32_t)(dsp_time);
global_system_time_info.dsp_time.val_u = (uint32_t)(dsp_time >> 32);

/* use default timestamp if 64bit is not enabled since 64bit is necessary for host time */
if (!IS_ENABLED(CONFIG_LOG_TIMESTAMP_64BIT)) {
LOG_WRN("64bits timestamp is disabled, so use default timestamp");
return IPC4_SUCCESS;
Comment thread
marc-hb marked this conversation as resolved.
}

global_system_time_info.dsp_time.val_l = (uint32_t)(current_dsp_time);
global_system_time_info.dsp_time.val_u = (uint32_t)(current_dsp_time >> 32);
host_time = global_system_time_info.host_time.val_l |
((uint64_t)global_system_time_info.host_time.val_u << 32);
host_cycle = k_us_to_cyc_ceil64(host_time);
global_cycle_delta = host_cycle - dsp_cycle;
log_set_timestamp_func(basefw_get_timestamp,
sys_clock_hw_cycles_per_sec());
Comment thread
RanderWang marked this conversation as resolved.

return IPC4_SUCCESS;
}
Expand Down