Uh oh!
There was an error while loading. Please reload this page.
rimage: Set of small improvements - #8532
Merged
Merged
Conversation
softwarecki
requested review from
abonislawski, kv2019i, lgirdwood, marc-hb, marcinszkudlinski, pjdobrowolski and tmlemanNovember 27, 2023 14:20
Uh oh!
There was an error while loading. Please reload this page.
lyakh
reviewed
Nov 28, 2023
Uh oh!
There was an error while loading. Please reload this page.
softwareckiforce-pushed
the
rimage-fix
branch
2 times, most recently
from
November 28, 2023 10:11
e53e25b to
9bbda46Comparebtian1
reviewed
Dec 4, 2023
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
lgirdwood
commented
Dec 5, 2023
Member
@softwarecki any ETA, these look nice. |
Added limit of a number of input modules provided in a command line to the maximum number of supported modules (size of module array / MAX_MODULES) Signed-off-by: Adrian Warecki <adrian.warecki@intel.com>
Used DIV_ROUND_UP macro to calculate page count. Signed-off-by: Adrian Warecki <adrian.warecki@intel.com>
Created ALIGN_UP macro to simplify calculations. Signed-off-by: Adrian Warecki <adrian.warecki@intel.com>
softwarecki
commented
Dec 7, 2023
CollaboratorAuthor
rebased |
softwarecki
marked this pull request as ready for review
December 7, 2023 14:30
softwarecki
requested review from
dbaluta, lbetlej, mmaka1 and plbossart
as code ownersDecember 7, 2023 14:30
lgirdwood
approved these changes
Dec 8, 2023
kv2019i
approved these changes
Dec 11, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added limit of a number of input modules provided in a command line to the maximum number of supported modules (size of module array / MAX_MODULES)
Created ALIGN_UP macro to simplify calculations.
Used DIV_ROUND_UP macro to calculate page count.